linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Cooper <jason@lakedaemon.net>
To: Sricharan R <r.sricharan@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	tony@atomide.com, santosh.shilimkar@ti.com, nm@ti.com,
	rnayak@ti.com, linux@arm.linux.org.uk, tglx@linutronix.de
Subject: Re: [PATCH V2 05/19] irqchip: crossbar: Change allocation logic by reversing search for free irqs
Date: Fri, 13 Jun 2014 09:13:21 -0400	[thread overview]
Message-ID: <20140613131321.GG8664@titan.lakedaemon.net> (raw)
In-Reply-To: <539A95A3.1010301@ti.com>

On Fri, Jun 13, 2014 at 11:39:39AM +0530, Sricharan R wrote:
> Hi Jason,
> 
> On Thursday 12 June 2014 06:26 PM, Jason Cooper wrote:
> > On Thu, Jun 12, 2014 at 05:23:13PM +0530, Sricharan R wrote:
> >> From: Nishanth Menon <nm@ti.com>
> >>
> >> Reverse the search algorithm to ensure that address mapping and IRQ
> >> allocation logics are proper. This can open up new bugs which are
> >> easily fixable rather than wait till allocation logic approaches
> >> the limit to find new bugs.
> > 
> > Could you expand on this logic some more?  What class of bugs are you
> > hoping to discover more easily?
> > 
> 
> class 1. address space errors -> example:
> reg = <a size_b>
> ti,max-irqs =  is a wrong parameter
> 
> class 2: irq-reserved list - which decides which entries in the
> address space is not actually wired in
> 
> class 3: wrong list of routable-irqs.
> 
> in general allocating from max to min tends to have benefits in
> ensuring the different issues that may be present in dts is easily
> caught at definition time, rather than at a later point in time.

Perfect, thanks for clarifying.  Please add this to the commit log when
you respin.

thx,

Jason.

  reply	other threads:[~2014-06-13 13:13 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-12 11:53 [PATCH V2 00/19] irqchip: crossbar: driver fixes Sricharan R
2014-06-12 11:53 ` [PATCH V2 01/19] irqchip: crossbar: dont use '0' to mark reserved interrupts Sricharan R
2014-06-12 11:53 ` [PATCH V2 02/19] irqchip: crossbar: check for premapped crossbar before allocating Sricharan R
2014-06-12 11:53 ` [PATCH V2 03/19] irqchip: crossbar: Skip some irqs from getting mapped to crossbar Sricharan R
2014-06-12 12:51   ` Jason Cooper
2014-06-12 13:19     ` Sricharan R
2014-06-12 14:07       ` Jason Cooper
2014-06-13  6:37         ` Sricharan R
2014-06-13 13:34           ` Jason Cooper
2014-06-12 13:57     ` Tony Lindgren
2014-06-12 14:05       ` Jason Cooper
2014-06-13  6:56         ` Sricharan R
2014-06-13 11:04           ` Sricharan R
2014-06-13 13:10           ` Jason Cooper
2014-06-13 13:35             ` Santosh Shilimkar
2014-06-13 13:41               ` Jason Cooper
2014-06-13  6:31       ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 04/19] irqchip: crossbar: Initialise the crossbar with a safe value Sricharan R
2014-06-12 11:53 ` [PATCH V2 05/19] irqchip: crossbar: Change allocation logic by reversing search for free irqs Sricharan R
2014-06-12 12:56   ` Jason Cooper
2014-06-13  6:09     ` Sricharan R
2014-06-13 13:13       ` Jason Cooper [this message]
2014-06-12 11:53 ` [PATCH V2 06/19] irqchip: crossbar: remove IS_ERR_VALUE check Sricharan R
2014-06-12 11:53 ` [PATCH V2 07/19] irqchip: crossbar: fix sparse warnings Sricharan R
2014-06-12 11:53 ` [PATCH V2 08/19] irqchip: crossbar: fix checkpatch warning Sricharan R
2014-06-12 13:10   ` Jason Cooper
2014-06-12 13:35     ` Sricharan R
2014-06-12 14:18       ` Joe Perches
2014-06-12 15:32         ` Jason Cooper
2014-06-12 16:05           ` Joe Perches
2014-06-13  6:30             ` Sricharan R
2014-06-13 13:15               ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 09/19] irqchip: crossbar: fix kerneldoc warning Sricharan R
2014-06-12 13:14   ` Jason Cooper
2014-06-12 13:39     ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 10/19] irqchip: crossbar: DRA7: Fix unused crossbar list Sricharan R
2014-06-12 13:16   ` Jason Cooper
2014-06-12 13:21     ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 11/19] irqchip: crossbar: fix memory leak incase of invalid entry Sricharan R
2014-06-12 13:20   ` Jason Cooper
2014-06-12 13:37     ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 12/19] irqchip: crossbar: return proper error value Sricharan R
2014-06-12 13:39   ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 13/19] irqchip: crossbar: change the goto naming Sricharan R
2014-06-12 13:41   ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 14/19] irqchip: crossbar: set cb pointer to null in case of error Sricharan R
2014-06-12 11:53 ` [PATCH V2 15/19] irqchip: crossbar: Add kerneldoc for crossbar_domain_unmap callback Sricharan R
2014-06-12 13:49   ` Jason Cooper
2014-06-12 13:50     ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 16/19] irqchip: crossbar: introduce ti,max-crossbar-sources to identify valid crossbar mapping Sricharan R
2014-06-12 13:54   ` Jason Cooper
2014-06-13 10:54     ` Sricharan R
2014-06-13 13:17       ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 17/19] irqchip: crossbar: introduce centralized check for crossbar write Sricharan R
2014-06-12 11:53 ` [PATCH V2 18/19] Documentation: dt: OMAP: crossbar: add description for interrupt consumer Sricharan R
2014-06-12 11:53 ` [PATCH V2 19/19] irqchip: crossbar allow for quirky hardware with direct hardwiring of GIC Sricharan R
2014-06-13 15:01 ` [PATCH V2 00/19] irqchip: crossbar: driver fixes Jason Cooper
2014-06-13 16:14   ` Joe Perches
2014-06-13 16:37     ` Jason Cooper
2014-06-13 16:48       ` Joe Perches
2014-06-13 16:54         ` Jason Cooper
2014-06-13 20:38           ` Thomas Gleixner
2014-06-13 22:22             ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140613131321.GG8664@titan.lakedaemon.net \
    --to=jason@lakedaemon.net \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nm@ti.com \
    --cc=r.sricharan@ti.com \
    --cc=rnayak@ti.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).