From: Sricharan R <r.sricharan@ti.com>
To: Jason Cooper <jason@lakedaemon.net>
Cc: <linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<tony@atomide.com>, <santosh.shilimkar@ti.com>, <nm@ti.com>,
<rnayak@ti.com>, <linux@arm.linux.org.uk>, <tglx@linutronix.de>
Subject: Re: [PATCH V2 03/19] irqchip: crossbar: Skip some irqs from getting mapped to crossbar
Date: Fri, 13 Jun 2014 12:07:49 +0530 [thread overview]
Message-ID: <539A9C3D.3050407@ti.com> (raw)
In-Reply-To: <20140612140729.GD8664@titan.lakedaemon.net>
Hi Jason,
On Thursday 12 June 2014 07:37 PM, Jason Cooper wrote:
> On Thu, Jun 12, 2014 at 06:49:17PM +0530, Sricharan R wrote:
>> Hi Jason,
>>
>> On Thursday 12 June 2014 06:21 PM, Jason Cooper wrote:
>>> On Thu, Jun 12, 2014 at 05:23:11PM +0530, Sricharan R wrote:
>>>> From: Nishanth Menon <nm@ti.com>
>>>>
>>>> When, in the system due to varied reasons, interrupts might be unusable
>>>> due to hardware behavior, but register maps do exist, then those interrupts
>>>> should be skipped while mapping irq to crossbars.
>>>>
>>>> Signed-off-by: Nishanth Menon <nm@ti.com>
>>>> Signed-off-by: Sricharan R <r.sricharan@ti.com>
>>>> Signed-off-by: Tony Lindgren <tony@atomide.com>
>>>
>>> Tony, have you applied these somewhere already?
>>>
>>>> ---
>>>> drivers/irqchip/irq-crossbar.c | 47 ++++++++++++++++++++++++++++++++++++----
>>>> 1 file changed, 43 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
>>>> index 51d4b87..847f6e3 100644
>>>> --- a/drivers/irqchip/irq-crossbar.c
>>>> +++ b/drivers/irqchip/irq-crossbar.c
>>>> @@ -13,11 +13,13 @@
>>>> #include <linux/io.h>
>>>> #include <linux/of_address.h>
>>>> #include <linux/of_irq.h>
>>>> +#include <linux/of_device.h>
>>>> #include <linux/slab.h>
>>>> #include <linux/irqchip/arm-gic.h>
>>>>
>>>> #define IRQ_FREE -1
>>>> #define IRQ_RESERVED -2
>>>> +#define IRQ_SKIP -3
>>>> #define GIC_IRQ_START 32
>>>>
>>>> /*
>>>> @@ -34,6 +36,16 @@ struct crossbar_device {
>>>> void (*write) (int, int);
>>>> };
>>>>
>>>> +/**
>>>> + * struct crossbar_data: Platform specific data
>>>> + * @irqs_unused: array of irqs that cannot be used because of hw erratas
>>>> + * @size: size of the irqs_unused array
>>>> + */
>>>> +struct crossbar_data {
>>>> + const uint *irqs_unused;
>>>> + const uint size;
>>>> +};
>>>> +
>>>> static struct crossbar_device *cb;
>>>>
>>>> static inline void crossbar_writel(int irq_no, int cb_no)
>>>> @@ -119,10 +131,12 @@ const struct irq_domain_ops routable_irq_domain_ops = {
>>>> .xlate = crossbar_domain_xlate
>>>> };
>>>>
>>>> -static int __init crossbar_of_init(struct device_node *node)
>>>> +static int __init crossbar_of_init(struct device_node *node,
>>>> + const struct crossbar_data *data)
>>>> {
>>>> int i, size, max, reserved = 0, entry;
>>>> const __be32 *irqsr;
>>>> + const int *irqsk = NULL;
>>>>
>>>> cb = kzalloc(sizeof(*cb), GFP_KERNEL);
>>>>
>>>> @@ -194,6 +208,22 @@ static int __init crossbar_of_init(struct device_node *node)
>>>> reserved += size;
>>>> }
>>>>
>>>> + /* Skip the ones marked as unused */
>>>> + if (data) {
>>>> + irqsk = data->irqs_unused;
>>>> + size = data->size;
>>>> +
>>>> + for (i = 0; i < size; i++) {
>>>> + entry = irqsk[i];
>>>> +
>>>> + if (entry > max) {
>>>> + pr_err("Invalid skip entry\n");
>>>> + goto err3;
>>>> + }
>>>> + cb->irq_map[entry] = IRQ_SKIP;
>>>> + }
>>>> + }
>>>> +
>>>> register_routable_domain_ops(&routable_irq_domain_ops);
>>>> return 0;
>>>>
>>>> @@ -208,18 +238,27 @@ err1:
>>>> return -ENOMEM;
>>>> }
>>>>
>>>> +/* irq number 10 cannot be used because of hw bug */
>>>> +int dra_irqs_unused[] = { 10 };
>>>> +struct crossbar_data cb_dra_data = { dra_irqs_unused,
>>>> + ARRAY_SIZE(dra_irqs_unused) };
>>>> +
>>>> static const struct of_device_id crossbar_match[] __initconst = {
>>>> - { .compatible = "ti,irq-crossbar" },
>>>> + { .compatible = "ti,irq-crossbar", .data = &cb_dra_data },
>>>> {}
>>>> };
>>>
>>> This is a bug in all implementations of this IP? Or, a specific
>>> SoC's implementation? Would this be better expressed in the dts via a
>>> property? Can we expect future implementations to be fixed?
>>>
>>> thx,
>>>
>>> Jason.
>> Infact this and PATCH#10 should be merged. I will change that.
>>
>> So in Socs's (2 so far) that do have a crossbar, some irqs are mapped
>> through a crossbar and some are directly wired to the irqchip.
>> These 'unused irqs' are those which are directly wired but they still
>> have a crossbar register. Their routing cannot be changed. So this
>> is not really expected usage of the crossbar hw ip. We initially thought
>> having a dts property separately for this, but took this path to avoid
>> loading the dts with additional bindings which may not be generic.
>
> How do you plan to handle future SoCs with this IP and possibly
> different hard-wired irqs?
Yes, that would require adding a new compatible in the above list and dts.
So if adding a new binding in the dts would be cleaner, then i will change
it that way.
Regards,
Sricharan
next prev parent reply other threads:[~2014-06-13 6:40 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 11:53 [PATCH V2 00/19] irqchip: crossbar: driver fixes Sricharan R
2014-06-12 11:53 ` [PATCH V2 01/19] irqchip: crossbar: dont use '0' to mark reserved interrupts Sricharan R
2014-06-12 11:53 ` [PATCH V2 02/19] irqchip: crossbar: check for premapped crossbar before allocating Sricharan R
2014-06-12 11:53 ` [PATCH V2 03/19] irqchip: crossbar: Skip some irqs from getting mapped to crossbar Sricharan R
2014-06-12 12:51 ` Jason Cooper
2014-06-12 13:19 ` Sricharan R
2014-06-12 14:07 ` Jason Cooper
2014-06-13 6:37 ` Sricharan R [this message]
2014-06-13 13:34 ` Jason Cooper
2014-06-12 13:57 ` Tony Lindgren
2014-06-12 14:05 ` Jason Cooper
2014-06-13 6:56 ` Sricharan R
2014-06-13 11:04 ` Sricharan R
2014-06-13 13:10 ` Jason Cooper
2014-06-13 13:35 ` Santosh Shilimkar
2014-06-13 13:41 ` Jason Cooper
2014-06-13 6:31 ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 04/19] irqchip: crossbar: Initialise the crossbar with a safe value Sricharan R
2014-06-12 11:53 ` [PATCH V2 05/19] irqchip: crossbar: Change allocation logic by reversing search for free irqs Sricharan R
2014-06-12 12:56 ` Jason Cooper
2014-06-13 6:09 ` Sricharan R
2014-06-13 13:13 ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 06/19] irqchip: crossbar: remove IS_ERR_VALUE check Sricharan R
2014-06-12 11:53 ` [PATCH V2 07/19] irqchip: crossbar: fix sparse warnings Sricharan R
2014-06-12 11:53 ` [PATCH V2 08/19] irqchip: crossbar: fix checkpatch warning Sricharan R
2014-06-12 13:10 ` Jason Cooper
2014-06-12 13:35 ` Sricharan R
2014-06-12 14:18 ` Joe Perches
2014-06-12 15:32 ` Jason Cooper
2014-06-12 16:05 ` Joe Perches
2014-06-13 6:30 ` Sricharan R
2014-06-13 13:15 ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 09/19] irqchip: crossbar: fix kerneldoc warning Sricharan R
2014-06-12 13:14 ` Jason Cooper
2014-06-12 13:39 ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 10/19] irqchip: crossbar: DRA7: Fix unused crossbar list Sricharan R
2014-06-12 13:16 ` Jason Cooper
2014-06-12 13:21 ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 11/19] irqchip: crossbar: fix memory leak incase of invalid entry Sricharan R
2014-06-12 13:20 ` Jason Cooper
2014-06-12 13:37 ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 12/19] irqchip: crossbar: return proper error value Sricharan R
2014-06-12 13:39 ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 13/19] irqchip: crossbar: change the goto naming Sricharan R
2014-06-12 13:41 ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 14/19] irqchip: crossbar: set cb pointer to null in case of error Sricharan R
2014-06-12 11:53 ` [PATCH V2 15/19] irqchip: crossbar: Add kerneldoc for crossbar_domain_unmap callback Sricharan R
2014-06-12 13:49 ` Jason Cooper
2014-06-12 13:50 ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 16/19] irqchip: crossbar: introduce ti,max-crossbar-sources to identify valid crossbar mapping Sricharan R
2014-06-12 13:54 ` Jason Cooper
2014-06-13 10:54 ` Sricharan R
2014-06-13 13:17 ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 17/19] irqchip: crossbar: introduce centralized check for crossbar write Sricharan R
2014-06-12 11:53 ` [PATCH V2 18/19] Documentation: dt: OMAP: crossbar: add description for interrupt consumer Sricharan R
2014-06-12 11:53 ` [PATCH V2 19/19] irqchip: crossbar allow for quirky hardware with direct hardwiring of GIC Sricharan R
2014-06-13 15:01 ` [PATCH V2 00/19] irqchip: crossbar: driver fixes Jason Cooper
2014-06-13 16:14 ` Joe Perches
2014-06-13 16:37 ` Jason Cooper
2014-06-13 16:48 ` Joe Perches
2014-06-13 16:54 ` Jason Cooper
2014-06-13 20:38 ` Thomas Gleixner
2014-06-13 22:22 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539A9C3D.3050407@ti.com \
--to=r.sricharan@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nm@ti.com \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).