* [PATCH] serial: samsung: Fix compile error with SERIAL_SAMSUNG_DEBUG
@ 2014-06-14 20:07 Christian Engelmayer
2014-06-14 20:33 ` Joe Perches
0 siblings, 1 reply; 5+ messages in thread
From: Christian Engelmayer @ 2014-06-14 20:07 UTC (permalink / raw)
To: linux-serial
Cc: Greg Kroah-Hartman, Jiri Slaby, Joe Perches, Jingoo Han,
linux-kernel, Christian Engelmayer
Commit e4ac92d (serial: samsung: Neaten dbg uses) contains a typo in the
changed dbg() function regarding the name of the used character buffer.
This breaks the build if actually compiled with CONFIG_SERIAL_SAMSUNG_DEBUG.
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
---
Compile tested. Applies against branch tty-next in tree
git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
---
drivers/tty/serial/samsung.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
index 3293377..c1d3ebd 100644
--- a/drivers/tty/serial/samsung.c
+++ b/drivers/tty/serial/samsung.c
@@ -66,7 +66,7 @@ static void dbg(const char *fmt, ...)
char buff[256];
va_start(va, fmt);
- vscnprintf(buff, sizeof(buf), fmt, va);
+ vscnprintf(buff, sizeof(buff), fmt, va);
va_end(va);
printascii(buff);
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] serial: samsung: Fix compile error with SERIAL_SAMSUNG_DEBUG
2014-06-14 20:07 [PATCH] serial: samsung: Fix compile error with SERIAL_SAMSUNG_DEBUG Christian Engelmayer
@ 2014-06-14 20:33 ` Joe Perches
2014-06-15 17:36 ` Sachin Kamat
0 siblings, 1 reply; 5+ messages in thread
From: Joe Perches @ 2014-06-14 20:33 UTC (permalink / raw)
To: Christian Engelmayer
Cc: linux-serial, Greg Kroah-Hartman, Jiri Slaby, Jingoo Han, linux-kernel
Greg? Can you please apply this soon?
Thanks.
On Sat, 2014-06-14 at 22:07 +0200, Christian Engelmayer wrote:
> Commit e4ac92d (serial: samsung: Neaten dbg uses) contains a typo in the
> changed dbg() function regarding the name of the used character buffer.
> This breaks the build if actually compiled with CONFIG_SERIAL_SAMSUNG_DEBUG.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
> ---
> Compile tested. Applies against branch tty-next in tree
> git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
> ---
> drivers/tty/serial/samsung.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> index 3293377..c1d3ebd 100644
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/tty/serial/samsung.c
> @@ -66,7 +66,7 @@ static void dbg(const char *fmt, ...)
> char buff[256];
>
> va_start(va, fmt);
> - vscnprintf(buff, sizeof(buf), fmt, va);
> + vscnprintf(buff, sizeof(buff), fmt, va);
> va_end(va);
>
> printascii(buff);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] serial: samsung: Fix compile error with SERIAL_SAMSUNG_DEBUG
2014-06-14 20:33 ` Joe Perches
@ 2014-06-15 17:36 ` Sachin Kamat
2014-06-15 17:46 ` Joe Perches
0 siblings, 1 reply; 5+ messages in thread
From: Sachin Kamat @ 2014-06-15 17:36 UTC (permalink / raw)
To: Joe Perches
Cc: Christian Engelmayer, linux-serial, Greg Kroah-Hartman,
Jiri Slaby, Jingoo Han, linux-kernel
On Sun, Jun 15, 2014 at 2:03 AM, Joe Perches <joe@perches.com> wrote:
> Greg? Can you please apply this soon?
A similar patch has already been posted [1]. Probably Greg will apply it
once 3.16-rc1 is out.
[1] http://www.spinics.net/lists/linux-serial/msg12843.html
Regards,
Sachin.
>
> Thanks.
>
> On Sat, 2014-06-14 at 22:07 +0200, Christian Engelmayer wrote:
>> Commit e4ac92d (serial: samsung: Neaten dbg uses) contains a typo in the
>> changed dbg() function regarding the name of the used character buffer.
>> This breaks the build if actually compiled with CONFIG_SERIAL_SAMSUNG_DEBUG.
>>
>> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] serial: samsung: Fix compile error with SERIAL_SAMSUNG_DEBUG
2014-06-15 17:36 ` Sachin Kamat
@ 2014-06-15 17:46 ` Joe Perches
2014-06-16 21:29 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Joe Perches @ 2014-06-15 17:46 UTC (permalink / raw)
To: Sachin Kamat
Cc: Christian Engelmayer, linux-serial, Greg Kroah-Hartman,
Jiri Slaby, Jingoo Han, linux-kernel
On Sun, 2014-06-15 at 23:06 +0530, Sachin Kamat wrote:
> On Sun, Jun 15, 2014 at 2:03 AM, Joe Perches <joe@perches.com> wrote:
> > Greg? Can you please apply this soon?
>
> A similar patch has already been posted [1]. Probably Greg will apply it
> once 3.16-rc1 is out.
>
> [1] http://www.spinics.net/lists/linux-serial/msg12843.html
I know. It was just another prompt to Greg.
It's just unfortunate to have a compile failure path
in Linus' tree. Especially one I introduced.
He'd said 10 days ago or so it'd be a day or two.
http://www.spinics.net/lists/linux-serial/msg12859.html
cheers, Joe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] serial: samsung: Fix compile error with SERIAL_SAMSUNG_DEBUG
2014-06-15 17:46 ` Joe Perches
@ 2014-06-16 21:29 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2014-06-16 21:29 UTC (permalink / raw)
To: Joe Perches
Cc: Sachin Kamat, Christian Engelmayer, linux-serial, Jiri Slaby,
Jingoo Han, linux-kernel
On Sun, Jun 15, 2014 at 10:46:56AM -0700, Joe Perches wrote:
> On Sun, 2014-06-15 at 23:06 +0530, Sachin Kamat wrote:
> > On Sun, Jun 15, 2014 at 2:03 AM, Joe Perches <joe@perches.com> wrote:
> > > Greg? Can you please apply this soon?
> >
> > A similar patch has already been posted [1]. Probably Greg will apply it
> > once 3.16-rc1 is out.
> >
> > [1] http://www.spinics.net/lists/linux-serial/msg12843.html
>
> I know. It was just another prompt to Greg.
>
> It's just unfortunate to have a compile failure path
> in Linus' tree. Especially one I introduced.
>
> He'd said 10 days ago or so it'd be a day or two.
>
> http://www.spinics.net/lists/linux-serial/msg12859.html
Life gets in the way, I'll get it merged in time for 3.16-rc2 or -3.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-06-16 21:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-14 20:07 [PATCH] serial: samsung: Fix compile error with SERIAL_SAMSUNG_DEBUG Christian Engelmayer
2014-06-14 20:33 ` Joe Perches
2014-06-15 17:36 ` Sachin Kamat
2014-06-15 17:46 ` Joe Perches
2014-06-16 21:29 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).