* [RFC 1/1] em28xx: fix configuration warning
@ 2014-07-07 18:51 Fabian Frederick
2014-07-07 19:03 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-07-07 18:51 UTC (permalink / raw)
To: linux-kernel; +Cc: Fabian Frederick, Mauro Carvalho Chehab, linux-media
This patch tries to solve a problem detected with random configuration.
warning: (VIDEO_EM28XX_V4L2) selects VIDEO_MT9V011 which has unmet direct dependencies (MEDIA_SUPPORT && I2C && VIDEO_V4L2 && MEDIA_CAMERA_SUPPORT)
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: linux-media@vger.kernel.org
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/media/usb/em28xx/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/usb/em28xx/Kconfig b/drivers/media/usb/em28xx/Kconfig
index f5d7198..d42e1de 100644
--- a/drivers/media/usb/em28xx/Kconfig
+++ b/drivers/media/usb/em28xx/Kconfig
@@ -7,6 +7,7 @@ config VIDEO_EM28XX
config VIDEO_EM28XX_V4L2
tristate "Empia EM28xx analog TV, video capture and/or webcam support"
depends on VIDEO_EM28XX
+ depends on MEDIA_CAMERA_SUPPORT
select VIDEOBUF2_VMALLOC
select VIDEO_SAA711X if MEDIA_SUBDRV_AUTOSELECT
select VIDEO_TVP5150 if MEDIA_SUBDRV_AUTOSELECT
--
1.8.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC 1/1] em28xx: fix configuration warning
2014-07-07 18:51 [RFC 1/1] em28xx: fix configuration warning Fabian Frederick
@ 2014-07-07 19:03 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2014-07-07 19:03 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, linux-media
Hi Fabian,
Em Mon, 07 Jul 2014 20:51:55 +0200
Fabian Frederick <fabf@skynet.be> escreveu:
> This patch tries to solve a problem detected with random configuration.
> warning: (VIDEO_EM28XX_V4L2) selects VIDEO_MT9V011 which has unmet direct dependencies (MEDIA_SUPPORT && I2C && VIDEO_V4L2 && MEDIA_CAMERA_SUPPORT)
The above warning is bogus. The thing is that em28xx driver can be
used by webcams, analog TV and/or digital TV.
No idea how to prevent Kbuild to complain about that.
Perhaps something like that will shut it up
depends on MEDIA_CAMERA_SUPPORT if MEDIA_CAMERA_SUPPORT
Regards,
Mauro
>
> Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
> Cc: linux-media@vger.kernel.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/media/usb/em28xx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/usb/em28xx/Kconfig b/drivers/media/usb/em28xx/Kconfig
> index f5d7198..d42e1de 100644
> --- a/drivers/media/usb/em28xx/Kconfig
> +++ b/drivers/media/usb/em28xx/Kconfig
> @@ -7,6 +7,7 @@ config VIDEO_EM28XX
> config VIDEO_EM28XX_V4L2
> tristate "Empia EM28xx analog TV, video capture and/or webcam support"
> depends on VIDEO_EM28XX
> + depends on MEDIA_CAMERA_SUPPORT
> select VIDEOBUF2_VMALLOC
> select VIDEO_SAA711X if MEDIA_SUBDRV_AUTOSELECT
> select VIDEO_TVP5150 if MEDIA_SUBDRV_AUTOSELECT
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-07 19:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-07 18:51 [RFC 1/1] em28xx: fix configuration warning Fabian Frederick
2014-07-07 19:03 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).