* Re: [PATCH] perf: Add vm_ops->name call for mmap event name retrieval
2014-07-14 16:09 ` Peter Zijlstra
@ 2014-07-14 16:13 ` Peter Zijlstra
2014-07-14 16:14 ` Andy Lutomirski
2014-07-14 17:37 ` Jiri Olsa
2 siblings, 0 replies; 10+ messages in thread
From: Peter Zijlstra @ 2014-07-14 16:13 UTC (permalink / raw)
To: Jiri Olsa
Cc: linux-kernel, Arnaldo Carvalho de Melo, Corey Ashford,
David Ahern, Frederic Weisbecker, Ingo Molnar, Namhyung Kim,
Paul Mackerras, luto, hpa
[-- Attachment #1: Type: text/plain, Size: 488 bytes --]
On Mon, Jul 14, 2014 at 06:09:47PM +0200, Peter Zijlstra wrote:
> On Mon, Jul 14, 2014 at 05:57:19PM +0200, Jiri Olsa wrote:
> > Following patch added another way to get mmap name:
> > 78d683e mm, fs: Add vm_ops->name as an alternative to arch_vma_name
>
> Please add to your .gitconfig:
>
> [core]
> abbrev = 12
>
> Also, you failed to CC the two people involved in that.
In any case, this patch appears to be tip only for now, so I'll queue it
in perf/core.
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] perf: Add vm_ops->name call for mmap event name retrieval
2014-07-14 16:09 ` Peter Zijlstra
2014-07-14 16:13 ` Peter Zijlstra
@ 2014-07-14 16:14 ` Andy Lutomirski
2014-07-14 16:17 ` Peter Zijlstra
2014-07-14 17:37 ` Jiri Olsa
2 siblings, 1 reply; 10+ messages in thread
From: Andy Lutomirski @ 2014-07-14 16:14 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Jiri Olsa, linux-kernel, Arnaldo Carvalho de Melo, Corey Ashford,
David Ahern, Frederic Weisbecker, Ingo Molnar, Namhyung Kim,
Paul Mackerras, H. Peter Anvin
On Mon, Jul 14, 2014 at 9:09 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Mon, Jul 14, 2014 at 05:57:19PM +0200, Jiri Olsa wrote:
>> Following patch added another way to get mmap name:
>> 78d683e mm, fs: Add vm_ops->name as an alternative to arch_vma_name
>
> Please add to your .gitconfig:
>
> [core]
> abbrev = 12
>
> Also, you failed to CC the two people involved in that.
>
>> The vdso vma mapping already switch to this and we no longer
>> get vdso name via arch_vma_name function. Adding this way to
>> the perf mmap event name retrieval code.
>>
>> Caught this via perf test:
>>
>> $ sudo ./perf test -v 7
>> 7: Validate PERF_RECORD_* events & perf_sample fields :
>> --- start ---
>>
>> SNIP
>>
>> PERF_RECORD_MMAP for [vdso] missing!
>> test child finished with 255
>> ---- end ----
>> Validate PERF_RECORD_* events & perf_sample fields: FAILED!
>>
>> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
>> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
>> Cc: David Ahern <dsahern@gmail.com>
>> Cc: Frederic Weisbecker <fweisbec@gmail.com>
>> Cc: Ingo Molnar <mingo@kernel.org>
>> Cc: Namhyung Kim <namhyung@kernel.org>
>> Cc: Paul Mackerras <paulus@samba.org>
>> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
>> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
>> ---
>> kernel/events/core.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/kernel/events/core.c b/kernel/events/core.c
>> index 67e3b9c..4799676 100644
>> --- a/kernel/events/core.c
>> +++ b/kernel/events/core.c
>> @@ -5266,6 +5266,12 @@ static void perf_event_mmap_event(struct perf_mmap_event *mmap_event)
>>
>> goto got_name;
>> } else {
>> + if (vma->vm_ops && vma->vm_ops->name) {
>> + name = (char *) vma->vm_ops->name(vma);
>> + if (name)
>> + goto cpy_name;
>> + }
>> +
Looks good to me. Sorry I missed that.
--Andy
>> name = (char *)arch_vma_name(vma);
>> if (name)
>> goto cpy_name;
>> --
>> 1.8.3.1
>>
--
Andy Lutomirski
AMA Capital Management, LLC
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] perf: Add vm_ops->name call for mmap event name retrieval
2014-07-14 16:14 ` Andy Lutomirski
@ 2014-07-14 16:17 ` Peter Zijlstra
2014-07-14 16:29 ` Andy Lutomirski
0 siblings, 1 reply; 10+ messages in thread
From: Peter Zijlstra @ 2014-07-14 16:17 UTC (permalink / raw)
To: Andy Lutomirski
Cc: Jiri Olsa, linux-kernel, Arnaldo Carvalho de Melo, Corey Ashford,
David Ahern, Frederic Weisbecker, Ingo Molnar, Namhyung Kim,
Paul Mackerras, H. Peter Anvin
[-- Attachment #1: Type: text/plain, Size: 145 bytes --]
On Mon, Jul 14, 2014 at 09:14:41AM -0700, Andy Lutomirski wrote:
> Looks good to me. Sorry I missed that.
>
Can I make that an Acked-by?
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] perf: Add vm_ops->name call for mmap event name retrieval
2014-07-14 16:17 ` Peter Zijlstra
@ 2014-07-14 16:29 ` Andy Lutomirski
2014-07-14 16:34 ` Peter Zijlstra
0 siblings, 1 reply; 10+ messages in thread
From: Andy Lutomirski @ 2014-07-14 16:29 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Jiri Olsa, linux-kernel, Arnaldo Carvalho de Melo, Corey Ashford,
David Ahern, Frederic Weisbecker, Ingo Molnar, Namhyung Kim,
Paul Mackerras, H. Peter Anvin
On Mon, Jul 14, 2014 at 9:17 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Mon, Jul 14, 2014 at 09:14:41AM -0700, Andy Lutomirski wrote:
>> Looks good to me. Sorry I missed that.
>>
>
> Can I make that an Acked-by?
Acked-by: Andy Lutomirski <luto@amacapital.net>
--Andy
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] perf: Add vm_ops->name call for mmap event name retrieval
2014-07-14 16:29 ` Andy Lutomirski
@ 2014-07-14 16:34 ` Peter Zijlstra
0 siblings, 0 replies; 10+ messages in thread
From: Peter Zijlstra @ 2014-07-14 16:34 UTC (permalink / raw)
To: Andy Lutomirski
Cc: Jiri Olsa, linux-kernel, Arnaldo Carvalho de Melo, Corey Ashford,
David Ahern, Frederic Weisbecker, Ingo Molnar, Namhyung Kim,
Paul Mackerras, H. Peter Anvin
[-- Attachment #1: Type: text/plain, Size: 374 bytes --]
On Mon, Jul 14, 2014 at 09:29:43AM -0700, Andy Lutomirski wrote:
> On Mon, Jul 14, 2014 at 9:17 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> > On Mon, Jul 14, 2014 at 09:14:41AM -0700, Andy Lutomirski wrote:
> >> Looks good to me. Sorry I missed that.
> >>
> >
> > Can I make that an Acked-by?
>
> Acked-by: Andy Lutomirski <luto@amacapital.net>
Thanks!
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] perf: Add vm_ops->name call for mmap event name retrieval
2014-07-14 16:09 ` Peter Zijlstra
2014-07-14 16:13 ` Peter Zijlstra
2014-07-14 16:14 ` Andy Lutomirski
@ 2014-07-14 17:37 ` Jiri Olsa
2014-07-14 18:18 ` Peter Zijlstra
2 siblings, 1 reply; 10+ messages in thread
From: Jiri Olsa @ 2014-07-14 17:37 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Jiri Olsa, linux-kernel, Arnaldo Carvalho de Melo, Corey Ashford,
David Ahern, Frederic Weisbecker, Ingo Molnar, Namhyung Kim,
Paul Mackerras, luto, hpa
On Mon, Jul 14, 2014 at 06:09:47PM +0200, Peter Zijlstra wrote:
> On Mon, Jul 14, 2014 at 05:57:19PM +0200, Jiri Olsa wrote:
> > Following patch added another way to get mmap name:
> > 78d683e mm, fs: Add vm_ops->name as an alternative to arch_vma_name
>
> Please add to your .gitconfig:
>
> [core]
> abbrev = 12
hum, will check
>
> Also, you failed to CC the two people involved in that.
ouch.. sry
jirka
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] perf: Add vm_ops->name call for mmap event name retrieval
2014-07-14 17:37 ` Jiri Olsa
@ 2014-07-14 18:18 ` Peter Zijlstra
0 siblings, 0 replies; 10+ messages in thread
From: Peter Zijlstra @ 2014-07-14 18:18 UTC (permalink / raw)
To: Jiri Olsa
Cc: Jiri Olsa, linux-kernel, Arnaldo Carvalho de Melo, Corey Ashford,
David Ahern, Frederic Weisbecker, Ingo Molnar, Namhyung Kim,
Paul Mackerras, luto, hpa
[-- Attachment #1: Type: text/plain, Size: 530 bytes --]
On Mon, Jul 14, 2014 at 07:37:55PM +0200, Jiri Olsa wrote:
> On Mon, Jul 14, 2014 at 06:09:47PM +0200, Peter Zijlstra wrote:
> > On Mon, Jul 14, 2014 at 05:57:19PM +0200, Jiri Olsa wrote:
> > > Following patch added another way to get mmap name:
> > > 78d683e mm, fs: Add vm_ops->name as an alternative to arch_vma_name
> >
> > Please add to your .gitconfig:
> >
> > [core]
> > abbrev = 12
>
> hum, will check
Mandated by Linus, also I've already had 8 char hash collisions, so it
really makes sense.
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread