From: Dan Carpenter <dan.carpenter@oracle.com>
To: sudip <sudipm.mukherjee@gmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: bcm : Transmit.c : fixed coding style problem
Date: Wed, 23 Jul 2014 17:08:40 +0300 [thread overview]
Message-ID: <20140723140840.GU25880@mwanda> (raw)
In-Reply-To: <1406123550-11951-1-git-send-email-sudipm.mukherjee@gmail.com>
Subject is too general. Which coding style issue did you fix?
On Wed, Jul 23, 2014 at 07:22:30PM +0530, sudip wrote:
Use your full name. "Sudip Mukherjee" not just "sudip".
> applies to next-20140723
Leave this out.
>
>
> Signed-off-by: sudip <sudipm.mukherjee@gmail.com>
Use your real name again.
> ---
> drivers/staging/bcm/Transmit.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/bcm/Transmit.c b/drivers/staging/bcm/Transmit.c
> index 05fae92..10586f8 100644
> --- a/drivers/staging/bcm/Transmit.c
> +++ b/drivers/staging/bcm/Transmit.c
> @@ -89,7 +89,8 @@ int SendControlPacket(struct bcm_mini_adapter *Adapter, char *pControlPacket)
> * to the target via the host h/w interface.
> * @return zero(success) or -ve value(failure)
> */
> -int SetupNextSend(struct bcm_mini_adapter *Adapter, struct sk_buff *Packet, USHORT Vcid)
> +int SetupNextSend(struct bcm_mini_adapter *Adapter,
> + struct sk_buff *Packet, USHORT Vcid)
> {
> int status = 0;
> bool bHeaderSupressionEnabled = false;
> @@ -205,7 +206,8 @@ int tx_pkt_handler(struct bcm_mini_adapter *Adapter)
> int status = 0;
>
> while (!kthread_should_stop()) {
> - /* FIXME - the timeout looks like workaround for racey usage of TxPktAvail */
> + /* FIXME - the timeout looks like workaround
> + for racey usage of TxPktAvail */
This is not proper style for muti-line comments.
regards,
dan carpenter
prev parent reply other threads:[~2014-07-23 14:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 13:52 [PATCH] staging: bcm : Transmit.c : fixed coding style problem sudip
2014-07-23 14:08 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140723140840.GU25880@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).