* [PATCH] staging: bcm : Transmit.c : fixed coding style problem
@ 2014-07-23 13:52 sudip
2014-07-23 14:08 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: sudip @ 2014-07-23 13:52 UTC (permalink / raw)
To: devel, gregkh; +Cc: sudip, linux-kernel
applies to next-20140723
Signed-off-by: sudip <sudipm.mukherjee@gmail.com>
---
drivers/staging/bcm/Transmit.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/bcm/Transmit.c b/drivers/staging/bcm/Transmit.c
index 05fae92..10586f8 100644
--- a/drivers/staging/bcm/Transmit.c
+++ b/drivers/staging/bcm/Transmit.c
@@ -89,7 +89,8 @@ int SendControlPacket(struct bcm_mini_adapter *Adapter, char *pControlPacket)
* to the target via the host h/w interface.
* @return zero(success) or -ve value(failure)
*/
-int SetupNextSend(struct bcm_mini_adapter *Adapter, struct sk_buff *Packet, USHORT Vcid)
+int SetupNextSend(struct bcm_mini_adapter *Adapter,
+ struct sk_buff *Packet, USHORT Vcid)
{
int status = 0;
bool bHeaderSupressionEnabled = false;
@@ -205,7 +206,8 @@ int tx_pkt_handler(struct bcm_mini_adapter *Adapter)
int status = 0;
while (!kthread_should_stop()) {
- /* FIXME - the timeout looks like workaround for racey usage of TxPktAvail */
+ /* FIXME - the timeout looks like workaround
+ for racey usage of TxPktAvail */
if (Adapter->LinkUpStatus)
wait_event_timeout(Adapter->tx_packet_wait_queue,
tx_pending(Adapter),
@@ -229,7 +231,8 @@ int tx_pkt_handler(struct bcm_mini_adapter *Adapter)
if (Adapter->bEndPointHalted == TRUE) {
Bcm_clear_halt_of_endpoints(Adapter);
Adapter->bEndPointHalted = false;
- StartInterruptUrb((struct bcm_interface_adapter *)(Adapter->pvInterfaceAdapter));
+ StartInterruptUrb((struct bcm_interface_adapter *)
+ (Adapter->pvInterfaceAdapter));
}
if (Adapter->LinkUpStatus && !Adapter->IdleMode) {
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: bcm : Transmit.c : fixed coding style problem
2014-07-23 13:52 [PATCH] staging: bcm : Transmit.c : fixed coding style problem sudip
@ 2014-07-23 14:08 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2014-07-23 14:08 UTC (permalink / raw)
To: sudip; +Cc: devel, gregkh, linux-kernel
Subject is too general. Which coding style issue did you fix?
On Wed, Jul 23, 2014 at 07:22:30PM +0530, sudip wrote:
Use your full name. "Sudip Mukherjee" not just "sudip".
> applies to next-20140723
Leave this out.
>
>
> Signed-off-by: sudip <sudipm.mukherjee@gmail.com>
Use your real name again.
> ---
> drivers/staging/bcm/Transmit.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/bcm/Transmit.c b/drivers/staging/bcm/Transmit.c
> index 05fae92..10586f8 100644
> --- a/drivers/staging/bcm/Transmit.c
> +++ b/drivers/staging/bcm/Transmit.c
> @@ -89,7 +89,8 @@ int SendControlPacket(struct bcm_mini_adapter *Adapter, char *pControlPacket)
> * to the target via the host h/w interface.
> * @return zero(success) or -ve value(failure)
> */
> -int SetupNextSend(struct bcm_mini_adapter *Adapter, struct sk_buff *Packet, USHORT Vcid)
> +int SetupNextSend(struct bcm_mini_adapter *Adapter,
> + struct sk_buff *Packet, USHORT Vcid)
> {
> int status = 0;
> bool bHeaderSupressionEnabled = false;
> @@ -205,7 +206,8 @@ int tx_pkt_handler(struct bcm_mini_adapter *Adapter)
> int status = 0;
>
> while (!kthread_should_stop()) {
> - /* FIXME - the timeout looks like workaround for racey usage of TxPktAvail */
> + /* FIXME - the timeout looks like workaround
> + for racey usage of TxPktAvail */
This is not proper style for muti-line comments.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-23 14:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-23 13:52 [PATCH] staging: bcm : Transmit.c : fixed coding style problem sudip
2014-07-23 14:08 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).