* [PATCH] firewire: ohci: disable MSI for VIA VT6315 again
[not found] ` <20140723151310.GA29360@trinnov.com>
@ 2014-07-23 18:08 ` Stefan Richter
0 siblings, 0 replies; only message in thread
From: Stefan Richter @ 2014-07-23 18:08 UTC (permalink / raw)
To: linux1394-devel; +Cc: Remy Bruno, linux-kernel
Revert half of commit d151f9854f21: If isochronous I/O is attempted with
packets larget than 1 kByte, VIA VT6315 rev 01 immediately stops to generate
any interrupts if MSI are used. Fix this by going back to legacy interrupts.
[Thread "Isochronous streaming with VT6315 OHCI",
http://marc.info/?t=139049641500003]
With smaller packets, the loss of IRQs happens too but only very rarely ---
rarely eneough that it was not yet possible for me to determine whether
QUIRK_NO_MSI is an actual fix for this rare variation of this chip bug.
I am keeping QUIRK_CYCLE_TIMER off of VT6315 rev >= 1 because this has been
verified by myself with certainty. On the other hand, I am also keeping
QUIRK_CYCLE_TIMER on for VT6315 rev 0 because I don't know at this time
whether this revision accesses Cycle Timer non-atomically like most of the
other VIA OHCIs are known to do.
Reported-by: Rémy Bruno <remy-fw@remy.trinnov.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
drivers/firewire/ohci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/firewire/ohci.c
+++ b/drivers/firewire/ohci.c
@@ -336,10 +336,10 @@ static const struct {
QUIRK_CYCLE_TIMER | QUIRK_IR_WAKE},
{PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VT6315, 0,
- QUIRK_CYCLE_TIMER | QUIRK_NO_MSI},
+ QUIRK_CYCLE_TIMER /* FIXME: necessary? */ | QUIRK_NO_MSI},
{PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VT6315, PCI_ANY_ID,
- 0},
+ QUIRK_NO_MSI},
{PCI_VENDOR_ID_VIA, PCI_ANY_ID, PCI_ANY_ID,
QUIRK_CYCLE_TIMER | QUIRK_NO_MSI},
I will attempt to get this merged tomorrow or so.
--
Stefan Richter
-=====-====- -=== =-===
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-07-23 18:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20140123154321.GA1557@trinnov.com>
[not found] ` <20140123233205.628240b5@stein>
[not found] ` <20140127100932.GB1557@trinnov.com>
[not found] ` <20140615011758.2817384f@kant>
[not found] ` <20140715185351.GA28484@trinnov.com>
[not found] ` <53C66BFC.4010500@ladisch.de>
[not found] ` <20140716135959.GA11877@trinnov.com>
[not found] ` <20140719134403.710f6df5@kant>
[not found] ` <20140723151310.GA29360@trinnov.com>
2014-07-23 18:08 ` [PATCH] firewire: ohci: disable MSI for VIA VT6315 again Stefan Richter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).