linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	linux-kernel@vger.kernel.org, namhyung@kernel.org,
	acme@kernel.org, mingo@kernel.org, peterz@infradead.org
Subject: Re: Implement lbr-as-callgraph v9
Date: Tue, 12 Aug 2014 22:55:24 +0200	[thread overview]
Message-ID: <20140812205524.GF4120@two.firstfloor.org> (raw)
In-Reply-To: <20140812135017.GB13247@krava.brq.redhat.com>

On Tue, Aug 12, 2014 at 03:50:17PM +0200, Jiri Olsa wrote:
> On Thu, Jul 31, 2014 at 10:17:00AM -0700, Andi Kleen wrote:
> 
> SNIP
> 
> > v5:
> > - Rename functions
> > - Fix gtk build problem
> > - Fix crash without -g
> > - Improve error messages
> > - Improve srcline display in various ways
> > v6:
> > - Port to latest perf/core
> > v7:
> > - Really port to latest perf/core
> > v8:
> > - Rebased on 3.16-rc1
> > v9: 
> > - Forward ported to latest tip/perf/core
> > 
> > Example output:
> > 
> >     % perf record -b -g ./tsrc/tcall
> 
> Why do we need the '-g' in here.. '-b' should be enough right?
> I saw u fill the rest of the backtrace with callchain
> data (if needed), but thats not necessary right?

Right now the callgraph processing needs -g to enable itself.
I didn't try to fix it so far because we likely use -g in these
situations where --branch-history is useful.

If you think it's important it could be fixed I think.

> 
> 
> >     [ perf record: Woken up 1 times to write data ]
> >     [ perf record: Captured and wrote 0.044 MB perf.data (~1923 samples) ]
> >     % perf report --branch-history
> 
> When I captured data like you above and run pure 'perf report'
> I did not get callchains displayed at all.
> 
> Also using 'perf report --branch-history' enables filename:line
> suffix for callchain regardless of using '-b' for data capture

That's fine isn't it? If the user specifies that option
they should have used -b.

Or do you mean it should only do it for branch entries?
Right now the callgraph code doesn't distinguish between branch
entry and callgraph entry, so it can't know. 

-Andi

  reply	other threads:[~2014-08-12 20:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-31 17:17 Implement lbr-as-callgraph v9 Andi Kleen
2014-07-31 17:17 ` [PATCH 1/9] perf, tools: Support handling complete branch stacks as histograms Andi Kleen
2014-07-31 17:17 ` [PATCH 2/9] perf, tools: Add --branch-history option to report Andi Kleen
2014-07-31 17:17 ` [PATCH 3/9] perf, tools: Enable printing the srcline in the history Andi Kleen
2014-07-31 17:17 ` [PATCH 4/9] perf, tools: Only print base source file for srcline Andi Kleen
2014-07-31 17:17 ` [PATCH 5/9] perf, tools: Support source line numbers in annotate Andi Kleen
2014-07-31 17:17 ` [PATCH 6/9] perf, tools: Fix srcline sort key output to use width Andi Kleen
2014-07-31 17:17 ` [PATCH 7/9] tools, perf: Make get_srcline fall back to sym+offset Andi Kleen
2014-07-31 17:17 ` [PATCH 8/9] tools, perf: Make srcline output address with -v Andi Kleen
2014-07-31 17:17 ` [PATCH 9/9] tools, perf: Add asprintf replacement Andi Kleen
2014-08-11  9:52 ` Implement lbr-as-callgraph v9 Jiri Olsa
2014-08-11 16:40   ` Andi Kleen
2014-08-12 13:50 ` Jiri Olsa
2014-08-12 20:55   ` Andi Kleen [this message]
2014-08-13  7:24     ` Jiri Olsa
2014-08-13 18:24       ` Andi Kleen
2014-08-14 10:40         ` Jiri Olsa
2014-09-15 23:54 Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140812205524.GF4120@two.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).