From: Gyungoh Yoo <gyungoh@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
grant.likely@linaro.org, sameo@linux.intel.com,
jack.yoo@skyworksinc.com, jason@lakedaemon.net,
heiko.stuebner@bqreaders.com, florian.vaussard@epfl.ch,
thierry.reding@gmail.com, andrew@lunn.ch,
silvio.fricke@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Adding Skyworks SKY81452 MFD driver
Date: Thu, 28 Aug 2014 10:29:26 +0900 [thread overview]
Message-ID: <20140828012926.GA2650@jack-ThinkPad-T520> (raw)
In-Reply-To: <20140827083921.GB26707@lee--X1>
On Wed, Aug 27, 2014 at 09:39:21AM +0100, Lee Jones wrote:
> On Wed, 27 Aug 2014, Gyungoh Yoo wrote:
> > On Tue, Aug 26, 2014 at 09:22:58AM +0100, Lee Jones wrote:
> > > On Mon, 25 Aug 2014, Gyungoh Yoo wrote:
> > > > On Thu, Aug 21, 2014 at 10:45:02AM +0100, Lee Jones wrote:
> > > > > When you send patch-sets, you should send them connected to one
> > > > > another AKA threaded. That way, when we're reviewing we can look at
> > > > > the other patches in the set for reference. See the man page for `git
> > > > > send-email` for details.
> > > > >
> > > > > <commit log>
> > > > >
> > > > > > Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com>
> > > > > > ---
> > >
> > > [...]
> > >
> > > > > > +static int sky81452_register_devices(struct device *dev,
> > > > > > + const struct sky81452_platform_data *pdata)
> > > > > > +{
> > > > > > + struct mfd_cell cells[] = {
> > > > > > + {
> > > > > > + .name = "sky81452-bl",
> > > > > > + .platform_data = pdata->bl_pdata,
> > > > > > + .pdata_size = sizeof(*pdata->bl_pdata),
> > > > >
> > > > > Have you tested this with DT?
> > > > >
> > > > > You're not passing the compatible string and not using
> > > > > of_platform_populate() so I'm struggling to see how it would work
> > > > > properly.
> > > >
> > > > sky81452-bl and regulator-sky81452 is parsing the information
> > > > in regulator node of its parent node. So I thought these 2 drivers
> > > > don't need compatible attribute. That is what it didn't have
> > > > compatible string.
> > > > Is is mandatory that all drivers should have compatible attribute?
> > >
> > > How do they obtain their DT nodes?
> >
> > The backlight driver which is one of the child driver is obtain its DT node like this
> >
> > np = of_get_child_by_name(dev->parent->of_node, "backlight");
>
> The MFD core provides infrastructure so you don't have to do this.
>
> Just place the compatible string in 'struct mfd_cell cells[]' and the
> core will match and populate dev->of_node for you.
I see. Thank you.
>
> > > [...]
> > >
> > > > > > + return mfd_add_devices(dev, -1, cells, ARRAY_SIZE(cells),
> > > > > > + NULL, 0, NULL);
> > > > >
> > > > > This doesn't really need to be in a function of its own. Please put
> > > > > it in .probe(). Also check for the return value and present the user
> > > > > with an error message if it fails.
> > > >
> > > > I think this need to be, in case of !CONFIG_OF.
> > > > Can you please explain more in details?
> > >
> > > Then how to you obtain the shared register map you created?
> >
> > regmap is stored in driver data in MFD.
> >
> > i2c_set_clientdata(client, regmap);
> >
> > The child drivers obain the regmap from the parent.
> >
> > struct regmap *regmap = dev_get_drvdata(dev->parent);
>
> Ah yes, of course you do. Silly of me to miss this.
>
> I also just noticed that you're also manually populating the
> chlidren's platform data. It's easier if you do this from the child
> device drivers:
>
> const struct sky81452_platform_data ppdata = dev_get_platdata(dev->parent);
> const struct sky81452_bl_platform_data = pdata = ppdata->bl_pdata;
I think it could be a good way for this. Thank you.
>
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-08-28 1:29 UTC|newest]
Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 9:08 [PATCH 1/3] Adding Skyworks SKY81452 MFD driver Gyungoh Yoo
2014-08-12 2:21 ` Gyungoh Yoo
[not found] ` <CADDor3-uhXm2x1Hpy4NT9J2OZ+83D-854GkG8JWz8MYUh0YtwA@mail.gmail.com>
2014-08-12 7:16 ` Lee Jones
2014-08-21 9:45 ` Lee Jones
2014-08-21 9:59 ` Thierry Reding
2014-08-21 11:19 ` Lee Jones
2014-08-25 7:06 ` Gyungoh Yoo
2014-08-26 8:22 ` Lee Jones
2014-08-27 4:06 ` Gyungoh Yoo
2014-08-27 8:39 ` Lee Jones
2014-08-28 1:29 ` Gyungoh Yoo [this message]
2014-08-28 10:38 ` [PATCH v2 0/7] Adding Skyworks SKY81452 device drivers Gyungoh Yoo
2014-08-28 10:43 ` [PATCH v2 1/7] Adding Skyworks SKY81452 MFD driver Gyungoh Yoo
2014-08-29 2:03 ` [PATCH v2.1 " Gyungoh Yoo
2014-09-04 9:28 ` Lee Jones
2014-09-05 4:24 ` [PATCH v2.2 1/7] regulator: sky81452: " Gyungoh Yoo
2014-08-28 10:46 ` [PATCH v2 2/7] Adding Skyworks SKY81452 regulator driver Gyungoh Yoo
2014-08-28 11:02 ` Mark Brown
2014-08-29 2:21 ` Gyungoh Yoo
2014-08-28 10:49 ` [PATCH v2 3/7] Adding Skyworks SKY81452 backlight driver Gyungoh Yoo
2014-08-28 10:56 ` [PATCH v2 4/7] Adding SKY81452 MFD device tree bindings document Gyungoh Yoo
2014-08-28 10:58 ` [PATCH v2 5/7] Adding SKY81452 regulator " Gyungoh Yoo
2014-09-01 2:46 ` Gyungoh Yoo
2014-08-28 11:00 ` [PATCH v2 6/7] Adding SKY81452 backlight " Gyungoh Yoo
2014-08-28 11:01 ` [PATCH v2 7/7] Adding SKY81452 backlight document Gyungoh Yoo
2014-10-07 4:55 ` [RESUBMIT PATCH v3 0/8] Adding Skyworks SKY81452 device drivers Gyungoh Yoo
2014-10-07 4:58 ` [RESUBMIT PATCH v3 1/8] mfd: Add support for Skyworks SKY81452 driver Gyungoh Yoo
2014-10-07 8:12 ` Lee Jones
2014-10-07 8:23 ` Gyungoh Yoo
2014-10-07 5:01 ` [RESUBMIT PATCH v3 2/8] backlight: Add support Skyworks SKY81452 backlight driver Gyungoh Yoo
2014-10-08 1:03 ` Jingoo Han
2014-10-08 8:55 ` Gyungoh Yoo
2014-10-07 5:04 ` [RESUBMIT PATCH v3 3/8] devicetree: mfd: Add new SKY81452 mfd binding Gyungoh Yoo
2014-10-07 5:04 ` [RESUBMIT PATCH v3 4/8] devicetree: backlight: add new SKY81452 backlight binding Gyungoh Yoo
2014-10-07 5:06 ` [RESUBMIT PATCH v3 5/8] devicetree: Add vendor prefix for Skyworks Solutions, Inc Gyungoh Yoo
2014-10-07 5:09 ` [RESUBMIT PATCH v3 6/8] devicetree: i2c: Add SKY81452 to the Trivial Devices list Gyungoh Yoo
2014-10-07 5:11 ` [RESUBMIT PATCH v3 7/8] regulator: sky81452: Add compatible string for device binding Gyungoh Yoo
2014-10-07 12:52 ` Mark Brown
2014-10-08 8:51 ` Gyungoh Yoo
2014-10-07 5:13 ` [RESUBMIT PATCH v3 8/8] devicetree: " Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 0/8] Add Skyworks SKY81452 device drivers Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 1/8] mfd: Add support for Skyworks SKY81452 driver Gyungoh Yoo
2014-10-21 12:30 ` Lee Jones
2014-10-23 3:16 ` Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 2/8] backlight: Add support Skyworks SKY81452 backlight driver Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 3/8] devicetree: mfd: Add new SKY81452 mfd binding Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 4/8] devicetree: backlight: Add new SKY81452 backlight binding Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 5/8] devicetree: Add vendor prefix for Skyworks Solutions, Inc Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 6/8] devicetree: i2c: Add SKY81452 to the Trivial Devices list Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 7/8] regulator: sky81452: Add compatible string for device binding Gyungoh Yoo
2014-10-13 10:35 ` Mark Brown
2014-10-14 1:11 ` Gyungoh Yoo
2014-10-14 7:56 ` Mark Brown
2014-10-17 9:19 ` Gyungoh Yoo
2014-10-17 10:17 ` Mark Brown
2014-10-17 10:43 ` Gyungoh Yoo
2014-10-17 14:26 ` Mark Brown
2014-10-20 6:10 ` Gyungoh Yoo
2014-10-22 10:27 ` Mark Brown
2014-10-23 3:14 ` Gyungoh Yoo
2014-10-23 13:01 ` Mark Brown
2014-10-24 7:54 ` Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 8/8] devicetree: " Gyungoh Yoo
2014-10-27 7:02 ` [RESUBMIT PATCH v5 0/8] Add Skyworks SKY81452 device drivers gyungoh
2014-10-27 7:02 ` [RESUBMIT PATCH v5 1/8] mfd: Add support for Skyworks SKY81452 driver gyungoh
2014-10-27 7:02 ` [RESUBMIT PATCH v5 2/8] backlight: Add support Skyworks SKY81452 backlight driver gyungoh
2014-10-27 7:05 ` Varka Bhadram
2014-10-27 7:19 ` Gyungoh Yoo
2014-10-27 7:02 ` [RESUBMIT PATCH v5 3/8] devicetree: mfd: Add new SKY81452 mfd binding gyungoh
2014-10-27 7:02 ` [RESUBMIT PATCH v5 4/8] devicetree: backlight: Add new SKY81452 backlight binding gyungoh
2014-10-27 7:02 ` [RESUBMIT PATCH v5 5/8] devicetree: Add vendor prefix for Skyworks Solutions, Inc gyungoh
2014-10-27 7:02 ` [RESUBMIT PATCH v5 6/8] devicetree: i2c: Add SKY81452 to the Trivial Devices list gyungoh
2014-10-27 7:02 ` [RESUBMIT PATCH v5 7/8] regulator: sky81452: Add compatible string for device binding gyungoh
2014-10-27 7:02 ` [RESUBMIT PATCH v5 8/8] devicetree: " gyungoh
2014-10-31 7:08 ` [RESUBMIT PATCH v6 0/8] Add Skyworks SKY81452 device drivers gyungoh
2014-10-31 7:08 ` [RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver gyungoh
2014-11-03 17:14 ` Lee Jones
2014-11-03 21:28 ` Paul Bolle
2014-11-03 22:30 ` Lee Jones
2014-11-04 9:05 ` Paul Bolle
2014-11-04 9:16 ` Lee Jones
2014-11-04 11:38 ` Mark Brown
2014-11-04 14:35 ` Lee Jones
2014-11-04 10:54 ` Lee Jones
2014-11-04 9:17 ` Lee Jones
2014-10-31 7:08 ` [RESUBMIT PATCH v6 2/8] backlight: Add support Skyworks SKY81452 backlight driver gyungoh
2014-10-31 7:08 ` [RESUBMIT PATCH v6 3/8] devicetree: mfd: Add new SKY81452 mfd binding gyungoh
2014-10-31 16:36 ` Mark Brown
2014-11-03 17:06 ` Lee Jones
2014-10-31 7:08 ` [RESUBMIT PATCH v6 4/8] devicetree: backlight: Add new SKY81452 backlight binding gyungoh
2014-10-31 7:08 ` [RESUBMIT PATCH v6 5/8] devicetree: Add vendor prefix for Skyworks Solutions, Inc gyungoh
2014-11-03 17:07 ` Lee Jones
2014-10-31 7:08 ` [RESUBMIT PATCH v6 6/8] devicetree: i2c: Add SKY81452 to the Trivial Devices list gyungoh
2014-10-31 7:08 ` [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding gyungoh
2014-10-31 16:44 ` Mark Brown
2014-11-03 21:45 ` Paul Bolle
2014-11-04 0:55 ` Mark Brown
2014-11-06 4:45 ` Gyungoh Yoo
2014-11-04 0:43 ` Gyungoh Yoo
2014-11-04 0:53 ` Mark Brown
2014-11-04 5:45 ` Gyungoh Yoo
2014-11-04 11:41 ` Mark Brown
2014-11-06 4:38 ` Gyungoh Yoo
2014-10-31 7:08 ` [RESUBMIT PATCH v6 8/8] devicetree: " gyungoh
2014-11-11 11:10 ` [RESUBMIT PATCH v6 0/8] Add Skyworks SKY81452 device drivers Lee Jones
2014-11-13 13:20 ` Gyungoh Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140828012926.GA2650@jack-ThinkPad-T520 \
--to=gyungoh@gmail.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=florian.vaussard@epfl.ch \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=heiko.stuebner@bqreaders.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jack.yoo@skyworksinc.com \
--cc=jason@lakedaemon.net \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=silvio.fricke@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).