From: Lee Jones <lee.jones@linaro.org>
To: Gyungoh Yoo <gyungoh@gmail.com>
Cc: sameo@linux.intel.com, grant.likely@linaro.org,
robh+dt@kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, jack.yoo@skyworksinc.com
Subject: Re: [RESUBMIT PATCH v3 1/8] mfd: Add support for Skyworks SKY81452 driver
Date: Tue, 7 Oct 2014 09:12:00 +0100 [thread overview]
Message-ID: <20141007081200.GC25331@lee--X1> (raw)
In-Reply-To: <1412657901-7865-1-git-send-email-jack.yoo@skyworksinc.com>
You say that this is v3, but there is no change log (usually placed
between the '---' and the diffstat). Also you have 8 patches in this
set with no 0/8 patch explaining what you're trying to achieve. For
this size patch you also require a patch commit log. What does this
driver provide? How does it provide it? Once you've addressed these
issues, I'll review your patches.
> Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com>
> ---
> drivers/mfd/Kconfig | 12 +++++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/sky81452.c | 111 +++++++++++++++++++++++++++++++++++++++++++
> include/linux/mfd/sky81452.h | 32 +++++++++++++
> 4 files changed, 156 insertions(+)
> create mode 100644 drivers/mfd/sky81452.c
> create mode 100644 include/linux/mfd/sky81452.h
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index de5abf2..6962b4e 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -626,6 +626,18 @@ config MFD_SM501_GPIO
> lines on the SM501. The platform data is used to supply the
> base number for the first GPIO line to register.
>
> +config MFD_SKY81452
> + tristate "Skyworks Solutions SKY81452"
> + select MFD_CORE
> + select REGMAP_I2C
> + depends on I2C
> + help
> + This is the core driver for the Skyworks SKY81452 backlight and
> + voltage regulator device.
> +
> + This driver can also be built as a module. If so, the module
> + will be called sky81452.
> +
> config MFD_SMSC
> bool "SMSC ECE1099 series chips"
> depends on I2C=y
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index f001487..6c2f317 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -169,6 +169,7 @@ obj-$(CONFIG_MFD_AS3711) += as3711.o
> obj-$(CONFIG_MFD_AS3722) += as3722.o
> obj-$(CONFIG_MFD_STW481X) += stw481x.o
> obj-$(CONFIG_MFD_IPAQ_MICRO) += ipaq-micro.o
> +obj-$(CONFIG_MFD_SKY81452) += sky81452.o
>
> intel-soc-pmic-objs := intel_soc_pmic_core.o intel_soc_pmic_crc.o
> obj-$(CONFIG_INTEL_SOC_PMIC) += intel-soc-pmic.o
> diff --git a/drivers/mfd/sky81452.c b/drivers/mfd/sky81452.c
> new file mode 100644
> index 0000000..9130112
> --- /dev/null
> +++ b/drivers/mfd/sky81452.c
> @@ -0,0 +1,111 @@
> +/*
> + * sky81452.c SKY81452 MFD driver
> + *
> + * Copyright 2014 Skyworks Solutions Inc.
> + * Author : Gyungoh Yoo <jack.yoo@skyworksinc.com>
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the
> + * Free Software Foundation; either version 2, or (at your option) any
> + * later version.
> + *
> + * This program is distributed in the hope that it will be useful, but
> + * WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + * General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License along
> + * with this program; if not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/init.h>
> +#include <linux/err.h>
> +#include <linux/slab.h>
> +#include <linux/i2c.h>
> +#include <linux/regmap.h>
> +#include <linux/mfd/core.h>
> +#include <linux/mfd/sky81452.h>
> +
> +static const struct regmap_config sky81452_config = {
> + .reg_bits = 8,
> + .val_bits = 8,
> +};
> +
> +static int sky81452_probe(struct i2c_client *client,
> + const struct i2c_device_id *id)
> +{
> + struct device *dev = &client->dev;
> + const struct sky81452_platform_data *pdata = dev_get_platdata(dev);
> + struct mfd_cell cells[2];
> + struct regmap *regmap;
> + int ret;
> +
> + if (!pdata) {
> + pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
> + if (!pdata)
> + return -ENOMEM;
> + }
> +
> + regmap = devm_regmap_init_i2c(client, &sky81452_config);
> + if (IS_ERR(regmap)) {
> + dev_err(dev, "failed to initialize. err=%ld", PTR_ERR(regmap));
> + return PTR_ERR(regmap);
> + }
> +
> + i2c_set_clientdata(client, regmap);
> +
> + memset(cells, 0, sizeof(cells));
> + cells[0].name = "sky81452-backlight";
> + cells[0].of_compatible = "skyworks,sky81452-backlight";
> + cells[0].platform_data = pdata->bl_pdata;
> + cells[0].pdata_size = sizeof(*pdata->bl_pdata);
> + cells[1].name = "sky81452-regulator";
> + cells[1].of_compatible = "skyworks,sky81452-regulator";
> + cells[1].platform_data = pdata->regulator_init_data;
> + cells[1].pdata_size = sizeof(*pdata->regulator_init_data);
> +
> + ret = mfd_add_devices(dev, -1, cells, ARRAY_SIZE(cells), NULL, 0, NULL);
> + if (ret)
> + dev_err(dev, "failed to add child devices. err=%d", ret);
> +
> + return ret;
> +}
> +
> +static int sky81452_remove(struct i2c_client *client)
> +{
> + mfd_remove_devices(&client->dev);
> + return 0;
> +}
> +
> +static const struct i2c_device_id sky81452_ids[] = {
> + { "sky81452" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(i2c, sky81452_ids);
> +
> +#ifdef CONFIG_OF
> +static const struct of_device_id sky81452_of_match[] = {
> + { .compatible = "skyworks,sky81452", },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, sky81452_of_match);
> +#endif
> +
> +static struct i2c_driver sky81452_driver = {
> + .driver = {
> + .name = "sky81452",
> + .of_match_table = of_match_ptr(sky81452_of_match),
> + },
> + .probe = sky81452_probe,
> + .remove = sky81452_remove,
> + .id_table = sky81452_ids,
> +};
> +
> +module_i2c_driver(sky81452_driver);
> +
> +MODULE_DESCRIPTION("Skyworks SKY81452 MFD driver");
> +MODULE_AUTHOR("Gyungoh Yoo <jack.yoo@skyworksinc.com>");
> +MODULE_LICENSE("GPL");
> +MODULE_VERSION("1.2");
> diff --git a/include/linux/mfd/sky81452.h b/include/linux/mfd/sky81452.h
> new file mode 100644
> index 0000000..142f762
> --- /dev/null
> +++ b/include/linux/mfd/sky81452.h
> @@ -0,0 +1,32 @@
> +/*
> + * sky81452.h SKY81452 MFD driver
> + *
> + * Copyright 2014 Skyworks Solutions Inc.
> + * Author : Gyungoh Yoo <jack.yoo@skyworksinc.com>
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the
> + * Free Software Foundation; either version 2, or (at your option) any
> + * later version.
> + *
> + * This program is distributed in the hope that it will be useful, but
> + * WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + * General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License along
> + * with this program; if not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#ifndef _SKY81452_H
> +#define _SKY81452_H
> +
> +#include <linux/sky81452-backlight.h>
> +#include <linux/regulator/machine.h>
> +
> +struct sky81452_platform_data {
> + struct sky81452_bl_platform_data *bl_pdata;
> + struct regulator_init_data *regulator_init_data;
> +};
> +
> +#endif
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-10-07 8:12 UTC|newest]
Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 9:08 [PATCH 1/3] Adding Skyworks SKY81452 MFD driver Gyungoh Yoo
2014-08-12 2:21 ` Gyungoh Yoo
[not found] ` <CADDor3-uhXm2x1Hpy4NT9J2OZ+83D-854GkG8JWz8MYUh0YtwA@mail.gmail.com>
2014-08-12 7:16 ` Lee Jones
2014-08-21 9:45 ` Lee Jones
2014-08-21 9:59 ` Thierry Reding
2014-08-21 11:19 ` Lee Jones
2014-08-25 7:06 ` Gyungoh Yoo
2014-08-26 8:22 ` Lee Jones
2014-08-27 4:06 ` Gyungoh Yoo
2014-08-27 8:39 ` Lee Jones
2014-08-28 1:29 ` Gyungoh Yoo
2014-08-28 10:38 ` [PATCH v2 0/7] Adding Skyworks SKY81452 device drivers Gyungoh Yoo
2014-08-28 10:43 ` [PATCH v2 1/7] Adding Skyworks SKY81452 MFD driver Gyungoh Yoo
2014-08-29 2:03 ` [PATCH v2.1 " Gyungoh Yoo
2014-09-04 9:28 ` Lee Jones
2014-09-05 4:24 ` [PATCH v2.2 1/7] regulator: sky81452: " Gyungoh Yoo
2014-08-28 10:46 ` [PATCH v2 2/7] Adding Skyworks SKY81452 regulator driver Gyungoh Yoo
2014-08-28 11:02 ` Mark Brown
2014-08-29 2:21 ` Gyungoh Yoo
2014-08-28 10:49 ` [PATCH v2 3/7] Adding Skyworks SKY81452 backlight driver Gyungoh Yoo
2014-08-28 10:56 ` [PATCH v2 4/7] Adding SKY81452 MFD device tree bindings document Gyungoh Yoo
2014-08-28 10:58 ` [PATCH v2 5/7] Adding SKY81452 regulator " Gyungoh Yoo
2014-09-01 2:46 ` Gyungoh Yoo
2014-08-28 11:00 ` [PATCH v2 6/7] Adding SKY81452 backlight " Gyungoh Yoo
2014-08-28 11:01 ` [PATCH v2 7/7] Adding SKY81452 backlight document Gyungoh Yoo
2014-10-07 4:55 ` [RESUBMIT PATCH v3 0/8] Adding Skyworks SKY81452 device drivers Gyungoh Yoo
2014-10-07 4:58 ` [RESUBMIT PATCH v3 1/8] mfd: Add support for Skyworks SKY81452 driver Gyungoh Yoo
2014-10-07 8:12 ` Lee Jones [this message]
2014-10-07 8:23 ` Gyungoh Yoo
2014-10-07 5:01 ` [RESUBMIT PATCH v3 2/8] backlight: Add support Skyworks SKY81452 backlight driver Gyungoh Yoo
2014-10-08 1:03 ` Jingoo Han
2014-10-08 8:55 ` Gyungoh Yoo
2014-10-07 5:04 ` [RESUBMIT PATCH v3 3/8] devicetree: mfd: Add new SKY81452 mfd binding Gyungoh Yoo
2014-10-07 5:04 ` [RESUBMIT PATCH v3 4/8] devicetree: backlight: add new SKY81452 backlight binding Gyungoh Yoo
2014-10-07 5:06 ` [RESUBMIT PATCH v3 5/8] devicetree: Add vendor prefix for Skyworks Solutions, Inc Gyungoh Yoo
2014-10-07 5:09 ` [RESUBMIT PATCH v3 6/8] devicetree: i2c: Add SKY81452 to the Trivial Devices list Gyungoh Yoo
2014-10-07 5:11 ` [RESUBMIT PATCH v3 7/8] regulator: sky81452: Add compatible string for device binding Gyungoh Yoo
2014-10-07 12:52 ` Mark Brown
2014-10-08 8:51 ` Gyungoh Yoo
2014-10-07 5:13 ` [RESUBMIT PATCH v3 8/8] devicetree: " Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 0/8] Add Skyworks SKY81452 device drivers Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 1/8] mfd: Add support for Skyworks SKY81452 driver Gyungoh Yoo
2014-10-21 12:30 ` Lee Jones
2014-10-23 3:16 ` Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 2/8] backlight: Add support Skyworks SKY81452 backlight driver Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 3/8] devicetree: mfd: Add new SKY81452 mfd binding Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 4/8] devicetree: backlight: Add new SKY81452 backlight binding Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 5/8] devicetree: Add vendor prefix for Skyworks Solutions, Inc Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 6/8] devicetree: i2c: Add SKY81452 to the Trivial Devices list Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 7/8] regulator: sky81452: Add compatible string for device binding Gyungoh Yoo
2014-10-13 10:35 ` Mark Brown
2014-10-14 1:11 ` Gyungoh Yoo
2014-10-14 7:56 ` Mark Brown
2014-10-17 9:19 ` Gyungoh Yoo
2014-10-17 10:17 ` Mark Brown
2014-10-17 10:43 ` Gyungoh Yoo
2014-10-17 14:26 ` Mark Brown
2014-10-20 6:10 ` Gyungoh Yoo
2014-10-22 10:27 ` Mark Brown
2014-10-23 3:14 ` Gyungoh Yoo
2014-10-23 13:01 ` Mark Brown
2014-10-24 7:54 ` Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 8/8] devicetree: " Gyungoh Yoo
2014-10-27 7:02 ` [RESUBMIT PATCH v5 0/8] Add Skyworks SKY81452 device drivers gyungoh
2014-10-27 7:02 ` [RESUBMIT PATCH v5 1/8] mfd: Add support for Skyworks SKY81452 driver gyungoh
2014-10-27 7:02 ` [RESUBMIT PATCH v5 2/8] backlight: Add support Skyworks SKY81452 backlight driver gyungoh
2014-10-27 7:05 ` Varka Bhadram
2014-10-27 7:19 ` Gyungoh Yoo
2014-10-27 7:02 ` [RESUBMIT PATCH v5 3/8] devicetree: mfd: Add new SKY81452 mfd binding gyungoh
2014-10-27 7:02 ` [RESUBMIT PATCH v5 4/8] devicetree: backlight: Add new SKY81452 backlight binding gyungoh
2014-10-27 7:02 ` [RESUBMIT PATCH v5 5/8] devicetree: Add vendor prefix for Skyworks Solutions, Inc gyungoh
2014-10-27 7:02 ` [RESUBMIT PATCH v5 6/8] devicetree: i2c: Add SKY81452 to the Trivial Devices list gyungoh
2014-10-27 7:02 ` [RESUBMIT PATCH v5 7/8] regulator: sky81452: Add compatible string for device binding gyungoh
2014-10-27 7:02 ` [RESUBMIT PATCH v5 8/8] devicetree: " gyungoh
2014-10-31 7:08 ` [RESUBMIT PATCH v6 0/8] Add Skyworks SKY81452 device drivers gyungoh
2014-10-31 7:08 ` [RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver gyungoh
2014-11-03 17:14 ` Lee Jones
2014-11-03 21:28 ` Paul Bolle
2014-11-03 22:30 ` Lee Jones
2014-11-04 9:05 ` Paul Bolle
2014-11-04 9:16 ` Lee Jones
2014-11-04 11:38 ` Mark Brown
2014-11-04 14:35 ` Lee Jones
2014-11-04 10:54 ` Lee Jones
2014-11-04 9:17 ` Lee Jones
2014-10-31 7:08 ` [RESUBMIT PATCH v6 2/8] backlight: Add support Skyworks SKY81452 backlight driver gyungoh
2014-10-31 7:08 ` [RESUBMIT PATCH v6 3/8] devicetree: mfd: Add new SKY81452 mfd binding gyungoh
2014-10-31 16:36 ` Mark Brown
2014-11-03 17:06 ` Lee Jones
2014-10-31 7:08 ` [RESUBMIT PATCH v6 4/8] devicetree: backlight: Add new SKY81452 backlight binding gyungoh
2014-10-31 7:08 ` [RESUBMIT PATCH v6 5/8] devicetree: Add vendor prefix for Skyworks Solutions, Inc gyungoh
2014-11-03 17:07 ` Lee Jones
2014-10-31 7:08 ` [RESUBMIT PATCH v6 6/8] devicetree: i2c: Add SKY81452 to the Trivial Devices list gyungoh
2014-10-31 7:08 ` [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding gyungoh
2014-10-31 16:44 ` Mark Brown
2014-11-03 21:45 ` Paul Bolle
2014-11-04 0:55 ` Mark Brown
2014-11-06 4:45 ` Gyungoh Yoo
2014-11-04 0:43 ` Gyungoh Yoo
2014-11-04 0:53 ` Mark Brown
2014-11-04 5:45 ` Gyungoh Yoo
2014-11-04 11:41 ` Mark Brown
2014-11-06 4:38 ` Gyungoh Yoo
2014-10-31 7:08 ` [RESUBMIT PATCH v6 8/8] devicetree: " gyungoh
2014-11-11 11:10 ` [RESUBMIT PATCH v6 0/8] Add Skyworks SKY81452 device drivers Lee Jones
2014-11-13 13:20 ` Gyungoh Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007081200.GC25331@lee--X1 \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=gyungoh@gmail.com \
--cc=jack.yoo@skyworksinc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).