* [PATCH percpu/for-3.18] percpu: fix locking regression in the failure path of pcpu_alloc()
[not found] ` <alpine.DEB.2.10.1409081121210.2406@hadrien>
@ 2014-09-08 23:07 ` Tejun Heo
0 siblings, 0 replies; only message in thread
From: Tejun Heo @ 2014-09-08 23:07 UTC (permalink / raw)
To: Julia Lawall; +Cc: kbuild test robot, kbuild, dan.carpenter, linux-kernel
>From 23cb8981ed929b4dd48141401cd0fd31e0fa4ed0 Mon Sep 17 00:00:00 2001
From: Tejun Heo <tj@kernel.org>
Date: Tue, 9 Sep 2014 08:02:45 +0900
While updating locking, b38d08f3181c ("percpu: restructure locking")
broke pcpu_create_chunk() creation path in pcpu_alloc(). It returns
without releasing pcpu_alloc_mutex. Fix it.
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
---
Applied to percpu/for-3.18.
Thanks a lot!
mm/percpu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/percpu.c b/mm/percpu.c
index 867efd3..af3dd27 100644
--- a/mm/percpu.c
+++ b/mm/percpu.c
@@ -974,6 +974,7 @@ restart:
if (list_empty(&pcpu_slot[pcpu_nr_slots - 1])) {
chunk = pcpu_create_chunk();
if (!chunk) {
+ mutex_unlock(&pcpu_alloc_mutex);
err = "failed to allocate new chunk";
goto fail;
}
--
1.9.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2014-09-08 23:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <540d6d8e.bX1TYtX2p4laJeSu%fengguang.wu@intel.com>
[not found] ` <alpine.DEB.2.10.1409081121210.2406@hadrien>
2014-09-08 23:07 ` [PATCH percpu/for-3.18] percpu: fix locking regression in the failure path of pcpu_alloc() Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).