From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: Mark S <mstanovich15@gmail.com>,
linux-kernel@vger.kernel.org,
Octavian Purdila <octavian.purdila@intel.com>,
Jun Tian <jun.j.tian@intel.com>, Alan Cox <alan@linux.intel.com>
Subject: Re: 3.15 Regression Due to goldfish bus Commit
Date: Sun, 14 Sep 2014 19:09:57 -0700 [thread overview]
Message-ID: <20140915020957.GA8203@kroah.com> (raw)
In-Reply-To: <20140915001219.63fb91dd@alan.etchedpixels.co.uk>
On Mon, Sep 15, 2014 at 12:12:19AM +0100, One Thousand Gnomes wrote:
> On Sun, 14 Sep 2014 14:57:37 -0700
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> > On Sun, Sep 14, 2014 at 05:38:55PM -0400, Mark S wrote:
> > > Commit c1bc97f8f498a2bfab63ceef761fb0e88ef7c065 causes a gateway x86 laptop,
> > > booting from a usb device, to hang before the kernel completes booting. The
> > > offending commit was found using git bisect. Reverting the commit fixes the
> > > problem on 3.16.2.
> > >
> > > The error resulting in the hang may not be a concern since the goldfish option
> > > is not needed and should probably not be selected. I'm mentioning this problem
> > > just in case it is unexpected behavior and it is worth fixing. Maybe the
> > > goldfish option should not be selectable for a similar configuration as mine?
> >
> > There should be some other type of run-time option to not have this code
> > run if it is found to not be running on the goldfish virtual machine.
> >
> > Anyone know how to do that?
>
> I asked last time it was reported and the time before (it comes up every
> year or two). There is no sane documented way to detect the Goldfish
> virtual machine as distinct from anything else.
>
> We could hide Goldfish under expert ?
No, that would be a mess. Just put a big warning on the option, no one
should be enabling it if they don't want it, the config option text
should say this.
thanks,
greg k-h
prev parent reply other threads:[~2014-09-15 2:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAPC5HRoW4pdMhBrJfQ40ZnJoon+zCRtAnZzzgEExw4ks=Trr2g@mail.gmail.com>
2014-09-14 21:57 ` 3.15 Regression Due to goldfish bus Commit Greg Kroah-Hartman
2014-09-14 23:12 ` One Thousand Gnomes
2014-09-15 2:09 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915020957.GA8203@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=jun.j.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mstanovich15@gmail.com \
--cc=octavian.purdila@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).