From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/5] sound: pci: ctxfi: added reference of snd_card
Date: Mon, 22 Sep 2014 13:45:41 +0530 [thread overview]
Message-ID: <20140922081541.GC4870@sudip-PC> (raw)
In-Reply-To: <s5h61gg6sq2.wl-tiwai@suse.de>
On Mon, Sep 22, 2014 at 09:04:53AM +0200, Takashi Iwai wrote:
> At Sun, 21 Sep 2014 21:33:37 +0530,
> Sudip Mukherjee wrote:
> >
> > added and initialized a pointer of snd_card in the struct hw to get a reference of
> > the card in other functions
>
> You need to explain why this change is needed. The above text shows
> what it'd do, but it doesn't give any explanation to convince why this
> patch must be merged in. In this case, it's a preliminary patch for
> the changes to convert to dev_*() later. It's the most important bit,
> so don't forget it.
>
then do i mention in the commit that it is the preliminary patch for the later changes to dev_* ?
i was thinking that we can get a reference of the card from other functions which are using struct hw
is a reason by itself.
thanks
sudip
>
> thanks,
>
> Takashi
>
> >
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > ---
> > sound/pci/ctxfi/ctatc.c | 1 +
> > sound/pci/ctxfi/cthardware.h | 2 ++
> > 2 files changed, 3 insertions(+)
> >
> > diff --git a/sound/pci/ctxfi/ctatc.c b/sound/pci/ctxfi/ctatc.c
> > index d92a08c..b21eda4 100644
> > --- a/sound/pci/ctxfi/ctatc.c
> > +++ b/sound/pci/ctxfi/ctatc.c
> > @@ -1333,6 +1333,7 @@ static int atc_create_hw_devs(struct ct_atc *atc)
> > pr_err("Failed to create hw obj!!!\n");
> > return err;
> > }
> > + hw->card = atc->card;
> > atc->hw = hw;
> >
> > /* Initialize card hardware. */
> > diff --git a/sound/pci/ctxfi/cthardware.h b/sound/pci/ctxfi/cthardware.h
> > index 5977e9a..940bbd0 100644
> > --- a/sound/pci/ctxfi/cthardware.h
> > +++ b/sound/pci/ctxfi/cthardware.h
> > @@ -20,6 +20,7 @@
> >
> > #include <linux/types.h>
> > #include <linux/pci.h>
> > +#include <sound/core.h>
> >
> > enum CHIPTYP {
> > ATC20K1,
> > @@ -184,6 +185,7 @@ struct hw {
> > void *irq_callback_data;
> >
> > struct pci_dev *pci; /* the pci kernel structure of this card */
> > + struct snd_card *card; /* pointer to this card */
> > int irq;
> > unsigned long io_base;
> > unsigned long mem_base;
> > --
> > 1.8.1.2
> >
next prev parent reply other threads:[~2014-09-22 8:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-21 16:03 [PATCH v3 1/5] sound: pci: ctxfi: added reference of snd_card Sudip Mukherjee
2014-09-21 16:03 ` [PATCH v3 2/5] sound: pci: ctxfi: ctatc.c: added reference to card Sudip Mukherjee
2014-09-21 16:03 ` [PATCH v3 3/5] sound: pci: ctxfi: pr_* replaced with dev_* Sudip Mukherjee
2014-09-22 7:08 ` Takashi Iwai
2014-09-22 8:08 ` Sudip Mukherjee
2014-09-21 16:03 ` [PATCH v3 4/5] sound: pci: ctxfi: cthw20k2.c: sparse warning of incorrect type Sudip Mukherjee
2014-09-22 7:10 ` Takashi Iwai
2014-09-22 8:09 ` Sudip Mukherjee
2014-09-21 16:03 ` [PATCH v3 5/5] sound: pci: ctxfi: cthw20k1.c: " Sudip Mukherjee
2014-09-22 7:04 ` [PATCH v3 1/5] sound: pci: ctxfi: added reference of snd_card Takashi Iwai
2014-09-22 8:15 ` Sudip Mukherjee [this message]
2014-09-22 8:21 ` Takashi Iwai
2014-09-22 8:46 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140922081541.GC4870@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).