From: Takashi Iwai <tiwai@suse.de>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/5] sound: pci: ctxfi: pr_* replaced with dev_*
Date: Mon, 22 Sep 2014 09:08:05 +0200 [thread overview]
Message-ID: <s5h4mw06skq.wl-tiwai@suse.de> (raw)
In-Reply-To: <1411315421-24138-3-git-send-email-sudipm.mukherjee@gmail.com>
At Sun, 21 Sep 2014 21:33:39 +0530,
Sudip Mukherjee wrote:
>
> pr_* macros replaced with dev_* as they are more preffered over pr_*.
In this patch, it's not trivial conversion, so it's not bad to spend
more words to explain how you did it. Nevertheless...
(snip)
> diff --git a/sound/pci/ctxfi/ctamixer.c b/sound/pci/ctxfi/ctamixer.c
> index fed6e6a..955b2af 100644
> --- a/sound/pci/ctxfi/ctamixer.c
> +++ b/sound/pci/ctxfi/ctamixer.c
> @@ -258,7 +258,8 @@ static int get_amixer_rsc(struct amixer_mgr *mgr,
> }
> spin_unlock_irqrestore(&mgr->mgr_lock, flags);
> if (err) {
> - pr_err("ctxfi: Can't meet AMIXER resource request!\n");
> + dev_err(((struct hw *)(mgr->mgr.hw))->card->dev,
> + "Can't meet AMIXER resource request!\n");
Do we agree that such a change is too ugly, right? And...
> diff --git a/sound/pci/ctxfi/ctatc.c b/sound/pci/ctxfi/ctatc.c
> index 3e29e13..6c185d0 100644
> --- a/sound/pci/ctxfi/ctatc.c
> +++ b/sound/pci/ctxfi/ctatc.c
> @@ -186,7 +186,7 @@ static unsigned int convert_format(snd_pcm_format_t snd_format,
> case SNDRV_PCM_FORMAT_FLOAT_LE:
> return SRC_SF_F32;
> default:
> - pr_err("ctxfi: not recognized snd format is %d\n",
> + dev_err(card->dev, "ctxfi: not recognized snd format is %d\n",
> snd_format);
You forgot to strip the superfluous prefix in many places.
Takashi
next prev parent reply other threads:[~2014-09-22 7:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-21 16:03 [PATCH v3 1/5] sound: pci: ctxfi: added reference of snd_card Sudip Mukherjee
2014-09-21 16:03 ` [PATCH v3 2/5] sound: pci: ctxfi: ctatc.c: added reference to card Sudip Mukherjee
2014-09-21 16:03 ` [PATCH v3 3/5] sound: pci: ctxfi: pr_* replaced with dev_* Sudip Mukherjee
2014-09-22 7:08 ` Takashi Iwai [this message]
2014-09-22 8:08 ` Sudip Mukherjee
2014-09-21 16:03 ` [PATCH v3 4/5] sound: pci: ctxfi: cthw20k2.c: sparse warning of incorrect type Sudip Mukherjee
2014-09-22 7:10 ` Takashi Iwai
2014-09-22 8:09 ` Sudip Mukherjee
2014-09-21 16:03 ` [PATCH v3 5/5] sound: pci: ctxfi: cthw20k1.c: " Sudip Mukherjee
2014-09-22 7:04 ` [PATCH v3 1/5] sound: pci: ctxfi: added reference of snd_card Takashi Iwai
2014-09-22 8:15 ` Sudip Mukherjee
2014-09-22 8:21 ` Takashi Iwai
2014-09-22 8:46 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h4mw06skq.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).