linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: "Wang, Yalin" <Yalin.Wang@sonymobile.com>,
	"Will Deacon" <Will.Deacon@arm.com>,
	"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
	"'linux-arm-kernel@lists.infradead.org'"
	<linux-arm-kernel@lists.infradead.org>,
	"'linux-mm@kvack.org'" <linux-mm@kvack.org>,
	"'linux-arm-msm@vger.kernel.org'" <linux-arm-msm@vger.kernel.org>,
	"'Uwe Kleine-König'" <u.kleine-koenig@pengutronix.de>,
	DL-WW-ContributionOfficers-Linux
	<DL-WW-ContributionOfficers-Linux@sonymobile.com>
Subject: Re: [PATCH resend] arm:extend the reserved memory for initrd to be page aligned
Date: Thu, 25 Sep 2014 16:44:04 +0100	[thread overview]
Message-ID: <20140925154403.GL10390@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <20140925143142.GF5182@n2100.arm.linux.org.uk>

On Thu, Sep 25, 2014 at 03:31:42PM +0100, Russell King - ARM Linux wrote:
> On Fri, Sep 19, 2014 at 11:00:02AM +0100, Catalin Marinas wrote:
> > On Fri, Sep 19, 2014 at 08:09:47AM +0100, Wang, Yalin wrote:
> > > this patch extend the start and end address of initrd to be page aligned,
> > > so that we can free all memory including the un-page aligned head or tail
> > > page of initrd, if the start or end address of initrd are not page
> > > aligned, the page can't be freed by free_initrd_mem() function.
> > > 
> > > Signed-off-by: Yalin Wang <yalin.wang@sonymobile.com>
> > 
> > Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> > 
> > (as I said, if Russell doesn't have any objections please send the patch
> > to his patch system)
> 
> I now have an objection.  The patches in the emails were properly formatted.

They were so close ;)

I can see three patches but none of them exactly right:

8157/1 - wrong diff format
8159/1 - correct format, does not have my ack (you can take this one if
	 you want)
8162/1 - got my ack this time but with the wrong diff format again

Maybe a pull request is a better idea.

-- 
Catalin

  reply	other threads:[~2014-09-25 15:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-19  7:09 [PATCH resend] arm:extend the reserved memory for initrd to be page aligned Wang, Yalin
2014-09-19 10:00 ` Catalin Marinas
2014-09-25 14:31   ` Russell King - ARM Linux
2014-09-25 15:44     ` Catalin Marinas [this message]
2014-09-26  2:40       ` Wang, Yalin
2014-09-29 19:21         ` Valdis.Kletnieks
2014-09-30  7:02           ` Uwe Kleine-König
2014-09-30  9:24             ` Valdis.Kletnieks
2014-09-30  9:59           ` Russell King - ARM Linux
2014-09-28  1:50       ` Wang, Yalin
2014-09-26  1:56     ` Wang, Yalin
2014-10-08 11:54 ` Geert Uytterhoeven
2014-10-09  7:25   ` Wang, Yalin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140925154403.GL10390@e104818-lin.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=DL-WW-ContributionOfficers-Linux@sonymobile.com \
    --cc=Will.Deacon@arm.com \
    --cc=Yalin.Wang@sonymobile.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@arm.linux.org.uk \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).