* linux-next: build failure after merge of the akpm-current tree
@ 2014-09-26 10:17 Stephen Rothwell
2014-09-26 15:02 ` [PATCH -mm] signal-use-build_bug-instead-of-_nsig_words_is_unsupported_size.fix Oleg Nesterov
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2014-09-26 10:17 UTC (permalink / raw)
To: Andrew Morton
Cc: linux-next, linux-kernel, Guenter Roeck, Oleg Nesterov, Josh Triplett
[-- Attachment #1: Type: text/plain, Size: 1363 bytes --]
Hi Andrew,
After merging the akpm-current tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
In file included from arch/powerpc/kernel/asm-offsets.c:16:0:
include/linux/signal.h: In function 'sigisemptyset':
include/linux/signal.h:79:3: error: implicit declaration of function 'BUILD_BUG' [-Werror=implicit-function-declaration]
BUILD_BUG();
^
Caused by commit 7e52cdba7e69 ("signal: use BUILD_BUG() instead of
_NSIG_WORDS_is_unsupported_size()").
See Rule 1 in Documentation/SubmitChecklist.
Thanks to Guenter for the heads up.
I have added the following patch for today (hopefully it does not cause
more problems).
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 26 Sep 2014 20:08:12 +1000
Subject: [PATCH] signal.h: using BUILD_BUG requires including bug.h
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
include/linux/signal.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/signal.h b/include/linux/signal.h
index 14acfd59ed1b..ab1e0392b5ac 100644
--- a/include/linux/signal.h
+++ b/include/linux/signal.h
@@ -2,6 +2,7 @@
#define _LINUX_SIGNAL_H
#include <linux/list.h>
+#include <linux/bug.h>
#include <uapi/linux/signal.h>
struct task_struct;
--
2.1.1
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH -mm] signal-use-build_bug-instead-of-_nsig_words_is_unsupported_size.fix
2014-09-26 10:17 linux-next: build failure after merge of the akpm-current tree Stephen Rothwell
@ 2014-09-26 15:02 ` Oleg Nesterov
0 siblings, 0 replies; 2+ messages in thread
From: Oleg Nesterov @ 2014-09-26 15:02 UTC (permalink / raw)
To: Stephen Rothwell, Andrew Morton
Cc: linux-next, linux-kernel, Guenter Roeck, Josh Triplett
From: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes signal-use-build_bug-instead-of-_nsig_words_is_unsupported_size.patch
which caused the build failure on powerpc.
Add missing "include <linux/bug.h>" which defines BUILD_BUG()
used by that patch.
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
include/linux/signal.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/signal.h b/include/linux/signal.h
index 14acfd5..ab1e039 100644
--- a/include/linux/signal.h
+++ b/include/linux/signal.h
@@ -2,6 +2,7 @@
#define _LINUX_SIGNAL_H
#include <linux/list.h>
+#include <linux/bug.h>
#include <uapi/linux/signal.h>
struct task_struct;
--
1.5.5.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-26 15:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-26 10:17 linux-next: build failure after merge of the akpm-current tree Stephen Rothwell
2014-09-26 15:02 ` [PATCH -mm] signal-use-build_bug-instead-of-_nsig_words_is_unsupported_size.fix Oleg Nesterov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).