* [PATCH V2 linux-next] jffs2: fix sparse warning: unexpected unlock
@ 2014-09-28 19:26 Fabian Frederick
2014-09-29 0:02 ` Josh Triplett
2014-10-22 8:40 ` Brian Norris
0 siblings, 2 replies; 3+ messages in thread
From: Fabian Frederick @ 2014-09-28 19:26 UTC (permalink / raw)
To: linux-kernel
Cc: linux-sparse, Josh Triplett, Brian Norris, Fabian Frederick,
David Woodhouse, linux-mtd
fs/jffs2/summary.c:846:5: warning: context imbalance in 'jffs2_sum_write_sumnode' - unexpected unlock
Suggested-by: Brian Norris <computersforpeace@gmail.com>
Suggested-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
V2: use __must_hold instead of __releases / __acquires
(suggested by Brian Norris and Josh Triplett)
fs/jffs2/summary.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/jffs2/summary.c b/fs/jffs2/summary.c
index c522d09..bc53854 100644
--- a/fs/jffs2/summary.c
+++ b/fs/jffs2/summary.c
@@ -844,6 +844,7 @@ static int jffs2_sum_write_data(struct jffs2_sb_info *c, struct jffs2_eraseblock
/* Write out summary information - called from jffs2_do_reserve_space */
int jffs2_sum_write_sumnode(struct jffs2_sb_info *c)
+ __must_hold(&c->erase_completion_block)
{
int datasize, infosize, padsize;
struct jffs2_eraseblock *jeb;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V2 linux-next] jffs2: fix sparse warning: unexpected unlock
2014-09-28 19:26 [PATCH V2 linux-next] jffs2: fix sparse warning: unexpected unlock Fabian Frederick
@ 2014-09-29 0:02 ` Josh Triplett
2014-10-22 8:40 ` Brian Norris
1 sibling, 0 replies; 3+ messages in thread
From: Josh Triplett @ 2014-09-29 0:02 UTC (permalink / raw)
To: Fabian Frederick
Cc: linux-kernel, linux-sparse, Brian Norris, David Woodhouse, linux-mtd
On Sun, Sep 28, 2014 at 09:26:32PM +0200, Fabian Frederick wrote:
> fs/jffs2/summary.c:846:5: warning: context imbalance in 'jffs2_sum_write_sumnode' - unexpected unlock
>
> Suggested-by: Brian Norris <computersforpeace@gmail.com>
> Suggested-by: Josh Triplett <josh@joshtriplett.org>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> V2: use __must_hold instead of __releases / __acquires
> (suggested by Brian Norris and Josh Triplett)
>
> fs/jffs2/summary.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/jffs2/summary.c b/fs/jffs2/summary.c
> index c522d09..bc53854 100644
> --- a/fs/jffs2/summary.c
> +++ b/fs/jffs2/summary.c
> @@ -844,6 +844,7 @@ static int jffs2_sum_write_data(struct jffs2_sb_info *c, struct jffs2_eraseblock
> /* Write out summary information - called from jffs2_do_reserve_space */
>
> int jffs2_sum_write_sumnode(struct jffs2_sb_info *c)
> + __must_hold(&c->erase_completion_block)
> {
> int datasize, infosize, padsize;
> struct jffs2_eraseblock *jeb;
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2 linux-next] jffs2: fix sparse warning: unexpected unlock
2014-09-28 19:26 [PATCH V2 linux-next] jffs2: fix sparse warning: unexpected unlock Fabian Frederick
2014-09-29 0:02 ` Josh Triplett
@ 2014-10-22 8:40 ` Brian Norris
1 sibling, 0 replies; 3+ messages in thread
From: Brian Norris @ 2014-10-22 8:40 UTC (permalink / raw)
To: Fabian Frederick
Cc: linux-kernel, linux-sparse, Josh Triplett, David Woodhouse, linux-mtd
On Sun, Sep 28, 2014 at 09:26:32PM +0200, Fabian Frederick wrote:
> fs/jffs2/summary.c:846:5: warning: context imbalance in 'jffs2_sum_write_sumnode' - unexpected unlock
>
> Suggested-by: Brian Norris <computersforpeace@gmail.com>
> Suggested-by: Josh Triplett <josh@joshtriplett.org>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> V2: use __must_hold instead of __releases / __acquires
> (suggested by Brian Norris and Josh Triplett)
Pushed to l2-mtd.git. Thanks!
Brian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-22 8:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-28 19:26 [PATCH V2 linux-next] jffs2: fix sparse warning: unexpected unlock Fabian Frederick
2014-09-29 0:02 ` Josh Triplett
2014-10-22 8:40 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).