* [PATCH] staging: bcm: multiple checkpatch fixes for InterfaceIdleMode.c
@ 2014-09-30 17:26 Karthik Nayak
2014-09-30 18:52 ` Mark Einon
2014-10-08 22:40 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Karthik Nayak @ 2014-09-30 17:26 UTC (permalink / raw)
To: linux-kernel; +Cc: devel, gamerh2o, gregkh, mark.einon, Karthik Nayak
1. WARNING: else is not generally useful after a break or return
2. WARNING: quoted string split across lines
3. WARNING: break quoted strings at a space character
Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
---
drivers/staging/bcm/InterfaceIdleMode.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceIdleMode.c b/drivers/staging/bcm/InterfaceIdleMode.c
index c84ee49..9a77a98 100644
--- a/drivers/staging/bcm/InterfaceIdleMode.c
+++ b/drivers/staging/bcm/InterfaceIdleMode.c
@@ -188,10 +188,9 @@ static int InterfaceAbortIdlemode(struct bcm_mini_adapter *Adapter,
5000);
if (status)
return status;
- else
- BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS,
- IDLE_MODE, DBG_LVL_ALL,
- "NOB Sent down :%d", lenwritten);
+ BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS,
+ IDLE_MODE, DBG_LVL_ALL,
+ "NOB Sent down :%d", lenwritten);
/* mdelay(25); */
@@ -211,8 +210,8 @@ static int InterfaceAbortIdlemode(struct bcm_mini_adapter *Adapter,
else
BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS,
IDLE_MODE, DBG_LVL_ALL,
- "Number of completed iteration to"
- "read chip-id :%lu", itr);
+ "Number of completed iteration to read chip-id :%lu",
+ itr);
status = wrmalt(Adapter, SW_ABORT_IDLEMODE_LOC,
&Pattern, sizeof(status));
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: bcm: multiple checkpatch fixes for InterfaceIdleMode.c
2014-09-30 17:26 [PATCH] staging: bcm: multiple checkpatch fixes for InterfaceIdleMode.c Karthik Nayak
@ 2014-09-30 18:52 ` Mark Einon
2014-10-08 22:40 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Mark Einon @ 2014-09-30 18:52 UTC (permalink / raw)
To: Karthik Nayak; +Cc: linux-kernel, devel, gamerh2o, gregkh, mark.einon
On Tue, Sep 30, 2014 at 10:56:17PM +0530, Karthik Nayak wrote:
> 1. WARNING: else is not generally useful after a break or return
>
> 2. WARNING: quoted string split across lines
>
> 3. WARNING: break quoted strings at a space character
>
> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
> ---
Hi again,
You probably wanted to send this patch to the maintainer of this driver,
instead of me. I suggest you re-run scripts/getmaintainer.pl on the patch.
Cheers,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: bcm: multiple checkpatch fixes for InterfaceIdleMode.c
2014-09-30 17:26 [PATCH] staging: bcm: multiple checkpatch fixes for InterfaceIdleMode.c Karthik Nayak
2014-09-30 18:52 ` Mark Einon
@ 2014-10-08 22:40 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2014-10-08 22:40 UTC (permalink / raw)
To: Karthik Nayak; +Cc: linux-kernel, devel, gamerh2o, mark.einon
On Tue, Sep 30, 2014 at 10:56:17PM +0530, Karthik Nayak wrote:
> 1. WARNING: else is not generally useful after a break or return
>
> 2. WARNING: quoted string split across lines
>
> 3. WARNING: break quoted strings at a space character
>
> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
> ---
> drivers/staging/bcm/InterfaceIdleMode.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
Doesn't apply to my tree :(
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-08 22:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-30 17:26 [PATCH] staging: bcm: multiple checkpatch fixes for InterfaceIdleMode.c Karthik Nayak
2014-09-30 18:52 ` Mark Einon
2014-10-08 22:40 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).