* [PATCH] drivers: staging: wlan-ng: fix sparse warnings
@ 2014-10-04 2:24 Cheng-wei Lee
2014-10-08 22:57 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: Cheng-wei Lee @ 2014-10-04 2:24 UTC (permalink / raw)
To: Greg Kroah-Hartman, johannes.berg, josh, sarah.a.sharp,
himangi774, teobaluta, linville, gamerh2o
Cc: devel, linux-kernel
This patch fix the sparse warnings in wlan-ng/cfg80211.c
The following functions were only used in this file, so done by
declaring them into static.
drivers/staging/wlan-ng/cfg80211.c:710:6: warning: symbol
'prism2_connect_result' was not declared. Should it be static?
drivers/staging/wlan-ng/cfg80211.c:719:6: warning: symbol
'prism2_disconnected' was not declared. Should it be static?
drivers/staging/wlan-ng/cfg80211.c:725:6: warning: symbol
'prism2_roamed' was not declared. Should it be static?
Signed-off-by: Quentin Lee <lee.rhapsody@gmail.com>
---
drivers/staging/wlan-ng/cfg80211.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
index 723319e..9e65429 100644
--- a/drivers/staging/wlan-ng/cfg80211.c
+++ b/drivers/staging/wlan-ng/cfg80211.c
@@ -707,7 +707,7 @@ exit:
/* Interface callback functions, passing data back up to the cfg80211 layer */
-void prism2_connect_result(wlandevice_t *wlandev, u8 failed)
+static void prism2_connect_result(wlandevice_t *wlandev, u8 failed)
{
u16 status = failed ?
WLAN_STATUS_UNSPECIFIED_FAILURE : WLAN_STATUS_SUCCESS;
@@ -716,13 +716,13 @@ void prism2_connect_result(wlandevice_t *wlandev, u8 failed)
NULL, 0, NULL, 0, status, GFP_KERNEL);
}
-void prism2_disconnected(wlandevice_t *wlandev)
+static void prism2_disconnected(wlandevice_t *wlandev)
{
cfg80211_disconnected(wlandev->netdev, 0, NULL,
0, GFP_KERNEL);
}
-void prism2_roamed(wlandevice_t *wlandev)
+static void prism2_roamed(wlandevice_t *wlandev)
{
cfg80211_roamed(wlandev->netdev, NULL, wlandev->bssid,
NULL, 0, NULL, 0, GFP_KERNEL);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers: staging: wlan-ng: fix sparse warnings
2014-10-04 2:24 [PATCH] drivers: staging: wlan-ng: fix sparse warnings Cheng-wei Lee
@ 2014-10-08 22:57 ` Greg Kroah-Hartman
0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2014-10-08 22:57 UTC (permalink / raw)
To: Cheng-wei Lee
Cc: johannes.berg, josh, sarah.a.sharp, himangi774, teobaluta,
linville, gamerh2o, devel, linux-kernel
On Sat, Oct 04, 2014 at 10:24:28AM +0800, Cheng-wei Lee wrote:
> This patch fix the sparse warnings in wlan-ng/cfg80211.c
> The following functions were only used in this file, so done by
> declaring them into static.
>
> drivers/staging/wlan-ng/cfg80211.c:710:6: warning: symbol
> 'prism2_connect_result' was not declared. Should it be static?
> drivers/staging/wlan-ng/cfg80211.c:719:6: warning: symbol
> 'prism2_disconnected' was not declared. Should it be static?
> drivers/staging/wlan-ng/cfg80211.c:725:6: warning: symbol
> 'prism2_roamed' was not declared. Should it be static?
>
> Signed-off-by: Quentin Lee <lee.rhapsody@gmail.com>
> ---
> drivers/staging/wlan-ng/cfg80211.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
This patch doesn't apply to my staging-testing branch of staging.git,
can you refresh it and resend please?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers: staging: wlan-ng: fix sparse warnings
2014-09-26 10:48 Cheng-Wei Lee
@ 2014-09-26 11:02 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2014-09-26 11:02 UTC (permalink / raw)
To: Cheng-Wei Lee
Cc: Greg Kroah-Hartman, johannes.berg, josh, sarah.a.sharp,
himangi774, teobaluta, linville, gamerh2o, devel, linux-kernel
Patch is corrupt. Read the first paragraph of
Documentation/email-clients.txt
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drivers: staging: wlan-ng: fix sparse warnings
@ 2014-09-26 10:48 Cheng-Wei Lee
2014-09-26 11:02 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Cheng-Wei Lee @ 2014-09-26 10:48 UTC (permalink / raw)
To: Greg Kroah-Hartman, johannes.berg, josh, sarah.a.sharp,
himangi774, teobaluta, linville, gamerh2o
Cc: devel, linux-kernel
This patch fix the sparse warnings in wlan-ng/cfg80211.c
The following functions were only used in this file, so done by
declaring them into static.
drivers/staging/wlan-ng/cfg80211.c:710:6: warning: symbol
'prism2_connect_result' was not declared. Should it be static?
drivers/staging/wlan-ng/cfg80211.c:719:6: warning: symbol
'prism2_disconnected' was not declared. Should it be static?
drivers/staging/wlan-ng/cfg80211.c:725:6: warning: symbol
'prism2_roamed' was not declared. Should it be static?
Signed-off-by: Quentin Lee <lee.rhapsody@gmail.com>
---
drivers/staging/wlan-ng/cfg80211.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/cfg80211.c
b/drivers/staging/wlan-ng/cfg80211.c
index 723319e..9e65429 100644
--- a/drivers/staging/wlan-ng/cfg80211.c
+++ b/drivers/staging/wlan-ng/cfg80211.c
@@ -707,7 +707,7 @@ exit:
/* Interface callback functions, passing data back up to the cfg80211 layer */
-void prism2_connect_result(wlandevice_t *wlandev, u8 failed)
+static void prism2_connect_result(wlandevice_t *wlandev, u8 failed)
{
u16 status = failed ?
WLAN_STATUS_UNSPECIFIED_FAILURE : WLAN_STATUS_SUCCESS;
@@ -716,13 +716,13 @@ void prism2_connect_result(wlandevice_t
*wlandev, u8 failed)
NULL, 0, NULL, 0, status, GFP_KERNEL);
}
-void prism2_disconnected(wlandevice_t *wlandev)
+static void prism2_disconnected(wlandevice_t *wlandev)
{
cfg80211_disconnected(wlandev->netdev, 0, NULL,
0, GFP_KERNEL);
}
-void prism2_roamed(wlandevice_t *wlandev)
+static void prism2_roamed(wlandevice_t *wlandev)
{
cfg80211_roamed(wlandev->netdev, NULL, wlandev->bssid,
NULL, 0, NULL, 0, GFP_KERNEL);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-08 22:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-04 2:24 [PATCH] drivers: staging: wlan-ng: fix sparse warnings Cheng-wei Lee
2014-10-08 22:57 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2014-09-26 10:48 Cheng-Wei Lee
2014-09-26 11:02 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).