From: Frans Klaver <frans.klaver@xsens.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Sebastian Reichel <sre@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] power: reset: add LTC2952 poweroff support
Date: Thu, 9 Oct 2014 10:37:31 +0200 [thread overview]
Message-ID: <20141009083731.GB3588@ci00147.xsens-tech.local> (raw)
In-Reply-To: <20141007081544.GA25568@ci00147.xsens-tech.local>
On Tue, Oct 07, 2014 at 10:15:44AM +0200, Frans Klaver wrote:
> On Mon, Oct 06, 2014 at 02:32:10PM -0700, Guenter Roeck wrote:
> > On Mon, Oct 06, 2014 at 10:40:35AM +0200, Frans Klaver wrote:
> > > +static struct platform_driver ltc2952_poweroff_driver = {
> > > + .probe = ltc2952_poweroff_probe,
> > > + .remove = ltc2952_poweroff_remove,
> > > + .driver = {
> > > + .name = "ltc2952-poweroff",
> > > + .owner = THIS_MODULE,
> > > + .of_match_table = of_ltc2952_poweroff_match,
> > > + },
> > > + .suspend = ltc2952_poweroff_suspend,
> > > + .resume = ltc2952_poweroff_resume,
> >
> > I think you are supposed to put the suspend and resume calls into the driver
> > structure. The platform code names the callbacks here 'legacy'.
>
> I'll check that out.
They are supposed to go into a pm_ops structure, which is pointed at in
driver's pm pointer. I'll drop them in any case. It would lead to a
bunch of boiler plate for nothing.
Frans
next prev parent reply other threads:[~2014-10-09 8:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 8:40 [PATCH v3 0/2] Add support for ltc2952 poweroff Frans Klaver
2014-10-06 8:40 ` [PATCH v3 1/2] power: reset: add LTC2952 poweroff support Frans Klaver
2014-10-06 21:32 ` Guenter Roeck
2014-10-07 8:15 ` Frans Klaver
2014-10-07 13:16 ` Guenter Roeck
2014-10-07 13:34 ` Frans Klaver
2014-10-09 8:37 ` Frans Klaver [this message]
2014-10-06 8:40 ` [PATCH v3 2/2] power: reset: document " Frans Klaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141009083731.GB3588@ci00147.xsens-tech.local \
--to=frans.klaver@xsens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).