From: Guenter Roeck <linux@roeck-us.net>
To: Frans Klaver <frans.klaver@xsens.com>
Cc: Sebastian Reichel <sre@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] power: reset: add LTC2952 poweroff support
Date: Tue, 07 Oct 2014 06:16:19 -0700 [thread overview]
Message-ID: <5433E7A3.4080707@roeck-us.net> (raw)
In-Reply-To: <20141007081544.GA25568@ci00147.xsens-tech.local>
On 10/07/2014 01:15 AM, Frans Klaver wrote:
> On Mon, Oct 06, 2014 at 02:32:10PM -0700, Guenter Roeck wrote:
>> Any reason for not using devm_gpiod_get() for those functions ?
>
> René said in the first review round:
>
>>>> devm_* functions do not seem to common to me and are sparsely
>>>> documented, therefore I preferred the regular functions. This
>>>> error jump should go to err_io and the clean-up loop must check
>>>> if the gpio entry is actually filled in
>
> I now unrolled these loops, and quite frankly I'm not that sure devm_*
> functions are actually that sparsely used. The way to get around that is
> to use them more. I'll see about using those instead, maybe add some
> documentation as well.
>
"git grep devm_| wc" on 3.17 returns 7344.
If that is not enough, nothing ever will.
Guenter
next prev parent reply other threads:[~2014-10-07 13:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 8:40 [PATCH v3 0/2] Add support for ltc2952 poweroff Frans Klaver
2014-10-06 8:40 ` [PATCH v3 1/2] power: reset: add LTC2952 poweroff support Frans Klaver
2014-10-06 21:32 ` Guenter Roeck
2014-10-07 8:15 ` Frans Klaver
2014-10-07 13:16 ` Guenter Roeck [this message]
2014-10-07 13:34 ` Frans Klaver
2014-10-09 8:37 ` Frans Klaver
2014-10-06 8:40 ` [PATCH v3 2/2] power: reset: document " Frans Klaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5433E7A3.4080707@roeck-us.net \
--to=linux@roeck-us.net \
--cc=frans.klaver@xsens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).