From: Felipe Balbi <balbi@ti.com>
To: David Cohen <david.a.cohen@linux.intel.com>
Cc: <linus.walleij@linaro.org>, <linux-gpio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <balbi@ti.com>,
<stable@vger.kernel.org>,
Mathias Nyman <mathias.nyman@linux.intel.com>
Subject: Re: [PATCH v2] pinctrl: baytrail: show output gpio state correctly on Intel Baytrail
Date: Tue, 14 Oct 2014 13:19:01 -0500 [thread overview]
Message-ID: <20141014181901.GD18747@saruman> (raw)
In-Reply-To: <1413309277-32485-1-git-send-email-david.a.cohen@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1293 bytes --]
On Tue, Oct 14, 2014 at 10:54:37AM -0700, David Cohen wrote:
> Even if a gpio pin is set to output, we still need to set INPUT_EN
> functionality (by clearing INPUT_EN bit) to be able to read the pin's
> level.
>
> E.g. without this change, we'll always read low level state from sysfs.
>
> Cc: <stable@vger.kernel.org> # v3.14+
> Cc: Mathias Nyman <mathias.nyman@linux.intel.com>
> Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
Reviewed-by: Felipe Balbi <balbi@ti.com>
> ---
>
> v1 to v2: improved patch's body description as requested by Felipe Balbi
> ---
>
> drivers/pinctrl/pinctrl-baytrail.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-baytrail.c b/drivers/pinctrl/pinctrl-baytrail.c
> index e12e5b07f6d7..c23d8ded936d 100644
> --- a/drivers/pinctrl/pinctrl-baytrail.c
> +++ b/drivers/pinctrl/pinctrl-baytrail.c
> @@ -318,7 +318,7 @@ static int byt_gpio_direction_output(struct gpio_chip *chip,
> "Potential Error: Setting GPIO with direct_irq_en to output");
>
> reg_val = readl(reg) | BYT_DIR_MASK;
> - reg_val &= ~BYT_OUTPUT_EN;
> + reg_val &= ~(BYT_OUTPUT_EN | BYT_INPUT_EN);
>
> if (value)
> writel(reg_val | BYT_LEVEL, reg);
> --
> 2.1.0
>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-10-14 18:19 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 16:55 [PATCH] pinctrl: baytrail: show output gpio state correctly on Intel Baytrail David Cohen
2014-10-13 18:23 ` David Cohen
2014-10-13 19:14 ` Felipe Balbi
2014-10-13 19:24 ` David Cohen
2014-10-13 19:26 ` Felipe Balbi
2014-10-13 19:36 ` Felipe Balbi
2014-10-13 20:19 ` David Cohen
2014-10-28 10:15 ` Linus Walleij
2014-10-28 14:42 ` Felipe Balbi
2014-10-31 8:12 ` Linus Walleij
2014-10-31 13:20 ` Felipe Balbi
2014-10-31 16:23 ` David Cohen
2014-10-31 18:45 ` David Cohen
2014-11-03 9:24 ` Mika Westerberg
2014-11-03 15:00 ` Felipe Balbi
2014-11-03 15:27 ` Mika Westerberg
2014-11-03 15:35 ` Felipe Balbi
2014-11-03 15:42 ` Mika Westerberg
2014-11-03 15:50 ` Felipe Balbi
2014-11-03 18:42 ` Mika Westerberg
2014-11-03 20:40 ` Felipe Balbi
2014-11-04 7:51 ` Mika Westerberg
2014-11-04 14:44 ` Felipe Balbi
2014-11-03 22:19 ` David Cohen
2014-11-04 7:59 ` Mika Westerberg
2014-11-04 18:05 ` David Cohen
2014-11-04 18:57 ` Mika Westerberg
2014-11-04 19:11 ` David Cohen
2014-11-04 19:34 ` Mika Westerberg
2014-11-04 21:51 ` David Cohen
2014-11-05 8:40 ` Mika Westerberg
2014-11-14 9:40 ` Linus Walleij
2014-11-14 9:39 ` Linus Walleij
2014-11-14 9:53 ` Mika Westerberg
2014-11-14 23:19 ` Rafael J. Wysocki
2014-11-14 9:30 ` Linus Walleij
2014-11-03 15:33 ` Linus Walleij
2014-10-13 20:16 ` David Cohen
2014-10-14 17:54 ` [PATCH v2] " David Cohen
2014-10-14 18:19 ` Felipe Balbi [this message]
2014-10-28 10:17 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141014181901.GD18747@saruman \
--to=balbi@ti.com \
--cc=david.a.cohen@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).