Re: [PATCH] pinctrl: baytrail: show output gpio state correctly on Intel Baytrail

From: Felipe Balbi <balbi@ti.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Felipe Balbi <balbi@ti.com>,
	David Cohen <david.a.cohen@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	stable <stable@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: baytrail: show output gpio state correctly on Intel Baytrail
Date: Tue, 28 Oct 2014 09:42:49 -0500	[thread overview]
Message-ID: <20141028144249.GD8123@saruman> (raw)
In-Reply-To: <CACRpkdYDiFvwsPwqACXS2bZU9peUyJEn-fpzVqZKYXseuEFGGA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1166 bytes --]

On Tue, Oct 28, 2014 at 11:15:20AM +0100, Linus Walleij wrote:
> On Mon, Oct 13, 2014 at 9:36 PM, Felipe Balbi <balbi@ti.com> wrote:
> > On Mon, Oct 13, 2014 at 02:26:32PM -0500, Felipe Balbi wrote:
> 
> > I also noticed that this is missing:
> >
> > diff --git a/drivers/pinctrl/pinctrl-baytrail.c b/drivers/pinctrl/pinctrl-baytrail.c
> > index e12e5b0..7db5ab9 100644
> > --- a/drivers/pinctrl/pinctrl-baytrail.c
> > +++ b/drivers/pinctrl/pinctrl-baytrail.c
> > @@ -614,3 +614,9 @@ static int __init byt_gpio_init(void)
> >  }
> >
> >  subsys_initcall(byt_gpio_init);
> > +
> > +static void __exit byt_gpio_exit(void)
> > +{
> > +       platform_driver_unregister(&byt_gpio_driver);
> > +}
> > +module_exit(byt_gpio_exit);
> 
> But the Baytrail driver is not a loadable module, it is bool:
> 
> config PINCTRL_BAYTRAIL
>         bool "Intel Baytrail GPIO pin control"
>         depends on GPIOLIB && ACPI && X86
> 
> (...)
> 
> So I guess it won't need handling for removal, as it can only
> be compiled-in.

you can still unbind it through sysfs, right ? The thing also already
provides a ->remove() method anyway.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]