linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@redhat.com>
To: mroos@linux.ee
Cc: iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org,
	cl@linux.com, penberg@kernel.org, rientjes@google.com,
	akpm@linux-foundation.org, linux-mm@kvack.org,
	sparclinux@vger.kernel.org
Subject: Re: unaligned accesses in SLAB etc.
Date: Thu, 16 Oct 2014 16:20:01 -0400 (EDT)	[thread overview]
Message-ID: <20141016.162001.599580415052560455.davem@redhat.com> (raw)
In-Reply-To: <alpine.LRH.2.11.1410162313440.19924@adalberg.ut.ee>

From: Meelis Roos <mroos@linux.ee>
Date: Thu, 16 Oct 2014 23:16:44 +0300 (EEST)

>> > scripts/Makefile.build:352: recipe for target 'sound/modules.order' failed
>> > make[1]: *** [sound/modules.order] Bus error
>> > make[1]: *** Deleting file 'sound/modules.order'
>> > Makefile:929: recipe for target 'sound' failed
>> 
>> I just reproduced this on my Sun Blade 2500, so it can trigger on UltraSPARC-IIIi
>> systems too.
> 
> My bisection led to the folloowing commit but it seems irrelevant (I 
> have no sun4v on these machines):
> 
> 4ccb9272892c33ef1c19a783cfa87103b30c2784 is the first bad commit
> commit 4ccb9272892c33ef1c19a783cfa87103b30c2784
> Author: bob picco <bpicco@meloft.net>
> Date:   Tue Sep 16 09:26:47 2014 -0400
> 
>     sparc64: sun4v TLB error power off events
> 
> 
> However, the following chunk sound slightly suspicious:
> 
> +       if (fault_code & FAULT_CODE_BAD_RA)
> +               goto do_sigbus;
> +
> 
> because SIGNUS is what I got. For some machines, it killed chekroot 
> during startup, for some shells under some circumstances, for some sshd.

Good catch!

So I'm going to audit all the code paths to make sure we don't put garbage
into the fault_code value.

  reply	other threads:[~2014-10-16 20:20 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-12  2:15 unaligned accesses in SLAB etc David Miller
2014-10-12 17:20 ` David Miller
2014-10-13 20:22   ` mroos
2014-10-13 23:52     ` Joonsoo Kim
2014-10-14  0:04       ` David Miller
2014-10-14  0:14         ` Joonsoo Kim
2014-10-14 21:19         ` mroos
2014-10-14 21:32           ` David Miller
2014-10-15  8:04             ` Meelis Roos
2014-10-15 18:36               ` David Miller
2014-10-15 20:11                 ` Meelis Roos
2014-10-16  3:11                   ` David Miller
2014-10-16  7:22                     ` Meelis Roos
2014-10-16 20:11                       ` Meelis Roos
2014-10-16 20:18                         ` David Miller
2014-10-16 21:38                     ` Meelis Roos
2014-10-19  4:32                       ` David Miller
2014-10-19  7:07                         ` Meelis Roos
2014-10-20 18:57                           ` David Miller
2014-10-22 20:39                             ` David Miller
2014-10-22 23:22                               ` Meelis Roos
2014-10-23 17:02                                 ` David Miller
2014-10-23 21:22                                   ` David Miller
2014-10-24  4:54                                     ` Sam Ravnborg
2014-10-24 16:53                                       ` David Miller
2014-10-24  7:49                                     ` Meelis Roos
2014-10-24 16:45                                       ` David Miller
2014-10-16  7:02             ` Meelis Roos
2014-10-16 20:07               ` David Miller
2014-10-16 20:16                 ` Meelis Roos
2014-10-16 20:20                   ` David Miller [this message]
2014-10-16 20:50                     ` David Miller
2014-10-17 11:12                       ` Meelis Roos
2014-10-18 17:59                         ` David Miller
2014-10-18 18:23                           ` David Miller
2014-10-19 12:31                             ` Meelis Roos
2014-10-19 17:12                               ` Meelis Roos
2014-10-19 17:18                                 ` David Miller
2014-10-19 15:32                             ` Sam Ravnborg
2014-10-19 17:27                               ` David Miller
2014-10-19 19:55                                 ` Sam Ravnborg
2014-10-16 20:20                 ` Meelis Roos
2014-10-16 20:40                   ` Meelis Roos
2014-10-12 17:22 ` Joonsoo Kim
2014-10-12 17:30   ` David Miller
2014-10-12 17:43     ` Joonsoo Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141016.162001.599580415052560455.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mroos@linux.ee \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).