linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] spi/rockchip: spi controller must be disabled in tx callback too
@ 2014-10-17  1:44 Addy Ke
  2014-10-17 12:29 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Addy Ke @ 2014-10-17  1:44 UTC (permalink / raw)
  To: broonie, heiko, dianders, grant.likely, robh+dt, amstan, sonnyrao
  Cc: linux-kernel, linux-spi, linux-arm-kernel, linux-rockchip,
	devicetree, olof, hj, kever.yang, xjq, huangtao, zyw, yzq,
	zhenfu.fang, cf, zhangqing, hl, wei.luo, Addy Ke

Signed-off-by: Addy Ke <addy.ke@rock-chips.com>
---
 drivers/spi/spi-rockchip.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
index 153269b..87bc16f 100644
--- a/drivers/spi/spi-rockchip.c
+++ b/drivers/spi/spi-rockchip.c
@@ -418,8 +418,10 @@ static void rockchip_spi_dma_txcb(void *data)
 	spin_lock_irqsave(&rs->lock, flags);
 
 	rs->state &= ~TXBUSY;
-	if (!(rs->state & RXBUSY))
+	if (!(rs->state & RXBUSY)) {
+		spi_enable_chip(rs, 0);
 		spi_finalize_current_transfer(rs->master);
+	}
 
 	spin_unlock_irqrestore(&rs->lock, flags);
 }
-- 
1.8.3.2



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] spi/rockchip: spi controller must be disabled in tx callback too
  2014-10-17  1:44 [PATCH] spi/rockchip: spi controller must be disabled in tx callback too Addy Ke
@ 2014-10-17 12:29 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-10-17 12:29 UTC (permalink / raw)
  To: Addy Ke
  Cc: heiko, dianders, grant.likely, robh+dt, amstan, sonnyrao,
	linux-kernel, linux-spi, linux-arm-kernel, linux-rockchip,
	devicetree, olof, hj, kever.yang, xjq, huangtao, zyw, yzq,
	zhenfu.fang, cf, zhangqing, hl, wei.luo

[-- Attachment #1: Type: text/plain, Size: 125 bytes --]

On Fri, Oct 17, 2014 at 09:44:13AM +0800, Addy Ke wrote:
> Signed-off-by: Addy Ke <addy.ke@rock-chips.com>

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-10-17 12:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-17  1:44 [PATCH] spi/rockchip: spi controller must be disabled in tx callback too Addy Ke
2014-10-17 12:29 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).