linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* USB Ethernet gadget on Nokia n900
@ 2014-10-19  9:01 Pavel Machek
  2014-10-19 10:07 ` Pavel Machek
  0 siblings, 1 reply; 43+ messages in thread
From: Pavel Machek @ 2014-10-19  9:01 UTC (permalink / raw)
  To: pali.rohar, sre, sre, kernel list, balbi, linux-arm-kernel

Hi!

>From 3.6 to 3.10, USB networking works on Nokia N900. With 3.11, it
fails with messages on the host. I also tried to get it to work on
3.14 and 3.17, with no luck.

Any ideas? Does it work for you? Any config options to watch for?

Best regards,
									Pavel 

Oct 19 10:10:52 amd kernel: [71388.656037] usb 4-1: new high-speed USB
device number 98 using ehci-pci
Oct 19 10:10:52 amd kernel: [71388.789842] usb 4-1: New USB device
found, idVendor=0525, idProduct=a4a2
Oct 19 10:10:52 amd kernel: [71388.789847] usb 4-1: New USB device
strings: Mfr=1, Product=2, SerialNumber=0
Oct 19 10:10:52 amd kernel: [71388.789851] usb 4-1: Product:
RNDIS/Ethernet Gadget
Oct 19 10:10:52 amd kernel: [71388.789854] usb 4-1: Manufacturer:
Linux 3.11.0-00115-g1b8e8c5-dirty with musb-hdrc
Oct 19 10:11:02 amd kernel: [71398.788300] cdc_subset: probe of
4-1:1.0 failed with error -22
Oct 19 10:11:05 amd systemd-udevd[167]: Network interface NamePolicy=
disabled on kernel commandline, ignoring.
Oct 19 10:11:07 amd kernel: [71403.788240] cdc_ether: probe of 4-1:1.0
failed with error -110
Oct 19 10:11:10 amd systemd-udevd[167]: Network interface NamePolicy=
disabled on kernel commandline, ignoring.
Oct 19 10:11:12 amd kernel: [71408.788237] cdc_subset: probe of
4-1:1.1 failed with error -110


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-19  9:01 USB Ethernet gadget on Nokia n900 Pavel Machek
@ 2014-10-19 10:07 ` Pavel Machek
  2014-10-19 14:58   ` Pali Rohár
  2014-10-19 15:24   ` Felipe Balbi
  0 siblings, 2 replies; 43+ messages in thread
From: Pavel Machek @ 2014-10-19 10:07 UTC (permalink / raw)
  To: pali.rohar, sre, sre, kernel list, balbi, linux-arm-kernel; +Cc: linux-omap

On Sun 2014-10-19 11:01:07, Pavel Machek wrote:
> Hi!
> 
> From 3.6 to 3.10, USB networking works on Nokia N900. With 3.11, it
> fails with messages on the host. I also tried to get it to work on
> 3.14 and 3.17, with no luck.
> 
> Any ideas? Does it work for you? Any config options to watch for?

With 3.17, I get

omap_musb_mailbox: musb core is not yet ready

message. It looks related...?

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-19 10:07 ` Pavel Machek
@ 2014-10-19 14:58   ` Pali Rohár
  2014-10-19 20:50     ` Pavel Machek
  2014-10-19 15:24   ` Felipe Balbi
  1 sibling, 1 reply; 43+ messages in thread
From: Pali Rohár @ 2014-10-19 14:58 UTC (permalink / raw)
  To: Pavel Machek; +Cc: sre, sre, kernel list, balbi, linux-arm-kernel, linux-omap

[-- Attachment #1: Type: Text/Plain, Size: 696 bytes --]

On Sunday 19 October 2014 12:07:39 Pavel Machek wrote:
> On Sun 2014-10-19 11:01:07, Pavel Machek wrote:
> > Hi!
> > 
> > From 3.6 to 3.10, USB networking works on Nokia N900. With
> > 3.11, it fails with messages on the host. I also tried to
> > get it to work on 3.14 and 3.17, with no luck.
> > 
> > Any ideas? Does it work for you? Any config options to watch
> > for?
> 
> With 3.17, I get
> 
> omap_musb_mailbox: musb core is not yet ready
> 
> message. It looks related...?

Can you try tree https://gitorious.org/linux-n900/linux-n900/ ?

I think with rx51_defconfig from above tree it worked fine for 
3.10 - 3.13 versions.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-19 10:07 ` Pavel Machek
  2014-10-19 14:58   ` Pali Rohár
@ 2014-10-19 15:24   ` Felipe Balbi
  2014-10-19 19:19     ` Pavel Machek
  1 sibling, 1 reply; 43+ messages in thread
From: Felipe Balbi @ 2014-10-19 15:24 UTC (permalink / raw)
  To: Pavel Machek
  Cc: pali.rohar, sre, sre, kernel list, balbi, linux-arm-kernel,
	linux-omap, Aaro Koskinen

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

Hi,

On Sun, Oct 19, 2014 at 12:07:39PM +0200, Pavel Machek wrote:
> On Sun 2014-10-19 11:01:07, Pavel Machek wrote:
> > Hi!
> > 
> > From 3.6 to 3.10, USB networking works on Nokia N900. With 3.11, it
> > fails with messages on the host. I also tried to get it to work on
> > 3.14 and 3.17, with no luck.
> > 
> > Any ideas? Does it work for you? Any config options to watch for?
> 
> With 3.17, I get
> 
> omap_musb_mailbox: musb core is not yet ready
> 
> message. It looks related...?

is musbmhdrc.ko loaded ? Do you have a gadget driver loaded ?

+ Aaro

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-19 15:24   ` Felipe Balbi
@ 2014-10-19 19:19     ` Pavel Machek
  2014-10-19 19:29       ` Pavel Machek
  2014-10-20 21:35       ` Aaro Koskinen
  0 siblings, 2 replies; 43+ messages in thread
From: Pavel Machek @ 2014-10-19 19:19 UTC (permalink / raw)
  To: Felipe Balbi
  Cc: pali.rohar, sre, sre, kernel list, linux-arm-kernel, linux-omap,
	Aaro Koskinen

[-- Attachment #1: Type: text/plain, Size: 1513 bytes --]

Hi!

On Sun 2014-10-19 10:24:14, Felipe Balbi wrote:
> Hi,
> On Sun, Oct 19, 2014 at 12:07:39PM +0200, Pavel Machek wrote:
> > On Sun 2014-10-19 11:01:07, Pavel Machek wrote:
> > > Hi!
> > > 
> > > From 3.6 to 3.10, USB networking works on Nokia N900. With 3.11, it
> > > fails with messages on the host. I also tried to get it to work on
> > > 3.14 and 3.17, with no luck.
> > > 
> > > Any ideas? Does it work for you? Any config options to watch for?
> > 
> > With 3.17, I get
> > 
> > omap_musb_mailbox: musb core is not yet ready
> > 
> > message. It looks related...?
> 
> is musbmhdrc.ko loaded ? Do you have a gadget driver loaded ?
> 
> + Aaro

I am trying to use nfsroot, so I can't use modules. I can't find
musbmhdrc.ko; did you mean drivers/usb/musb/musb_hdrc? Yes, that
should be build-in:

CONFIG_USB_MUSB_HDRC=y
CONFIG_USB_MUSB_GADGET=y
CONFIG_USB_MUSB_OMAP2PLUS=y
CONFIG_MUSB_PIO_ONLY=y

Gadget options are:

CONFIG_USB_ULPI=y
CONFIG_USB_GADGET=y
CONFIG_USB_GADGET_DEBUG=y
CONFIG_USB_GADGET_VERBOSE=y
CONFIG_USB_GADGET_DEBUG_FILES=y
CONFIG_USB_GADGET_DEBUG_FS=y
CONFIG_USB_GADGET_VBUS_DRAW=2
CONFIG_USB_GADGET_STORAGE_NUM_BUFFERS=2

CONFIG_USB_LIBCOMPOSITE=y
CONFIG_USB_U_ETHER=y
CONFIG_USB_F_ECM=y
CONFIG_USB_F_EEM=y
CONFIG_USB_F_SUBSET=y
CONFIG_USB_F_RNDIS=y

(I am attaching full config, in case I missed something important).

Best regards,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 23072 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-19 19:19     ` Pavel Machek
@ 2014-10-19 19:29       ` Pavel Machek
  2014-10-20 21:35       ` Aaro Koskinen
  1 sibling, 0 replies; 43+ messages in thread
From: Pavel Machek @ 2014-10-19 19:29 UTC (permalink / raw)
  To: Felipe Balbi
  Cc: pali.rohar, sre, sre, kernel list, linux-arm-kernel, linux-omap,
	Aaro Koskinen

On Sun 2014-10-19 21:19:37, Pavel Machek wrote:
> Hi!
> 
> On Sun 2014-10-19 10:24:14, Felipe Balbi wrote:
> > Hi,
> > On Sun, Oct 19, 2014 at 12:07:39PM +0200, Pavel Machek wrote:
> > > On Sun 2014-10-19 11:01:07, Pavel Machek wrote:
> > > > Hi!
> > > > 
> > > > From 3.6 to 3.10, USB networking works on Nokia N900. With 3.11, it
> > > > fails with messages on the host. I also tried to get it to work on
> > > > 3.14 and 3.17, with no luck.
> > > > 
> > > > Any ideas? Does it work for you? Any config options to watch for?
> > > 
> > > With 3.17, I get
> > > 
> > > omap_musb_mailbox: musb core is not yet ready

For the record, I can't see the message in this try. Either it is not
there, or it scrolled away (there's unfortunately no way to scroll
back).

								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-19 14:58   ` Pali Rohár
@ 2014-10-19 20:50     ` Pavel Machek
  2014-10-19 21:00       ` Pali Rohár
  0 siblings, 1 reply; 43+ messages in thread
From: Pavel Machek @ 2014-10-19 20:50 UTC (permalink / raw)
  To: Pali Rohár
  Cc: sre, sre, kernel list, balbi, linux-arm-kernel, linux-omap

On Sun 2014-10-19 16:58:45, Pali Rohár wrote:
> On Sunday 19 October 2014 12:07:39 Pavel Machek wrote:
> > On Sun 2014-10-19 11:01:07, Pavel Machek wrote:
> > > Hi!
> > > 
> > > From 3.6 to 3.10, USB networking works on Nokia N900. With
> > > 3.11, it fails with messages on the host. I also tried to
> > > get it to work on 3.14 and 3.17, with no luck.
> > > 
> > > Any ideas? Does it work for you? Any config options to watch
> > > for?
> > 
> > With 3.17, I get
> > 
> > omap_musb_mailbox: musb core is not yet ready
> > 
> > message. It looks related...?
> 
> Can you try tree https://gitorious.org/linux-n900/linux-n900/ ?
> 
> I think with rx51_defconfig from above tree it worked fine for 
> 3.10 - 3.13 versions.

>From your tree, I am trying 815039686baffff6432b45028dd405b1981a9112
(3.16 based). I attempted to make gadget drivers build-in and enabled
nfsroot. I could not detect nokia on USB after bootup.

Are you sure about defconfig? AFAICT defconfig will always be
unsuitable for nfsroot, as it will not contain nfs support built-in...

I am trying c089e5f8ba2d44afd2db2c2042d43ca70205c536 (3.13
based). Same result :-(.

Do you have any tree where usb gadget works for you?

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-19 20:50     ` Pavel Machek
@ 2014-10-19 21:00       ` Pali Rohár
  2014-10-19 22:30         ` Pavel Machek
  2014-10-20 13:08         ` Pavel Machek
  0 siblings, 2 replies; 43+ messages in thread
From: Pali Rohár @ 2014-10-19 21:00 UTC (permalink / raw)
  To: Pavel Machek; +Cc: sre, sre, kernel list, balbi, linux-arm-kernel, linux-omap

[-- Attachment #1: Type: Text/Plain, Size: 1798 bytes --]

On Sunday 19 October 2014 22:50:36 Pavel Machek wrote:
> On Sun 2014-10-19 16:58:45, Pali Rohár wrote:
> > On Sunday 19 October 2014 12:07:39 Pavel Machek wrote:
> > > On Sun 2014-10-19 11:01:07, Pavel Machek wrote:
> > > > Hi!
> > > > 
> > > > From 3.6 to 3.10, USB networking works on Nokia N900.
> > > > With 3.11, it fails with messages on the host. I also
> > > > tried to get it to work on 3.14 and 3.17, with no luck.
> > > > 
> > > > Any ideas? Does it work for you? Any config options to
> > > > watch for?
> > > 
> > > With 3.17, I get
> > > 
> > > omap_musb_mailbox: musb core is not yet ready
> > > 
> > > message. It looks related...?
> > 
> > Can you try tree
> > https://gitorious.org/linux-n900/linux-n900/ ?
> > 
> > I think with rx51_defconfig from above tree it worked fine
> > for 3.10 - 3.13 versions.
> 
> From your tree, I am trying
> 815039686baffff6432b45028dd405b1981a9112 (3.16 based). I
> attempted to make gadget drivers build-in and enabled
> nfsroot. I could not detect nokia on USB after bootup.
> 
> Are you sure about defconfig? AFAICT defconfig will always be
> unsuitable for nfsroot, as it will not contain nfs support
> built-in...
> 
> I am trying c089e5f8ba2d44afd2db2c2042d43ca70205c536 (3.13
> based). Same result :-(.
> 
> Do you have any tree where usb gadget works for you?
> 
> Thanks,
> 									Pavel

My N900 can boot kernel from v3.12-rc5-n900 branch compiled with 
arch/arm/configs/rx51_defconfig. Also it can boot full Maemo5 
system (with CSSU and some minor system changes) and usb network 
via g_nokia.ko gadget working fine...

So if it does not working for you then kernel usb subsystem could 
have problems with using gadgets directly from zimage.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-19 21:00       ` Pali Rohár
@ 2014-10-19 22:30         ` Pavel Machek
  2014-10-20 13:08         ` Pavel Machek
  1 sibling, 0 replies; 43+ messages in thread
From: Pavel Machek @ 2014-10-19 22:30 UTC (permalink / raw)
  To: Pali Rohár
  Cc: sre, sre, kernel list, balbi, linux-arm-kernel, linux-omap

Hi!

> > > > omap_musb_mailbox: musb core is not yet ready
> > > > 
> > > > message. It looks related...?
> > > 
> > > Can you try tree
> > > https://gitorious.org/linux-n900/linux-n900/ ?
> > > 
> > > I think with rx51_defconfig from above tree it worked fine
> > > for 3.10 - 3.13 versions.
> > 
> > From your tree, I am trying
> > 815039686baffff6432b45028dd405b1981a9112 (3.16 based). I
> > attempted to make gadget drivers build-in and enabled
> > nfsroot. I could not detect nokia on USB after bootup.
> > 
> > Are you sure about defconfig? AFAICT defconfig will always be
> > unsuitable for nfsroot, as it will not contain nfs support
> > built-in...
> > 
> > I am trying c089e5f8ba2d44afd2db2c2042d43ca70205c536 (3.13
> > based). Same result :-(.
> > 
> > Do you have any tree where usb gadget works for you?
> 
> My N900 can boot kernel from v3.12-rc5-n900 branch compiled with 
> arch/arm/configs/rx51_defconfig. Also it can boot full Maemo5 
> system (with CSSU and some minor system changes) and usb network 
> via g_nokia.ko gadget working fine...

Thanks for the info. Network seems to work on this one.

> So if it does not working for you then kernel usb subsystem could 
> have problems with using gadgets directly from zimage.

It seems to work with 3.12, but not with 3.13 (in similar config). If
you could test USB networking in 3.13, that would help...

Thanks,

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-19 21:00       ` Pali Rohár
  2014-10-19 22:30         ` Pavel Machek
@ 2014-10-20 13:08         ` Pavel Machek
  2014-10-20 16:45           ` Tony Lindgren
  1 sibling, 1 reply; 43+ messages in thread
From: Pavel Machek @ 2014-10-20 13:08 UTC (permalink / raw)
  To: Pali Rohár
  Cc: sre, sre, kernel list, balbi, linux-arm-kernel, linux-omap,
	kishon, s.nawrocki

Hi!

> My N900 can boot kernel from v3.12-rc5-n900 branch compiled with 
> arch/arm/configs/rx51_defconfig. Also it can boot full Maemo5 
> system (with CSSU and some minor system changes) and usb network 
> via g_nokia.ko gadget working fine...
> 
> So if it does not working for you then kernel usb subsystem could 
> have problems with using gadgets directly from zimage.

After some hand-bisecting and real-bisecting, I found two commits that
cause problems for 3.13: With these reverted, I get usb networking
back in 3.13 on nokia n900.

(Pali, if you revert these, you should get working usb networking in
your 3.13 branch, too.)

Any ideas?

								Pavel

commit 3e3101d57c50f9e4fa1da947e4bd0bc5cbab4141
Author: Kishon Vijay Abraham I <kishon@ti.com>
Date:   Fri Sep 27 11:53:30 2013 +0530

    usb: musb: omap2430: use the new generic PHY framework
    
    Use the generic PHY framework API to get the PHY. The
    usb_phy_set_resume
    and usb_phy_set_suspend is replaced with power_on and
    power_off to align with the new PHY framework.
    
    musb->xceiv can't be removed as of now because musb core uses
    xceiv.state and
    xceiv.otg. Once there is a separate state machine to handle otg,
    these can be
    moved out of xceiv and then we can start using the generic PHY
    framework.
    
    Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
    Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
    Acked-by: Felipe Balbi <balbi@ti.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

commit f1ddc24c9e33813f74b871d73e4d795dcdb95a3c
Author: Kishon Vijay Abraham I <kishon@ti.com>
Date:   Fri Sep 27 11:53:31 2013 +0530

    usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops
    
    Now that twl4030-usb is adapted to the new generic PHY framework,
    *set_suspend* and *phy_init* ops can be removed from twl4030-usb
    driver.
    
    Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
    Acked-by: Felipe Balbi <balbi@ti.com>
    Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>





-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-20 13:08         ` Pavel Machek
@ 2014-10-20 16:45           ` Tony Lindgren
  2014-10-20 22:03             ` Pavel Machek
  0 siblings, 1 reply; 43+ messages in thread
From: Tony Lindgren @ 2014-10-20 16:45 UTC (permalink / raw)
  To: Pavel Machek
  Cc: Pali Rohár, sre, sre, kernel list, balbi, linux-arm-kernel,
	linux-omap, kishon, s.nawrocki

* Pavel Machek <pavel@ucw.cz> [141020 06:10]:
> Hi!
> 
> > My N900 can boot kernel from v3.12-rc5-n900 branch compiled with 
> > arch/arm/configs/rx51_defconfig. Also it can boot full Maemo5 
> > system (with CSSU and some minor system changes) and usb network 
> > via g_nokia.ko gadget working fine...
> > 
> > So if it does not working for you then kernel usb subsystem could 
> > have problems with using gadgets directly from zimage.
> 
> After some hand-bisecting and real-bisecting, I found two commits that
> cause problems for 3.13: With these reverted, I get usb networking
> back in 3.13 on nokia n900.
> 
> (Pali, if you revert these, you should get working usb networking in
> your 3.13 branch, too.)
> 
> Any ideas?

Hmm maybe check if current stable kernels work for you without
reverting anything ? Few weeks ago I did the the following two fixes
with cc stable v3.13+:

96be39ab34b7 usb: phy: twl4030-usb: Fix regressions to runtime PM on omaps
85601b8d81e2 usb: phy: twl4030-usb: Fix lost interrupts after ID pin goes down

Regards,

Tony 

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-19 19:19     ` Pavel Machek
  2014-10-19 19:29       ` Pavel Machek
@ 2014-10-20 21:35       ` Aaro Koskinen
  2014-10-20 21:37         ` Aaro Koskinen
                           ` (2 more replies)
  1 sibling, 3 replies; 43+ messages in thread
From: Aaro Koskinen @ 2014-10-20 21:35 UTC (permalink / raw)
  To: Pavel Machek
  Cc: Felipe Balbi, pali.rohar, sre, sre, kernel list,
	linux-arm-kernel, linux-omap

Hi,

On Sun, Oct 19, 2014 at 09:19:37PM +0200, Pavel Machek wrote:
> I am trying to use nfsroot, so I can't use modules.

Why not?

> (I am attaching full config, in case I missed something important).

I'm using the below config with 3.17 and g_ether works OK.

(My initramfs modprobes g_ether, runs busybox ifconfig for usb0
and launches sshd.)

A.

---

CONFIG_LOCALVERSION="-omap3"
CONFIG_KERNEL_LZMA=y
CONFIG_SYSVIPC=y
# CONFIG_CROSS_MEMORY_ATTACH is not set
CONFIG_NO_HZ=y
CONFIG_HIGH_RES_TIMERS=y
CONFIG_BSD_PROCESS_ACCT=y
CONFIG_IKCONFIG=y
CONFIG_IKCONFIG_PROC=y
CONFIG_LOG_BUF_SHIFT=20
CONFIG_BLK_DEV_INITRD=y
# CONFIG_RD_GZIP is not set
CONFIG_EXPERT=y
CONFIG_KALLSYMS_ALL=y
CONFIG_PROFILING=y
CONFIG_OPROFILE=m
CONFIG_MODULES=y
CONFIG_MODULE_FORCE_LOAD=y
CONFIG_MODULE_UNLOAD=y
CONFIG_MODULE_FORCE_UNLOAD=y
# CONFIG_BLK_DEV_BSG is not set
CONFIG_PARTITION_ADVANCED=y
# CONFIG_EFI_PARTITION is not set
# CONFIG_IOSCHED_DEADLINE is not set
CONFIG_OMAP_RESET_CLOCKS=y
CONFIG_OMAP_MUX_DEBUG=y
CONFIG_ARCH_OMAP3=y
# CONFIG_SOC_TI81XX is not set
# CONFIG_MACH_OMAP3_BEAGLE is not set
# CONFIG_MACH_DEVKIT8000 is not set
# CONFIG_MACH_OMAP_LDP is not set
# CONFIG_MACH_OMAP3530_LV_SOM is not set
# CONFIG_MACH_OMAP3_TORPEDO is not set
# CONFIG_MACH_OVERO is not set
# CONFIG_MACH_OMAP3517EVM is not set
# CONFIG_MACH_OMAP3_PANDORA is not set
# CONFIG_MACH_TOUCHBOOK is not set
# CONFIG_MACH_OMAP_3430SDP is not set
# CONFIG_MACH_NOKIA_RX51 is not set
# CONFIG_MACH_CM_T35 is not set
# CONFIG_MACH_CM_T3517 is not set
# CONFIG_MACH_SBC3530 is not set
CONFIG_ARM_THUMBEE=y
CONFIG_PREEMPT=y
# CONFIG_ATAGS is not set
CONFIG_ZBOOT_ROM_TEXT=0x0
CONFIG_ZBOOT_ROM_BSS=0x0
CONFIG_ARM_APPENDED_DTB=y
CONFIG_CMDLINE="console=ttyO2,115200 console=tty"
CONFIG_KEXEC=y
CONFIG_BINFMT_MISC=y
CONFIG_PM_DEBUG=y
CONFIG_NET=y
CONFIG_PACKET=y
CONFIG_INET=y
# CONFIG_INET_XFRM_MODE_TRANSPORT is not set
# CONFIG_INET_XFRM_MODE_TUNNEL is not set
# CONFIG_INET_XFRM_MODE_BEET is not set
# CONFIG_INET_LRO is not set
# CONFIG_INET_DIAG is not set
# CONFIG_IPV6 is not set
# CONFIG_WIRELESS is not set
CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
CONFIG_DEVTMPFS=y
CONFIG_MTD=y
CONFIG_MTD_BLOCK=y
CONFIG_MTD_OOPS=y
CONFIG_MTD_CFI=y
CONFIG_MTD_CFI_INTELEXT=y
CONFIG_MTD_NAND=y
CONFIG_MTD_NAND_OMAP2=y
CONFIG_MTD_ONENAND=y
CONFIG_MTD_ONENAND_VERIFY_WRITE=y
CONFIG_MTD_ONENAND_OMAP2=y
CONFIG_MTD_UBI=y
# CONFIG_BLK_DEV is not set
CONFIG_EEPROM_93CX6=y
CONFIG_SENSORS_LIS3_I2C=m
CONFIG_SCSI=y
CONFIG_BLK_DEV_SD=y
CONFIG_SCSI_SCAN_ASYNC=y
CONFIG_INPUT_POLLDEV=y
CONFIG_INPUT_JOYDEV=y
CONFIG_INPUT_EVDEV=y
CONFIG_KEYBOARD_GPIO=y
CONFIG_KEYBOARD_TWL4030=y
CONFIG_INPUT_TOUCHSCREEN=y
CONFIG_TOUCHSCREEN_ADS7846=y
CONFIG_TOUCHSCREEN_TSC2005=y
CONFIG_INPUT_MISC=y
CONFIG_INPUT_TWL4030_PWRBUTTON=y
CONFIG_INPUT_UINPUT=y
# CONFIG_LEGACY_PTYS is not set
CONFIG_SERIAL_OMAP=y
CONFIG_SERIAL_OMAP_CONSOLE=y
CONFIG_HW_RANDOM=y
CONFIG_I2C_CHARDEV=y
CONFIG_SPI=y
CONFIG_SPI_OMAP24XX=y
CONFIG_PINCTRL_SINGLE=y
CONFIG_DEBUG_GPIO=y
CONFIG_GPIO_SYSFS=y
CONFIG_GPIO_TWL4030=y
CONFIG_POWER_SUPPLY=y
CONFIG_WATCHDOG=y
CONFIG_OMAP_WATCHDOG=y
CONFIG_TWL4030_WATCHDOG=y
CONFIG_REGULATOR_FIXED_VOLTAGE=y
CONFIG_REGULATOR_TPS65023=y
CONFIG_REGULATOR_TPS6507X=y
CONFIG_REGULATOR_TWL4030=y
CONFIG_FB=y
CONFIG_FIRMWARE_EDID=y
CONFIG_FB_MODE_HELPERS=y
CONFIG_FB_TILEBLITTING=y
CONFIG_OMAP2_DSS=y
# CONFIG_OMAP2_DSS_DPI is not set
CONFIG_OMAP2_DSS_SDI=y
CONFIG_FB_OMAP2=y
# CONFIG_FB_OMAP2_DEBUG_SUPPORT is not set
CONFIG_DISPLAY_PANEL_SONY_ACX565AKM=y
CONFIG_BACKLIGHT_LCD_SUPPORT=y
CONFIG_LCD_CLASS_DEVICE=y
CONFIG_LCD_PLATFORM=y
CONFIG_BACKLIGHT_CLASS_DEVICE=y
CONFIG_FRAMEBUFFER_CONSOLE=y
CONFIG_FRAMEBUFFER_CONSOLE_ROTATION=y
CONFIG_LOGO=y
# CONFIG_LOGO_LINUX_VGA16 is not set
# CONFIG_LOGO_LINUX_CLUT224 is not set
CONFIG_USB=y
CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
CONFIG_USB_MUSB_HDRC=y
CONFIG_USB_MUSB_OMAP2PLUS=y
CONFIG_NOP_USB_XCEIV=y
CONFIG_USB_GADGET=y
CONFIG_USB_GADGET_DEBUG=y
CONFIG_USB_GADGET_DEBUG_FILES=y
CONFIG_USB_ETH=m
# CONFIG_USB_ETH_RNDIS is not set
CONFIG_MMC=y
CONFIG_SDIO_UART=y
CONFIG_MMC_OMAP_HS=y
CONFIG_RTC_CLASS=y
CONFIG_RTC_DRV_TWL4030=y
CONFIG_DMADEVICES=y
CONFIG_DMA_OMAP=y
CONFIG_TWL4030_USB=y
CONFIG_EXT4_FS=y
# CONFIG_FILE_LOCKING is not set
# CONFIG_DNOTIFY is not set
# CONFIG_INOTIFY_USER is not set
CONFIG_TMPFS=y
# CONFIG_MISC_FILESYSTEMS is not set
# CONFIG_NETWORK_FILESYSTEMS is not set
CONFIG_NLS_CODEPAGE_437=y
CONFIG_NLS_ISO8859_1=y
CONFIG_PRINTK_TIME=y
CONFIG_DEBUG_INFO=y
CONFIG_DEBUG_FS=y
CONFIG_MAGIC_SYSRQ=y
# CONFIG_SCHED_DEBUG is not set
# CONFIG_DEBUG_BUGVERBOSE is not set
# CONFIG_FTRACE is not set
# CONFIG_ARM_UNWIND is not set
CONFIG_DEBUG_LL=y
CONFIG_DEBUG_OMAP3UART3=y
CONFIG_EARLY_PRINTK=y
CONFIG_FONTS=y
CONFIG_FONT_8x8=y
CONFIG_FONT_8x16=y

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-20 21:35       ` Aaro Koskinen
@ 2014-10-20 21:37         ` Aaro Koskinen
  2014-10-20 22:42         ` Pavel Machek
  2014-10-26 11:08         ` Pavel Machek
  2 siblings, 0 replies; 43+ messages in thread
From: Aaro Koskinen @ 2014-10-20 21:37 UTC (permalink / raw)
  To: Pavel Machek
  Cc: Felipe Balbi, pali.rohar, sre, sre, kernel list,
	linux-arm-kernel, linux-omap

Hi,

On Tue, Oct 21, 2014 at 12:35:18AM +0300, Aaro Koskinen wrote:
> On Sun, Oct 19, 2014 at 09:19:37PM +0200, Pavel Machek wrote:
> > I am trying to use nfsroot, so I can't use modules.
> 
> Why not?
> 
> > (I am attaching full config, in case I missed something important).
> 
> I'm using the below config with 3.17 and g_ether works OK.

Also, I'm using DT boot.

A.

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-20 16:45           ` Tony Lindgren
@ 2014-10-20 22:03             ` Pavel Machek
  2014-10-20 22:29               ` Tony Lindgren
  0 siblings, 1 reply; 43+ messages in thread
From: Pavel Machek @ 2014-10-20 22:03 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Pali Rohár, sre, sre, kernel list, balbi, linux-arm-kernel,
	linux-omap, kishon, s.nawrocki

On Mon 2014-10-20 09:45:42, Tony Lindgren wrote:
> * Pavel Machek <pavel@ucw.cz> [141020 06:10]:
> > Hi!
> > 
> > > My N900 can boot kernel from v3.12-rc5-n900 branch compiled with 
> > > arch/arm/configs/rx51_defconfig. Also it can boot full Maemo5 
> > > system (with CSSU and some minor system changes) and usb network 
> > > via g_nokia.ko gadget working fine...
> > > 
> > > So if it does not working for you then kernel usb subsystem could 
> > > have problems with using gadgets directly from zimage.
> > 
> > After some hand-bisecting and real-bisecting, I found two commits that
> > cause problems for 3.13: With these reverted, I get usb networking
> > back in 3.13 on nokia n900.
> > 
> > (Pali, if you revert these, you should get working usb networking in
> > your 3.13 branch, too.)
> > 
> > Any ideas?
> 
> Hmm maybe check if current stable kernels work for you without
> reverting anything ? Few weeks ago I did the the following two fixes
> with cc stable v3.13+:
> 
> 96be39ab34b7 usb: phy: twl4030-usb: Fix regressions to runtime PM on omaps
> 85601b8d81e2 usb: phy: twl4030-usb: Fix lost interrupts after ID pin goes down

I tried these on top of 3.14 (where my revert fixes stuff) and no, it
does not seem to help. (Trying stable would be a bit more work).

Do you want me to try on 3.13, too?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-20 22:03             ` Pavel Machek
@ 2014-10-20 22:29               ` Tony Lindgren
  2014-10-21 21:52                 ` Pavel Machek
  0 siblings, 1 reply; 43+ messages in thread
From: Tony Lindgren @ 2014-10-20 22:29 UTC (permalink / raw)
  To: Pavel Machek
  Cc: Pali Rohár, sre, sre, kernel list, balbi, linux-arm-kernel,
	linux-omap, kishon, s.nawrocki

* Pavel Machek <pavel@ucw.cz> [141020 15:04]:
> On Mon 2014-10-20 09:45:42, Tony Lindgren wrote:
> > * Pavel Machek <pavel@ucw.cz> [141020 06:10]:
> > > Hi!
> > > 
> > > > My N900 can boot kernel from v3.12-rc5-n900 branch compiled with 
> > > > arch/arm/configs/rx51_defconfig. Also it can boot full Maemo5 
> > > > system (with CSSU and some minor system changes) and usb network 
> > > > via g_nokia.ko gadget working fine...
> > > > 
> > > > So if it does not working for you then kernel usb subsystem could 
> > > > have problems with using gadgets directly from zimage.
> > > 
> > > After some hand-bisecting and real-bisecting, I found two commits that
> > > cause problems for 3.13: With these reverted, I get usb networking
> > > back in 3.13 on nokia n900.
> > > 
> > > (Pali, if you revert these, you should get working usb networking in
> > > your 3.13 branch, too.)
> > > 
> > > Any ideas?
> > 
> > Hmm maybe check if current stable kernels work for you without
> > reverting anything ? Few weeks ago I did the the following two fixes
> > with cc stable v3.13+:
> > 
> > 96be39ab34b7 usb: phy: twl4030-usb: Fix regressions to runtime PM on omaps
> > 85601b8d81e2 usb: phy: twl4030-usb: Fix lost interrupts after ID pin goes down
> 
> I tried these on top of 3.14 (where my revert fixes stuff) and no, it
> does not seem to help. (Trying stable would be a bit more work).
> 
> Do you want me to try on 3.13, too?

Sounds like there's something else missing too then. Maybe give
v3.18-rc1 and device tree based boot a try?

FYI, there's some PM support there too since v3.16-rc7, so using
anything pre v3.17 is probably not fun on the battery. Well it works
with omap2plus_defconfig long as serial port timeouts are configured,
no USB cable is connected and and the screen is blanked. When it works,
both keyboard debug LEDs will go off during idle, which really should
be most of the time if you plan to use it as a phone. The left debug
LED goes off for retention idle, when both go off it's hitting
off-idle.

I'm using the following test script here, if it does not idle for
you, there are probably some other drivers loaded that currently
block deeper idle states.

Regards,

Tony

8< ---------------
#!/bin/bash

uarts=$(find /sys/class/tty/ttyO*/device/power/ -type d)
for uart in $uarts; do
        echo 3000 > $uart/autosuspend_delay_ms
        #echo -1 > $uart/autosuspend_delay_ms
done

uarts=$(find /sys/class/tty/ttyO*/power/ -type d)
for uart in $uarts; do
        echo enabled > $uart/wakeup
        echo auto > $uart/control
done

echo 255 > /sys/devices/68000000.ocp/48098000.spi/spi_master/spi1/spi1.2/backlight/acx565akm/brightness
echo 1 > /sys/devices/platform/omapfb/graphics/fb0/blank

echo 1 > /sys/kernel/debug/pm_debug/enable_off_mode

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-20 21:35       ` Aaro Koskinen
  2014-10-20 21:37         ` Aaro Koskinen
@ 2014-10-20 22:42         ` Pavel Machek
  2014-10-26 11:08         ` Pavel Machek
  2 siblings, 0 replies; 43+ messages in thread
From: Pavel Machek @ 2014-10-20 22:42 UTC (permalink / raw)
  To: Aaro Koskinen
  Cc: Felipe Balbi, pali.rohar, sre, sre, kernel list,
	linux-arm-kernel, linux-omap

Hi!

> On Sun, Oct 19, 2014 at 09:19:37PM +0200, Pavel Machek wrote:
> > I am trying to use nfsroot, so I can't use modules.
> 
> Why not?

I'm trying to put root filesystem on nfs, without
initrd/initramfs. Thus no modules for me.

> > (I am attaching full config, in case I missed something important).
> 
> I'm using the below config with 3.17 and g_ether works OK.
> 
> (My initramfs modprobes g_ether, runs busybox ifconfig for usb0
> and launches sshd.)

Ok, I was trying to get away without initramfs ... so that setup is
simpler. And yes, I was using legacy boot method.

I switched to device tree based boot and based my config on yours
(with =m -> =y and NFS enabled), but still do not get USB networking
to work. My PC complains:

[153968.993394] usb 4-1: Product: Nokia N900 (Update mode)
[153968.993397] usb 4-1: Manufacturer: Nokia
[153968.993400] usb 4-1: SerialNumber: 4D554D363434323537
[153969.730564] usb 4-1: USB disconnect, device number 122
[153974.592034] usb 4-1: new high-speed USB device number 123 using
ehci-pci
[153989.704035] usb 4-1: device descriptor read/64, error -110
root@amd:/srv/nfs/n900/tmp# 

(and it worked ok with kernels up-to 3.14).

Could you mail me your initramfs or put it on the web somewhere? That
might be useful test...

Thanks and best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-20 22:29               ` Tony Lindgren
@ 2014-10-21 21:52                 ` Pavel Machek
  0 siblings, 0 replies; 43+ messages in thread
From: Pavel Machek @ 2014-10-21 21:52 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Pali Rohár, sre, sre, kernel list, balbi, linux-arm-kernel,
	linux-omap, kishon, s.nawrocki

Hi!

> > > > After some hand-bisecting and real-bisecting, I found two commits that
> > > > cause problems for 3.13: With these reverted, I get usb networking
> > > > back in 3.13 on nokia n900.
> > > > 
> > > > (Pali, if you revert these, you should get working usb networking in
> > > > your 3.13 branch, too.)
> > > > 
> > > > Any ideas?
> > > 
> > > Hmm maybe check if current stable kernels work for you without
> > > reverting anything ? Few weeks ago I did the the following two fixes
> > > with cc stable v3.13+:
> > > 
> > > 96be39ab34b7 usb: phy: twl4030-usb: Fix regressions to runtime PM on omaps
> > > 85601b8d81e2 usb: phy: twl4030-usb: Fix lost interrupts after ID pin goes down
> > 
> > I tried these on top of 3.14 (where my revert fixes stuff) and no, it
> > does not seem to help. (Trying stable would be a bit more work).
> > 
> > Do you want me to try on 3.13, too?
> 
> Sounds like there's something else missing too then. Maybe give
> v3.18-rc1 and device tree based boot a try?

Ok, I tried 3.18-rc1 (with dt appended to the zImage) and this should
be the logs from that attempt (on PC).

[205583.689477] usb 4-1: Product: Nokia N900 (Update mode)
[205583.689480] usb 4-1: Manufacturer: Nokia
[205583.689483] usb 4-1: SerialNumber: 4D554D363434323537
[205584.467273] usb 4-1: USB disconnect, device number 72
[205590.120043] usb 4-1: new high-speed USB device number 73 using
ehci-pci
[205605.232034] usb 4-1: device descriptor read/64, error -110
[205620.448036] usb 4-1: device descriptor read/64, error -110
[205620.664032] usb 4-1: new high-speed USB device number 74 using
ehci-pci
[205635.776032] usb 4-1: device descriptor read/64, error -110
[205650.992032] usb 4-1: device descriptor read/64, error -110
[205651.208030] usb 4-1: new high-speed USB device number 75 using
ehci-pci
[205661.616025] usb 4-1: device not accepting address 75, error -110

IOW usb gadget driver loaded (or there would be no "new high-speed USB
device" message, but communication does not work.

I'm attaching the config.

> FYI, there's some PM support there too since v3.16-rc7, so using
> anything pre v3.17 is probably not fun on the battery. Well it works

My goal is to get nfsroot to work, and then I can play with bluetooth,
userland and power management. For now, power consumption is not
important, as I'm unable to boot useful system.

(I could boot from MMC, but that's too cumbersome to use due to lack
of space, hard communication, and constant fiddling with device
cover).

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-20 21:35       ` Aaro Koskinen
  2014-10-20 21:37         ` Aaro Koskinen
  2014-10-20 22:42         ` Pavel Machek
@ 2014-10-26 11:08         ` Pavel Machek
  2014-10-26 11:12           ` Pali Rohár
  2 siblings, 1 reply; 43+ messages in thread
From: Pavel Machek @ 2014-10-26 11:08 UTC (permalink / raw)
  To: Aaro Koskinen
  Cc: Felipe Balbi, pali.rohar, sre, sre, kernel list,
	linux-arm-kernel, linux-omap

Hi!

> On Sun, Oct 19, 2014 at 09:19:37PM +0200, Pavel Machek wrote:
> > I am trying to use nfsroot, so I can't use modules.
> 
> Why not?
> 
> > (I am attaching full config, in case I missed something important).
> 
> I'm using the below config with 3.17 and g_ether works OK.
> 
> (My initramfs modprobes g_ether, runs busybox ifconfig for usb0
> and launches sshd.)

I am trying to get 3.14 kernel to work, first. There, usb gadget works
when compiled into kernel. But with modules, I get

# root@(none):/tmp# insmod libcomposite.ko                                      
# root@(none):/tmp# insmod u_ether.ko                                           
# root@(none):/tmp# insmod usb_f_rndis.ko                                       
# root@(none):/tmp# insmod g_ether.ko                                           

[  169.061218] udc musb-hdrc.0.auto: registering UDC driver [g_ether]
[  169.078918] g_ether musb-hdrc.0.auto: failed to start g_ether: -2

-2 is ENOENT...
								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-26 11:08         ` Pavel Machek
@ 2014-10-26 11:12           ` Pali Rohár
  2014-10-26 12:00             ` Pavel Machek
  2014-10-26 21:17             ` Pavel Machek
  0 siblings, 2 replies; 43+ messages in thread
From: Pali Rohár @ 2014-10-26 11:12 UTC (permalink / raw)
  To: Pavel Machek
  Cc: Aaro Koskinen, Felipe Balbi, sre, sre, kernel list,
	linux-arm-kernel, linux-omap

[-- Attachment #1: Type: Text/Plain, Size: 1083 bytes --]

On Sunday 26 October 2014 12:08:25 Pavel Machek wrote:
> Hi!
> 
> > On Sun, Oct 19, 2014 at 09:19:37PM +0200, Pavel Machek wrote:
> > > I am trying to use nfsroot, so I can't use modules.
> > 
> > Why not?
> > 
> > > (I am attaching full config, in case I missed something
> > > important).
> > 
> > I'm using the below config with 3.17 and g_ether works OK.
> > 
> > (My initramfs modprobes g_ether, runs busybox ifconfig for
> > usb0 and launches sshd.)
> 
> I am trying to get 3.14 kernel to work, first. There, usb
> gadget works when compiled into kernel. But with modules, I
> get
> 
> # root@(none):/tmp# insmod libcomposite.ko
> # root@(none):/tmp# insmod u_ether.ko
> # root@(none):/tmp# insmod usb_f_rndis.ko
> # root@(none):/tmp# insmod g_ether.ko
> 
> [  169.061218] udc musb-hdrc.0.auto: registering UDC driver
> [g_ether] [  169.078918] g_ether musb-hdrc.0.auto: failed to
> start g_ether: -2
> 
> -2 is ENOENT...
> 								Pavel

Can you try g_nokia.ko? I used this module for usb networking.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-26 11:12           ` Pali Rohár
@ 2014-10-26 12:00             ` Pavel Machek
  2014-10-26 21:17             ` Pavel Machek
  1 sibling, 0 replies; 43+ messages in thread
From: Pavel Machek @ 2014-10-26 12:00 UTC (permalink / raw)
  To: Pali Rohár
  Cc: Aaro Koskinen, Felipe Balbi, sre, sre, kernel list,
	linux-arm-kernel, linux-omap

On Sun 2014-10-26 12:12:46, Pali Rohár wrote:
> On Sunday 26 October 2014 12:08:25 Pavel Machek wrote:
> > Hi!
> > 
> > > On Sun, Oct 19, 2014 at 09:19:37PM +0200, Pavel Machek wrote:
> > > > I am trying to use nfsroot, so I can't use modules.
> > > 
> > > Why not?
> > > 
> > > > (I am attaching full config, in case I missed something
> > > > important).
> > > 
> > > I'm using the below config with 3.17 and g_ether works OK.
> > > 
> > > (My initramfs modprobes g_ether, runs busybox ifconfig for
> > > usb0 and launches sshd.)
> > 
> > I am trying to get 3.14 kernel to work, first. There, usb
> > gadget works when compiled into kernel. But with modules, I
> > get
> > 
> > # root@(none):/tmp# insmod libcomposite.ko
> > # root@(none):/tmp# insmod u_ether.ko
> > # root@(none):/tmp# insmod usb_f_rndis.ko
> > # root@(none):/tmp# insmod g_ether.ko
> > 
> > [  169.061218] udc musb-hdrc.0.auto: registering UDC driver
> > [g_ether] [  169.078918] g_ether musb-hdrc.0.auto: failed to
> > start g_ether: -2
> > 
> > -2 is ENOENT...
> 
> Can you try g_nokia.ko? I used this module for usb networking.

Ok, so lets go to 3.17, and try with compiled-in modules?

[13220.555232] usb 5-1: USB disconnect, device number 41
[13225.972033] usb 5-1: new high-speed USB device number 42 using
ehci-pci
[13241.084037] usb 5-1: device descriptor read/64, error -110
pavel@amd:/data/l/maemo$ 

CONFIG_USB_LIBCOMPOSITE=y
CONFIG_USB_U_ETHER=y
CONFIG_USB_F_ECM=y
CONFIG_USB_F_SUBSET=y
# CONFIG_USB_CONFIGFS is not set                                                                   
# CONFIG_USB_ZERO is not set                                                                       
CONFIG_USB_ETH=y

I had musb_dual_role set, trying to make it gadget-only:

      1. Host only mode (USB_MUSB_HOST) (NEW)
      2. Gadget only mode (USB_MUSB_GADGET) (NEW)
    > 3. Dual Role mode (USB_MUSB_DUAL_ROLE) (NEW)
    choice[1-3]: 2

Same result:
[13621.776030] usb 5-1: new high-speed USB device number 57 using
ehci-pci
[13636.888036] usb 5-1: device descriptor read/64, error -110

Wait a moment. It seems I'm using drivers from legacy/ directory. Is
that good idea?

Lets try:

    10. CDC Composite Device (Ethernet and ACM) (USB_CDC_COMPOSITE)

No, same result.

[13844.456032] usb 5-1: new high-speed USB device number 63 using
ehci-pci
[13859.568028] usb 5-1: device descriptor read/64, error -110

I don't think I can actually select nokia support in 3.17 :-(.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-26 11:12           ` Pali Rohár
  2014-10-26 12:00             ` Pavel Machek
@ 2014-10-26 21:17             ` Pavel Machek
  2014-10-26 21:22               ` Pali Rohár
  1 sibling, 1 reply; 43+ messages in thread
From: Pavel Machek @ 2014-10-26 21:17 UTC (permalink / raw)
  To: Pali Rohár
  Cc: Aaro Koskinen, Felipe Balbi, sre, sre, kernel list,
	linux-arm-kernel, linux-omap

On Sun 2014-10-26 12:12:46, Pali Rohár wrote:
> On Sunday 26 October 2014 12:08:25 Pavel Machek wrote:
> > Hi!
> > 
> > > On Sun, Oct 19, 2014 at 09:19:37PM +0200, Pavel Machek wrote:
> > > > I am trying to use nfsroot, so I can't use modules.
> > > 
> > > Why not?
> > > 
> > > > (I am attaching full config, in case I missed something
> > > > important).
> > > 
> > > I'm using the below config with 3.17 and g_ether works OK.
> > > 
> > > (My initramfs modprobes g_ether, runs busybox ifconfig for
> > > usb0 and launches sshd.)
> > 
> > I am trying to get 3.14 kernel to work, first. There, usb
> > gadget works when compiled into kernel. But with modules, I
> > get
> > 
> > # root@(none):/tmp# insmod libcomposite.ko
> > # root@(none):/tmp# insmod u_ether.ko
> > # root@(none):/tmp# insmod usb_f_rndis.ko
> > # root@(none):/tmp# insmod g_ether.ko
> > 
> > [  169.061218] udc musb-hdrc.0.auto: registering UDC driver
> > [g_ether] [  169.078918] g_ether musb-hdrc.0.auto: failed to
> > start g_ether: -2
> > 
> > -2 is ENOENT...
> 
> Can you try g_nokia.ko? I used this module for usb networking.

I have root prepared on /dev/mmcblk0p6. I tried 3.17 with
rx51_defconfig, but no, it refuses to mount it.

VFS: Cannot open root device "mmcblk0p6" or ....: error -19.

And then it proceeds to list mmcblk0p6 as one of available options
:-(.

Ideas welcome.
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-26 21:17             ` Pavel Machek
@ 2014-10-26 21:22               ` Pali Rohár
  2014-10-26 21:55                 ` Pavel Machek
  0 siblings, 1 reply; 43+ messages in thread
From: Pali Rohár @ 2014-10-26 21:22 UTC (permalink / raw)
  To: Pavel Machek
  Cc: Aaro Koskinen, Felipe Balbi, sre, sre, kernel list,
	linux-arm-kernel, linux-omap

[-- Attachment #1: Type: Text/Plain, Size: 1687 bytes --]

On Sunday 26 October 2014 22:17:21 Pavel Machek wrote:
> On Sun 2014-10-26 12:12:46, Pali Rohár wrote:
> > On Sunday 26 October 2014 12:08:25 Pavel Machek wrote:
> > > Hi!
> > > 
> > > > On Sun, Oct 19, 2014 at 09:19:37PM +0200, Pavel Machek 
wrote:
> > > > > I am trying to use nfsroot, so I can't use modules.
> > > > 
> > > > Why not?
> > > > 
> > > > > (I am attaching full config, in case I missed
> > > > > something important).
> > > > 
> > > > I'm using the below config with 3.17 and g_ether works
> > > > OK.
> > > > 
> > > > (My initramfs modprobes g_ether, runs busybox ifconfig
> > > > for usb0 and launches sshd.)
> > > 
> > > I am trying to get 3.14 kernel to work, first. There, usb
> > > gadget works when compiled into kernel. But with modules,
> > > I get
> > > 
> > > # root@(none):/tmp# insmod libcomposite.ko
> > > # root@(none):/tmp# insmod u_ether.ko
> > > # root@(none):/tmp# insmod usb_f_rndis.ko
> > > # root@(none):/tmp# insmod g_ether.ko
> > > 
> > > [  169.061218] udc musb-hdrc.0.auto: registering UDC
> > > driver [g_ether] [  169.078918] g_ether musb-hdrc.0.auto:
> > > failed to start g_ether: -2
> > > 
> > > -2 is ENOENT...
> > 
> > Can you try g_nokia.ko? I used this module for usb
> > networking.
> 
> I have root prepared on /dev/mmcblk0p6. I tried 3.17 with
> rx51_defconfig, but no, it refuses to mount it.
> 
> VFS: Cannot open root device "mmcblk0p6" or ....: error -19.
> 
> And then it proceeds to list mmcblk0p6 as one of available
> options
> 
> :-(.
> 
> Ideas welcome.
> 									Pavel

Try to add rootdelay=30 or rootwait to kernel cmdline.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-26 21:22               ` Pali Rohár
@ 2014-10-26 21:55                 ` Pavel Machek
  2014-10-26 22:23                   ` Pali Rohár
  0 siblings, 1 reply; 43+ messages in thread
From: Pavel Machek @ 2014-10-26 21:55 UTC (permalink / raw)
  To: Pali Rohár
  Cc: Aaro Koskinen, Felipe Balbi, sre, sre, kernel list,
	linux-arm-kernel, linux-omap


> > I have root prepared on /dev/mmcblk0p6. I tried 3.17 with
> > rx51_defconfig, but no, it refuses to mount it.
> > 
> > VFS: Cannot open root device "mmcblk0p6" or ....: error -19.
> > 
> > And then it proceeds to list mmcblk0p6 as one of available
> > options
> > 
> > :-(.
> > 
> > Ideas welcome.
> 
> Try to add rootdelay=30 or rootwait to kernel cmdline.

I had rootdelay=3. Will try rootwait... no change. This is v3.17 with
rx51_defconfig. CONFIG_MACH_NOKIA_RX51=y => device tree will not be
used AFAICT.

Now I'm back at 3.14 without device tree; same setup works there. I
tried disabling RX51 support in 3.14 (to make it boot using device
tree) but that did not work.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-26 21:55                 ` Pavel Machek
@ 2014-10-26 22:23                   ` Pali Rohár
  2014-10-27 19:52                     ` Tony Lindgren
  0 siblings, 1 reply; 43+ messages in thread
From: Pali Rohár @ 2014-10-26 22:23 UTC (permalink / raw)
  To: Pavel Machek
  Cc: Aaro Koskinen, Felipe Balbi, sre, sre, kernel list,
	linux-arm-kernel, linux-omap

[-- Attachment #1: Type: Text/Plain, Size: 1057 bytes --]

On Sunday 26 October 2014 22:55:48 Pavel Machek wrote:
> > > I have root prepared on /dev/mmcblk0p6. I tried 3.17 with
> > > rx51_defconfig, but no, it refuses to mount it.
> > > 
> > > VFS: Cannot open root device "mmcblk0p6" or ....: error
> > > -19.
> > > 
> > > And then it proceeds to list mmcblk0p6 as one of available
> > > options
> > > 
> > > :-(.
> > > 
> > > Ideas welcome.
> > 
> > Try to add rootdelay=30 or rootwait to kernel cmdline.
> 
> I had rootdelay=3. Will try rootwait... no change. This is
> v3.17 with rx51_defconfig. CONFIG_MACH_NOKIA_RX51=y => device
> tree will not be used AFAICT.
> 
> Now I'm back at 3.14 without device tree; same setup works
> there. I tried disabling RX51 support in 3.14 (to make it
> boot using device tree) but that did not work.
> 								Pavel

I remember that there was some problem with initializing mmc 
device. Sometimes something failed and reading from eMMC was not 
possible. Try to boot kernel from uboot. Maybe it can help.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-26 22:23                   ` Pali Rohár
@ 2014-10-27 19:52                     ` Tony Lindgren
  2014-10-27 22:31                       ` Tony Lindgren
  0 siblings, 1 reply; 43+ messages in thread
From: Tony Lindgren @ 2014-10-27 19:52 UTC (permalink / raw)
  To: Pali Rohár
  Cc: Pavel Machek, Aaro Koskinen, Felipe Balbi, sre, sre, kernel list,
	linux-arm-kernel, linux-omap

* Pali Rohár <pali.rohar@gmail.com> [141026 15:24]:
> On Sunday 26 October 2014 22:55:48 Pavel Machek wrote:
> > > > I have root prepared on /dev/mmcblk0p6. I tried 3.17 with
> > > > rx51_defconfig, but no, it refuses to mount it.
> > > > 
> > > > VFS: Cannot open root device "mmcblk0p6" or ....: error
> > > > -19.
> > > > 
> > > > And then it proceeds to list mmcblk0p6 as one of available
> > > > options
> > > > 
> > > > :-(.
> > > > 
> > > > Ideas welcome.
> > > 
> > > Try to add rootdelay=30 or rootwait to kernel cmdline.
> > 
> > I had rootdelay=3. Will try rootwait... no change. This is
> > v3.17 with rx51_defconfig. CONFIG_MACH_NOKIA_RX51=y => device
> > tree will not be used AFAICT.
> > 
> > Now I'm back at 3.14 without device tree; same setup works
> > there. I tried disabling RX51 support in 3.14 (to make it
> > boot using device tree) but that did not work.
> > 								Pavel
> 
> I remember that there was some problem with initializing mmc 
> device. Sometimes something failed and reading from eMMC was not 
> possible. Try to boot kernel from uboot. Maybe it can help.

Would be nice to have both the USB and the MMC issues sorted
out in the mainline kernel naturally and get rid of any bootloader
dependencies.

I think the USB issue because usb_gadget_probe_driver() bails
out with -ENODEV before the USB controller is found. Felipe, got
any ideas how to fix this to work with -EPROBE_DEFER? Should this
get called only from the USB controller probe?

Regards,

Tony

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-27 19:52                     ` Tony Lindgren
@ 2014-10-27 22:31                       ` Tony Lindgren
  2014-10-28 22:04                         ` Pavel Machek
  0 siblings, 1 reply; 43+ messages in thread
From: Tony Lindgren @ 2014-10-27 22:31 UTC (permalink / raw)
  To: Pali Rohár
  Cc: Pavel Machek, Aaro Koskinen, Felipe Balbi, sre, sre, kernel list,
	linux-arm-kernel, linux-omap

* Tony Lindgren <tony@atomide.com> [141027 12:55]:
> * Pali Rohár <pali.rohar@gmail.com> [141026 15:24]:
> > On Sunday 26 October 2014 22:55:48 Pavel Machek wrote:
> > > > > I have root prepared on /dev/mmcblk0p6. I tried 3.17 with
> > > > > rx51_defconfig, but no, it refuses to mount it.
> > > > > 
> > > > > VFS: Cannot open root device "mmcblk0p6" or ....: error
> > > > > -19.
> > > > > 
> > > > > And then it proceeds to list mmcblk0p6 as one of available
> > > > > options
> > > > > 
> > > > > :-(.
> > > > > 
> > > > > Ideas welcome.
> > > > 
> > > > Try to add rootdelay=30 or rootwait to kernel cmdline.
> > > 
> > > I had rootdelay=3. Will try rootwait... no change. This is
> > > v3.17 with rx51_defconfig. CONFIG_MACH_NOKIA_RX51=y => device
> > > tree will not be used AFAICT.
> > > 
> > > Now I'm back at 3.14 without device tree; same setup works
> > > there. I tried disabling RX51 support in 3.14 (to make it
> > > boot using device tree) but that did not work.
> > > 								Pavel
> > 
> > I remember that there was some problem with initializing mmc 
> > device. Sometimes something failed and reading from eMMC was not 
> > possible. Try to boot kernel from uboot. Maybe it can help.
> 
> Would be nice to have both the USB and the MMC issues sorted
> out in the mainline kernel naturally and get rid of any bootloader
> dependencies.
> 
> I think the USB issue because usb_gadget_probe_driver() bails
> out with -ENODEV before the USB controller is found. Felipe, got
> any ideas how to fix this to work with -EPROBE_DEFER? Should this
> get called only from the USB controller probe?

Here's a patch that should fix the issues for built-in USB
gadgets.

Pavel, care to see if this gets NFSroot over USB working again
for you?

Regards,

Tony

8< ---------------------
From: Tony Lindgren <tony@atomide.com>
Date: Mon, 27 Oct 2014 14:42:42 -0700
Subject: [PATCH] usb: gadget: Fix regressions for initializing built-in gadgets

Up to v3.14 we used to have built-in gadgets work just fine
because they got initialized in the Makefile order and the
dependencies were taken care of by the platform init code.

With device tree based booting, nothing currently assures the
USB controller is initialized by the time the gadgets probe.
This is because we may have GPIOs and PHYs on I2C bus that
cause EPROBE_DEFER to happen for the USB controller.

As the gadgets are not currently bound to any device, they
get initialized with just an initcall.

Let's fix the issue by adding delayed work for the gadgets
to try binding to the USB controller driver. And while at it,
let's make the subsys_initcall() into a late_initcall_sync()
as the gadget won't be able to do anything on it's own early
anyways.

Signed-off-by: Tony Lindgren <tony@atomide.com>

--- a/drivers/usb/gadget/udc/udc-core.c
+++ b/drivers/usb/gadget/udc/udc-core.c
@@ -440,13 +440,20 @@ out:
 }
 EXPORT_SYMBOL_GPL(udc_attach_driver);
 
-int usb_gadget_probe_driver(struct usb_gadget_driver *driver)
+#define USB_GADGET_BIND_RETRIES		5
+#define USB_GADGET_BIND_TIMEOUT		(3 * HZ)
+static void usb_gadget_work(struct work_struct *work)
 {
+	struct usb_gadget_driver *driver = container_of(work,
+						struct usb_gadget_driver,
+						work.work);
 	struct usb_udc		*udc = NULL;
 	int			ret;
 
-	if (!driver || !driver->bind || !driver->setup)
-		return -EINVAL;
+	if (driver->retries++ > USB_GADGET_BIND_RETRIES) {
+		pr_err("couldn't find an available UDC\n");
+		return;
+	}
 
 	mutex_lock(&udc_lock);
 	list_for_each_entry(udc, &udc_list, list) {
@@ -455,13 +462,24 @@ int usb_gadget_probe_driver(struct usb_gadget_driver *driver)
 			goto found;
 	}
 
-	pr_debug("couldn't find an available UDC\n");
 	mutex_unlock(&udc_lock);
-	return -ENODEV;
+	schedule_delayed_work(&driver->work, USB_GADGET_BIND_TIMEOUT);
+	return;
+
 found:
 	ret = udc_bind_to_driver(udc, driver);
 	mutex_unlock(&udc_lock);
-	return ret;
+}
+
+int usb_gadget_probe_driver(struct usb_gadget_driver *driver)
+{
+	if (!driver || !driver->bind || !driver->setup)
+		return -EINVAL;
+
+	INIT_DELAYED_WORK(&driver->work, usb_gadget_work);
+	schedule_delayed_work(&driver->work, 0);
+
+	return 0;
 }
 EXPORT_SYMBOL_GPL(usb_gadget_probe_driver);
 
@@ -473,6 +491,8 @@ int usb_gadget_unregister_driver(struct usb_gadget_driver *driver)
 	if (!driver || !driver->unbind)
 		return -EINVAL;
 
+	cancel_delayed_work(&driver->work);
+
 	mutex_lock(&udc_lock);
 	list_for_each_entry(udc, &udc_list, list)
 		if (udc->driver == driver) {
@@ -621,7 +641,7 @@ static int __init usb_udc_init(void)
 	udc_class->dev_uevent = usb_udc_uevent;
 	return 0;
 }
-subsys_initcall(usb_udc_init);
+late_initcall_sync(usb_udc_init);
 
 static void __exit usb_udc_exit(void)
 {
--- a/include/linux/usb/gadget.h
+++ b/include/linux/usb/gadget.h
@@ -819,6 +819,8 @@ static inline int usb_gadget_disconnect(struct usb_gadget *gadget)
  * @resume: Invoked on USB resume.  May be called in_interrupt.
  * @reset: Invoked on USB bus reset. It is mandatory for all gadget drivers
  *	and should be called in_interrupt.
+ * @work: Gadget work used to bind to the USB controller.
+ * @retries: Gadget retries to bind to the USB controller.
  * @driver: Driver model state for this driver.
  *
  * Devices are disabled till a gadget driver successfully bind()s, which
@@ -877,6 +879,8 @@ struct usb_gadget_driver {
 	void			(*suspend)(struct usb_gadget *);
 	void			(*resume)(struct usb_gadget *);
 	void			(*reset)(struct usb_gadget *);
+	struct delayed_work	work;
+	int			retries;
 
 	/* FIXME support safe rmmod */
 	struct device_driver	driver;

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-27 22:31                       ` Tony Lindgren
@ 2014-10-28 22:04                         ` Pavel Machek
  2014-10-28 22:11                           ` Tony Lindgren
  2014-10-28 22:21                           ` USB Ethernet gadget on Nokia n900 Pavel Machek
  0 siblings, 2 replies; 43+ messages in thread
From: Pavel Machek @ 2014-10-28 22:04 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Pali Rohár, Aaro Koskinen, Felipe Balbi, sre, sre,
	kernel list, linux-arm-kernel, linux-omap

Hi!

> Here's a patch that should fix the issues for built-in USB
> gadgets.
> 
> Pavel, care to see if this gets NFSroot over USB working again
> for you?

It seems to have did the trick for me. (Plus I needed to add

+CONFIG_ARM_ATAG_DTB_COMPAT=y
+CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER=y
+# CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_EXTEND is not set

to be able to control the command line, that's why testing took me a
while.)

Networking now works against 3.17-based kernel. Thanks!

Tested-by: Pavel Machek <pavel@ucw.cz>

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-28 22:04                         ` Pavel Machek
@ 2014-10-28 22:11                           ` Tony Lindgren
  2014-10-29  8:46                             ` Nokia n900 problems in 3.18-rc1 (was Re: USB Ethernet gadget on Nokia n900) Pavel Machek
  2014-10-28 22:21                           ` USB Ethernet gadget on Nokia n900 Pavel Machek
  1 sibling, 1 reply; 43+ messages in thread
From: Tony Lindgren @ 2014-10-28 22:11 UTC (permalink / raw)
  To: Pavel Machek
  Cc: Pali Rohár, Aaro Koskinen, Felipe Balbi, sre, sre,
	kernel list, linux-arm-kernel, linux-omap

* Pavel Machek <pavel@ucw.cz> [141028 15:06]:
> Hi!
> 
> > Here's a patch that should fix the issues for built-in USB
> > gadgets.
> > 
> > Pavel, care to see if this gets NFSroot over USB working again
> > for you?
> 
> It seems to have did the trick for me. (Plus I needed to add
> 
> +CONFIG_ARM_ATAG_DTB_COMPAT=y
> +CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER=y
> +# CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_EXTEND is not set
> 
> to be able to control the command line, that's why testing took me a
> while.)

Hmm I think I have a patch somewhere here to enable the standard
bootz command for n900 mainline u-boot.. That way you can just do

# bootz ${loadaddr} - ${fdtaddr}
 
> Networking now works against 3.17-based kernel. Thanks!

Right on! Ideally the gadget probe would be event driven and called
after USB controller driver probe. But that would mean keeping a
list of all the gadgets as Felipe told me.
 
> Tested-by: Pavel Machek <pavel@ucw.cz>

Thanks for testing,

Tony

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-28 22:04                         ` Pavel Machek
  2014-10-28 22:11                           ` Tony Lindgren
@ 2014-10-28 22:21                           ` Pavel Machek
  2014-10-28 22:26                             ` Tony Lindgren
  1 sibling, 1 reply; 43+ messages in thread
From: Pavel Machek @ 2014-10-28 22:21 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Pali Rohár, Aaro Koskinen, Felipe Balbi, sre, sre,
	kernel list, linux-arm-kernel, linux-omap

On Tue 2014-10-28 23:04:50, Pavel Machek wrote:
> Hi!
> 
> > Here's a patch that should fix the issues for built-in USB
> > gadgets.
> > 
> > Pavel, care to see if this gets NFSroot over USB working again
> > for you?
> 
> It seems to have did the trick for me. (Plus I needed to add
> 
> +CONFIG_ARM_ATAG_DTB_COMPAT=y
> +CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER=y
> +# CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_EXTEND is not set
> 
> to be able to control the command line, that's why testing took me a
> while.)
> 
> Networking now works against 3.17-based kernel. Thanks!

It works on 3.18-rc1 kernel, too. (I had to hand-modify patch to apply
to 3.17, no changes needed for 3.18-rc1.)

Tested-by: Pavel Machek <pavel@ucw.cz>

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-28 22:21                           ` USB Ethernet gadget on Nokia n900 Pavel Machek
@ 2014-10-28 22:26                             ` Tony Lindgren
  2015-07-06 13:24                               ` Pali Rohár
  0 siblings, 1 reply; 43+ messages in thread
From: Tony Lindgren @ 2014-10-28 22:26 UTC (permalink / raw)
  To: Pavel Machek
  Cc: Pali Rohár, Aaro Koskinen, Felipe Balbi, sre, sre,
	kernel list, linux-arm-kernel, linux-omap

* Pavel Machek <pavel@ucw.cz> [141028 15:22]:
> On Tue 2014-10-28 23:04:50, Pavel Machek wrote:
> > Hi!
> > 
> > > Here's a patch that should fix the issues for built-in USB
> > > gadgets.
> > > 
> > > Pavel, care to see if this gets NFSroot over USB working again
> > > for you?
> > 
> > It seems to have did the trick for me. (Plus I needed to add
> > 
> > +CONFIG_ARM_ATAG_DTB_COMPAT=y
> > +CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER=y
> > +# CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_EXTEND is not set
> > 
> > to be able to control the command line, that's why testing took me a
> > while.)
> > 
> > Networking now works against 3.17-based kernel. Thanks!
> 
> It works on 3.18-rc1 kernel, too. (I had to hand-modify patch to apply
> to 3.17, no changes needed for 3.18-rc1.)
> 
> Tested-by: Pavel Machek <pavel@ucw.cz>

Whatever we decice to do to fix this regression, it should probably
be backported to at least v3.16 stable for distro use, maybe earlier
too. I'd assume this is broken on multiple platforms currently.

Regards,

Tony

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Nokia n900 problems in 3.18-rc1 (was Re: USB Ethernet gadget on Nokia n900)
  2014-10-28 22:11                           ` Tony Lindgren
@ 2014-10-29  8:46                             ` Pavel Machek
  2014-10-29 14:09                               ` Tony Lindgren
  0 siblings, 1 reply; 43+ messages in thread
From: Pavel Machek @ 2014-10-29  8:46 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Pali Rohár, Aaro Koskinen, Felipe Balbi, sre, sre,
	kernel list, linux-arm-kernel, linux-omap

Hi!

> > > Here's a patch that should fix the issues for built-in USB
> > > gadgets.
> > > 
> > > Pavel, care to see if this gets NFSroot over USB working again
> > > for you?
> > 
> > It seems to have did the trick for me. (Plus I needed to add
> > 
> > +CONFIG_ARM_ATAG_DTB_COMPAT=y
> > +CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER=y
> > +# CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_EXTEND is not set
> > 
> > to be able to control the command line, that's why testing took me a
> > while.)
> 
> Hmm I think I have a patch somewhere here to enable the standard
> bootz command for n900 mainline u-boot.. That way you can just do
> 
> # bootz ${loadaddr} - ${fdtaddr}

Actually, I guess booting directly from ROM using 0xffff is easier for
testing for now.

Speaking of testing:

I'm not sure what is omap_l3_smx neccessary for, but it does not work.

[    0.223297] omap_l3_smx omap_l3_smx.0: couldn't request debug irq
[    0.223419] omap_l3_smx: probe of omap_l3_smx.0 failed with error
-22

There is some fun in pinmuxing:

[    0.247131] irq: no irq domain found for /ocp/pinmux@48002030 !
[    0.248291] irq: no irq domain found for /ocp/pinmux@48002030 !
...
[    0.384826] omap_i2c 48070000.i2c: could not find pctldev for node
/ocp/pinmux@48002030/pinmux_i\
2c1_pins, deferring probe
[    0.384918] platform 48070000.i2c: Driver omap_i2c requests probe
deferral
[    0.385070] omap_i2c 48072000.i2c: could not find pctldev for node
/ocp/pinmux@48002030/pinmux_i\
2c2_pins, deferring probe
[    0.385162] platform 48072000.i2c: Driver omap_i2c requests probe
deferral
[    0.385284] omap_i2c 48060000.i2c: could not find pctldev for node
/ocp/pinmux@48002030/pinmux_i\
2c3_pins, deferring probe
[    0.385375] platform 48060000.i2c: Driver omap_i2c requests probe
deferral

And serial has some problems:

[    0.482208] of_get_named_gpiod_flags: can't parse 'rts-gpio'
property of node '/ocp/serial@4806c\
000[0]'
[    0.482513] omap_uart 4806c000.serial: ttyO1 at MMIO 0x4806c000
(irq = 223, base_baud = 3000000)\
 is a OMAP UART1
[    0.484588] of_get_named_gpiod_flags: can't parse 'rts-gpio'
property of node '/ocp/serial@49020\
000[0]'
[    0.484771] omap_uart 49020000.serial: ttyO2 at MMIO 0x49020000
(irq = 224, base_baud = 3000000)\
 is a OMAP UART2

There's a lot of noise from probe defferal :-(. And it looks like mmc
properties have some problems:

[    0.739349] of_get_named_gpiod_flags: can't parse 'wp-gpios'
property of node '/ocp/mmc@4809c000\
[0]'
[    0.740142] omap_hsmmc 4809c000.mmc: unable to get vmmc regulator
-517
[    0.740386] platform 4809c000.mmc: Driver omap_hsmmc requests probe
deferral
[    0.740661] of_get_named_gpiod_flags: can't parse 'cd-gpios'
property of node '/ocp/mmc@480b4000\
[0]'
[    0.740692] of_get_named_gpiod_flags: can't parse 'wp-gpios'
property of node '/ocp/mmc@480b4000\
[0]'

omapfb reports problems, but seems to work ok:

[    0.990386] omapfb omapfb: cannot parse default modes
[    1.004791] Console: switching to colour frame buffer device 100x30
[    1.073150] omapfb omapfb: using display 'lcd' mode 800x480

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: Nokia n900 problems in 3.18-rc1 (was Re: USB Ethernet gadget on Nokia n900)
  2014-10-29  8:46                             ` Nokia n900 problems in 3.18-rc1 (was Re: USB Ethernet gadget on Nokia n900) Pavel Machek
@ 2014-10-29 14:09                               ` Tony Lindgren
  2014-10-29 14:18                                 ` Tomi Valkeinen
  2014-10-31 20:03                                 ` Pavel Machek
  0 siblings, 2 replies; 43+ messages in thread
From: Tony Lindgren @ 2014-10-29 14:09 UTC (permalink / raw)
  To: Pavel Machek
  Cc: Pali Rohár, Aaro Koskinen, Felipe Balbi, sre, sre,
	kernel list, linux-arm-kernel, linux-omap, Tomi Valkeinen

* Pavel Machek <pavel@ucw.cz> [141029 01:48]:
> 
> Speaking of testing:
> 
> I'm not sure what is omap_l3_smx neccessary for, but it does not work.
> 
> [    0.223297] omap_l3_smx omap_l3_smx.0: couldn't request debug irq
> [    0.223419] omap_l3_smx: probe of omap_l3_smx.0 failed with error
> -22

Hmm this should be fixed to get interrupts about invalid bus
access.
 
> There is some fun in pinmuxing:
> 
> [    0.247131] irq: no irq domain found for /ocp/pinmux@48002030 !
> [    0.248291] irq: no irq domain found for /ocp/pinmux@48002030 !
> ...
> [    0.384826] omap_i2c 48070000.i2c: could not find pctldev for node
> /ocp/pinmux@48002030/pinmux_i\
> 2c1_pins, deferring probe
> [    0.384918] platform 48070000.i2c: Driver omap_i2c requests probe
> deferral
> [    0.385070] omap_i2c 48072000.i2c: could not find pctldev for node
> /ocp/pinmux@48002030/pinmux_i\
> 2c2_pins, deferring probe
> [    0.385162] platform 48072000.i2c: Driver omap_i2c requests probe
> deferral
> [    0.385284] omap_i2c 48060000.i2c: could not find pctldev for node
> /ocp/pinmux@48002030/pinmux_i\
> 2c3_pins, deferring probe
> [    0.385375] platform 48060000.i2c: Driver omap_i2c requests probe
> deferral

These are related to deferred probe and should go away when we
make drivers/i2c/busses/i2c-omap.c to use regular module_init and
stop using subsys_initcall. But I think legacy booting still needs
it early, could be omap1 only nowadays though.
 
> And serial has some problems:
> 
> [    0.482208] of_get_named_gpiod_flags: can't parse 'rts-gpio'
> property of node '/ocp/serial@4806c\
> 000[0]'
> [    0.482513] omap_uart 4806c000.serial: ttyO1 at MMIO 0x4806c000
> (irq = 223, base_baud = 3000000)\
>  is a OMAP UART1
> [    0.484588] of_get_named_gpiod_flags: can't parse 'rts-gpio'
> property of node '/ocp/serial@49020\
> 000[0]'
> [    0.484771] omap_uart 49020000.serial: ttyO2 at MMIO 0x49020000
> (irq = 224, base_baud = 3000000)\
>  is a OMAP UART2

I these come from the GPIO framework when booting with debug enabled.
 
> There's a lot of noise from probe defferal :-(. And it looks like mmc
> properties have some problems:
> 
> [    0.739349] of_get_named_gpiod_flags: can't parse 'wp-gpios'
> property of node '/ocp/mmc@4809c000\
> [0]'
> [    0.740142] omap_hsmmc 4809c000.mmc: unable to get vmmc regulator
> -517
> [    0.740386] platform 4809c000.mmc: Driver omap_hsmmc requests probe
> deferral
> [    0.740661] of_get_named_gpiod_flags: can't parse 'cd-gpios'
> property of node '/ocp/mmc@480b4000\
> [0]'
> [    0.740692] of_get_named_gpiod_flags: can't parse 'wp-gpios'
> property of node '/ocp/mmc@480b4000\
> [0]'

These too. But yeah, I agree, let's try to patch away some of
the deferred probe noise.
 
> omapfb reports problems, but seems to work ok:
> 
> [    0.990386] omapfb omapfb: cannot parse default modes
> [    1.004791] Console: switching to colour frame buffer device 100x30
> [    1.073150] omapfb omapfb: using display 'lcd' mode 800x480

Tomi, is the default mode warning correct here?

Regards,

Tony

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: Nokia n900 problems in 3.18-rc1 (was Re: USB Ethernet gadget on Nokia n900)
  2014-10-29 14:09                               ` Tony Lindgren
@ 2014-10-29 14:18                                 ` Tomi Valkeinen
  2014-10-29 21:34                                   ` Pavel Machek
  2014-10-31 20:03                                 ` Pavel Machek
  1 sibling, 1 reply; 43+ messages in thread
From: Tomi Valkeinen @ 2014-10-29 14:18 UTC (permalink / raw)
  To: Tony Lindgren, Pavel Machek
  Cc: Pali Rohár, Aaro Koskinen, Felipe Balbi, sre, sre,
	kernel list, linux-arm-kernel, linux-omap

[-- Attachment #1: Type: text/plain, Size: 664 bytes --]

On 29/10/14 16:09, Tony Lindgren wrote:

>> omapfb reports problems, but seems to work ok:
>>
>> [    0.990386] omapfb omapfb: cannot parse default modes
>> [    1.004791] Console: switching to colour frame buffer device 100x30
>> [    1.073150] omapfb omapfb: using display 'lcd' mode 800x480
> 
> Tomi, is the default mode warning correct here?

omapfb warns that it couldn't parse kernel cmdline parameters
('omapfb.mode' parameter). I couldn't find in the thread what actual
parameters were used in this case.

Although I don't see why N900 would need any omapfb mode parameters in
the first place, as the LCD has just one mode...

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: Nokia n900 problems in 3.18-rc1 (was Re: USB Ethernet gadget on Nokia n900)
  2014-10-29 14:18                                 ` Tomi Valkeinen
@ 2014-10-29 21:34                                   ` Pavel Machek
  0 siblings, 0 replies; 43+ messages in thread
From: Pavel Machek @ 2014-10-29 21:34 UTC (permalink / raw)
  To: Tomi Valkeinen
  Cc: Tony Lindgren, Pali Rohár, Aaro Koskinen, Felipe Balbi, sre,
	sre, kernel list, linux-arm-kernel, linux-omap

On Wed 2014-10-29 16:18:46, Tomi Valkeinen wrote:
> On 29/10/14 16:09, Tony Lindgren wrote:
> 
> >> omapfb reports problems, but seems to work ok:
> >>
> >> [    0.990386] omapfb omapfb: cannot parse default modes
> >> [    1.004791] Console: switching to colour frame buffer device 100x30
> >> [    1.073150] omapfb omapfb: using display 'lcd' mode 800x480
> > 
> > Tomi, is the default mode warning correct here?
> 
> omapfb warns that it couldn't parse kernel cmdline parameters
> ('omapfb.mode' parameter). I couldn't find in the thread what actual
> parameters were used in this case.

I had omapfb.mode=lcd:848x480-16 on command line. I removed it now.

> Although I don't see why N900 would need any omapfb mode parameters in
> the first place, as the LCD has just one mode...

I don't know where I copied it from, sorry...
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: Nokia n900 problems in 3.18-rc1 (was Re: USB Ethernet gadget on Nokia n900)
  2014-10-29 14:09                               ` Tony Lindgren
  2014-10-29 14:18                                 ` Tomi Valkeinen
@ 2014-10-31 20:03                                 ` Pavel Machek
  2014-10-31 20:30                                   ` Pali Rohár
  1 sibling, 1 reply; 43+ messages in thread
From: Pavel Machek @ 2014-10-31 20:03 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Pali Rohár, Aaro Koskinen, Felipe Balbi, sre, sre,
	kernel list, linux-arm-kernel, linux-omap, Tomi Valkeinen

Hi!

I tried enabling audio. It works ...sometimes... after fixing
kconfig. But I'm getting WARN_ON, about 50% of time. Ideas welcome.

								Pavel

[    2.398681] rx51-audio n900-audio: GPIO lookup for consumer speaker-amplifier
[    2.398681] rx51-audio n900-audio: using device tree for GPIO lookup
[    2.398742] of_get_named_gpiod_flags: parsed 'speaker-amplifier-gpios' property of node '/n900-audio[0]' - status (0)
[    2.404663] rx51-audio n900-audio: Failed to add TPA6130A2 controls
[    2.411010] rx51-audio n900-audio: ASoC: failed to init TLV320AIC34: -19
[    2.416992] rx51-audio n900-audio: ASoC: failed to instantiate card -19
[    2.423370] gpiod_unexport: invalid GPIO
[    2.429077] ------------[ cut here ]------------
[    2.434661] WARNING: CPU: 0 PID: 6 at drivers/gpio/gpiolib.c:864 gpiod_free+0x2c/0x44()
[    2.440399] Modules linked in:
[    2.445892] CPU: 0 PID: 6 Comm: kworker/u2:0 Tainted: G        W      3.18.0-rc1-omap3-67808-gc4dc985-dirty #554
[    2.458648] Workqueue: deferwq deferred_probe_work_func
[    2.464080] Backtrace: 
[    2.469573] [<c00116ec>] (dump_backtrace) from [<c0011888>] (show_stack+0x18/0x1c)
[    2.475189]  r6:00000360 r5:00000009 r4:00000000 r3:00000000
[    2.480895] [<c0011870>] (show_stack) from [<c0569fd4>] (dump_stack+0x20/0x28)
[    2.486663] [<c0569fb4>] (dump_stack) from [<c0039434>] (warn_slowpath_common+0x6c/0x8c)
[    2.492584] [<c00393c8>] (warn_slowpath_common) from [<c0039478>] (warn_slowpath_null+0x24/0x2c)
[    2.498626]  r8:c079e394 r7:00000000 r6:00000001 r5:00000001 r4:00000000
[    2.504821] [<c0039454>] (warn_slowpath_null) from [<c02336cc>] (gpiod_free+0x2c/0x44)
[    2.511199] [<c02336a0>] (gpiod_free) from [<c02336f4>] (gpiod_put+0x10/0x14)
[    2.517608]  r4:c079e330 r3:ffffffe0
[    2.523895] [<c02336e4>] (gpiod_put) from [<c040f808>] (snd_soc_jack_free_gpios+0x4c/0x60)
[    2.530517] [<c040f7bc>] (snd_soc_jack_free_gpios) from [<c041b140>] (rx51_card_remove+0x1c/0x2c)
[    2.537384]  r7:00000001 r6:cfb76d80 r5:cf991010 r4:ffffffed
[    2.544158] [<c041b124>] (rx51_card_remove) from [<c04098dc>] (snd_soc_register_card+0xabc/0x13b4)
[    2.557525] [<c0408e20>] (snd_soc_register_card) from [<c0415f30>] (devm_snd_soc_register_card+0x34/0x70)
[    2.571624]  r10:00000000 r9:00000000 r8:0000002c r7:cf96d410 r6:c079e2d8 r5:cf3f2250
[    2.579193]  r4:c079e394
[    2.586517] [<c0415efc>] (devm_snd_soc_register_card) from [<c041b2e0>] (rx51_soc_probe+0x190/0x2e8)
[    2.601348]  r7:cf96d410 r6:c079e2d8 r5:cf3f2050 r4:00000000
[    2.608947] [<c041b150>] (rx51_soc_probe) from [<c02a3770>] (platform_drv_probe+0x50/0xac)
[    2.616516]  r7:c079e2ec r6:fffffdfb r5:cf96d410 r4:ffffffed
[    2.624176] [<c02a3720>] (platform_drv_probe) from [<c02a2010>] (driver_probe_device+0x10c/0x22c)
[    2.632049]  r7:c079e2ec r6:00000000 r5:cf96d410 r4:c08b8ab0
[    2.639984] [<c02a1f04>] (driver_probe_device) from [<c02a2210>] (__device_attach+0x48/0x4c)
[    2.647918]  r8:cf025700 r7:cf86c000 r6:c02a21c8 r5:cf96d410 r4:c079e2ec r3:c02a3cb0
[    2.656005] [<c02a21c8>] (__device_attach) from [<c02a05e8>] (bus_for_each_drv+0x4c/0x94)
[    2.664093]  r5:cf96d410 r4:00000000
[    2.672058] [<c02a059c>] (bus_for_each_drv) from [<c02a1ec0>] (device_attach+0x78/0x90)
[    2.680114]  r6:c0787fa0 r5:cf96d444 r4:cf96d410
[    2.688110] [<c02a1e48>] (device_attach) from [<c02a1590>] (bus_probe_device+0x8c/0xb0)
[    2.696166]  r6:c0787fa0 r5:cf96d410 r4:cf96d410 r3:cf8410c0
[    2.704284] [<c02a1504>] (bus_probe_device) from [<c02a1984>] (deferred_probe_work_func+0x64/0x90)
[    2.720275]  r6:c0787f44 r5:c0787f50 r4:cf96d410 r3:c07885c4
[    2.728363] [<c02a1920>] (deferred_probe_work_func) from [<c004c0f8>] (process_one_work+0x120/0x338)
[    2.744140]  r6:cf803e00 r5:c0787f68 r4:cf838280 r3:c02a1920
[    2.752105] [<c004bfd8>] (process_one_work) from [<c004c4a4>] (worker_thread+0x158/0x518)
[    2.760070]  r10:00000088 r9:cf838280 r8:cf838298 r7:00000001 r6:cf803e10 r5:cf86c000
[    2.768035]  r4:cf803e00
[    2.775695] [<c004c34c>] (worker_thread) from [<c0050d0c>] (kthread+0xc8/0xe4)
[    2.783477]  r10:00000000 r9:00000000 r8:00000000 r7:c004c34c r6:cf838280 r5:cf839640
[    2.791320]  r4:00000000
[    2.798889] [<c0050c44>] (kthread) from [<c000ebd8>] (ret_from_fork+0x14/0x3c)
[    2.806518]  r7:00000000 r6:00000000 r5:c0050c44 r4:cf839640
[    2.814178] ---[ end trace 7377fd58b39bf1ee ]---
[    2.821899] rx51-audio n900-audio: snd_soc_register_card failed (-19)
[    2.831146] of_get_named_gpiod_flags: parsed 'gpios' property of node '/gpio_keys/camera_lens_cover[0]' - status (0)
[    2.831237] of_get_named_gpiod_flags: parsed 'gpios' property of node '/gpio_keys/camera_focus[0]' - status (0)
[    2.831329] of_get_named_gpiod_flags: parsed 'gpios' property of node '/gpio_keys/camera_capture[0]' - status (0)
[    2.831390] of_get_named_gpiod_flags: parsed 'gpios' property of node '/gpio_keys/lock_button[0]' - status (0)
[    2.831451] of_get_named_gpiod_flags: parsed 'gpios' property of node '/gpio_keys/keypad_slide[0]' - status (0)
[    2.831512] of_get_named_gpiod_flags: parsed 'gpios' property of node '/gpio_keys/proximity_sensor[0]' - status (0)
[    2.832733] input: gpio_keys as /devices/gpio_keys/input/input5
[    2.857971] twl_rtc 48070000.i2c:twl@48:rtc: setting system clock to 2014-10-31 19:54:47 UTC (1414785287)
[    3.777465]  musb-hdrc.0.auto: registering UDC driver [g_ether]
[    3.777679] using random self ethernet address
[    3.785003] using random host ethernet address
[    3.791900] g_ether gadget: adding config #1 'CDC Ethernet (ECM)'/c0793078
[    3.791961] g_ether gadget: adding 'cdc_ethernet'/cf3ef300 to config 'CDC Ethernet (ECM)'/c0793078
[    3.793579] usb0: HOST MAC 26:c1:fc:d6:eb:34
[    3.800994] usb0: MAC be:19:8e:16:b0:da
[    3.807708] g_ether gadget: CDC Ethernet: dual speed IN/ep1in OUT/ep1out NOTIFY/ep2in

commit 85a6aea58dbfe1068098d4160c17d3dad530ea50
Author: Pavel <pavel@ucw.cz>
Date:   Thu Oct 30 23:35:31 2014 +0100

    Nokia N900 audio driver should be selectable even without RX51 support
    enabled (as is the case with RX51 booting using device tree).
    
    Signed-off-by: Pavel Machek <pavel@ucw.cz>

diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig
index d44463a..0d7b707 100644
--- a/sound/soc/omap/Kconfig
+++ b/sound/soc/omap/Kconfig
@@ -26,7 +26,7 @@ config SND_OMAP_SOC_N810
 
 config SND_OMAP_SOC_RX51
 	tristate "SoC Audio support for Nokia RX-51"
-	depends on SND_OMAP_SOC && ARM && (MACH_NOKIA_RX51 || COMPILE_TEST) && I2C
+	depends on SND_OMAP_SOC && ARM && I2C
 	select SND_OMAP_SOC_MCBSP
 	select SND_SOC_TLV320AIC3X
 	select SND_SOC_TPA6130A2


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply related	[flat|nested] 43+ messages in thread

* Re: Nokia n900 problems in 3.18-rc1 (was Re: USB Ethernet gadget on Nokia n900)
  2014-10-31 20:03                                 ` Pavel Machek
@ 2014-10-31 20:30                                   ` Pali Rohár
  0 siblings, 0 replies; 43+ messages in thread
From: Pali Rohár @ 2014-10-31 20:30 UTC (permalink / raw)
  To: Pavel Machek
  Cc: Tony Lindgren, Aaro Koskinen, Felipe Balbi, sre, sre,
	kernel list, linux-arm-kernel, linux-omap, Tomi Valkeinen

[-- Attachment #1: Type: Text/Plain, Size: 472 bytes --]

On Friday 31 October 2014 21:03:18 Pavel Machek wrote:
> Hi!
> 
> I tried enabling audio. It works ...sometimes... after fixing
> kconfig. But I'm getting WARN_ON, about 50% of time. Ideas
> welcome.
> 
> 								Pavel
> 

I see same problem with audio. Sometimes after reboot it working 
and sometimes not. It looks like Nokia Bootloader set something 
somewhere and then it works... I have no idea how to fix it...

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2014-10-28 22:26                             ` Tony Lindgren
@ 2015-07-06 13:24                               ` Pali Rohár
  2015-07-06 13:53                                 ` Tony Lindgren
  0 siblings, 1 reply; 43+ messages in thread
From: Pali Rohár @ 2015-07-06 13:24 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Pavel Machek, Aaro Koskinen, Felipe Balbi, sre, sre, kernel list,
	linux-arm-kernel, linux-omap

[-- Attachment #1: Type: Text/Plain, Size: 1466 bytes --]

On Tuesday 28 October 2014 23:26:41 Tony Lindgren wrote:
> * Pavel Machek <pavel@ucw.cz> [141028 15:22]:
> > On Tue 2014-10-28 23:04:50, Pavel Machek wrote:
> > > Hi!
> > > 
> > > > Here's a patch that should fix the issues for built-in USB
> > > > gadgets.
> > > > 
> > > > Pavel, care to see if this gets NFSroot over USB working again
> > > > for you?
> > > 
> > > It seems to have did the trick for me. (Plus I needed to add
> > > 
> > > +CONFIG_ARM_ATAG_DTB_COMPAT=y
> > > +CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER=y
> > > +# CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_EXTEND is not set
> > > 
> > > to be able to control the command line, that's why testing took
> > > me a while.)
> > > 
> > > Networking now works against 3.17-based kernel. Thanks!
> > 
> > It works on 3.18-rc1 kernel, too. (I had to hand-modify patch to
> > apply to 3.17, no changes needed for 3.18-rc1.)
> > 
> > Tested-by: Pavel Machek <pavel@ucw.cz>
> 
> Whatever we decice to do to fix this regression, it should probably
> be backported to at least v3.16 stable for distro use, maybe earlier
> too. I'd assume this is broken on multiple platforms currently.
> 
> Regards,
> 
> Tony

Hi Tony,

it looks like this patch was not included into any kernel version... I'm 
still using it on top of 4.x kernels. Are you going to send this patch 
into upstream? Or do you have another fix for this problem?

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2015-07-06 13:24                               ` Pali Rohár
@ 2015-07-06 13:53                                 ` Tony Lindgren
  2015-07-07  7:46                                   ` Pali Rohár
  0 siblings, 1 reply; 43+ messages in thread
From: Tony Lindgren @ 2015-07-06 13:53 UTC (permalink / raw)
  To: Pali Rohár
  Cc: Pavel Machek, Aaro Koskinen, Felipe Balbi, sre, sre, kernel list,
	linux-arm-kernel, linux-omap

* Pali Rohár <pali.rohar@gmail.com> [150706 06:27]:
> On Tuesday 28 October 2014 23:26:41 Tony Lindgren wrote:
> > * Pavel Machek <pavel@ucw.cz> [141028 15:22]:
> > > On Tue 2014-10-28 23:04:50, Pavel Machek wrote:
> > > > 
> > > > Networking now works against 3.17-based kernel. Thanks!
> > > 
> > > It works on 3.18-rc1 kernel, too. (I had to hand-modify patch to
> > > apply to 3.17, no changes needed for 3.18-rc1.)
> > > 
> > > Tested-by: Pavel Machek <pavel@ucw.cz>
> > 
> > Whatever we decice to do to fix this regression, it should probably
> > be backported to at least v3.16 stable for distro use, maybe earlier
> > too. I'd assume this is broken on multiple platforms currently.
> > 
> it looks like this patch was not included into any kernel version... I'm 
> still using it on top of 4.x kernels. Are you going to send this patch 
> into upstream? Or do you have another fix for this problem?

I think Felipe mentioned a better built-in gether fix that's been
reviewed on linux-usb list.

Regards,

Tony

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2015-07-06 13:53                                 ` Tony Lindgren
@ 2015-07-07  7:46                                   ` Pali Rohár
  2015-07-07 11:46                                     ` Tony Lindgren
  0 siblings, 1 reply; 43+ messages in thread
From: Pali Rohár @ 2015-07-07  7:46 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Pavel Machek, Aaro Koskinen, Felipe Balbi, sre, sre, kernel list,
	linux-arm-kernel, linux-omap

On Monday 06 July 2015 06:53:18 Tony Lindgren wrote:
> * Pali Rohár <pali.rohar@gmail.com> [150706 06:27]:
> > On Tuesday 28 October 2014 23:26:41 Tony Lindgren wrote:
> > > * Pavel Machek <pavel@ucw.cz> [141028 15:22]:
> > > > On Tue 2014-10-28 23:04:50, Pavel Machek wrote:
> > > > > 
> > > > > Networking now works against 3.17-based kernel. Thanks!
> > > > 
> > > > It works on 3.18-rc1 kernel, too. (I had to hand-modify patch to
> > > > apply to 3.17, no changes needed for 3.18-rc1.)
> > > > 
> > > > Tested-by: Pavel Machek <pavel@ucw.cz>
> > > 
> > > Whatever we decice to do to fix this regression, it should probably
> > > be backported to at least v3.16 stable for distro use, maybe earlier
> > > too. I'd assume this is broken on multiple platforms currently.
> > > 
> > it looks like this patch was not included into any kernel version... I'm 
> > still using it on top of 4.x kernels. Are you going to send this patch 
> > into upstream? Or do you have another fix for this problem?
> 
> I think Felipe mentioned a better built-in gether fix that's been
> reviewed on linux-usb list.
> 
> Regards,
> 
> Tony

Do you have link to that email thread? Or was Felipe's fix already
merged into mainline kernel?

-- 
Pali Rohár
pali.rohar@gmail.com

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2015-07-07  7:46                                   ` Pali Rohár
@ 2015-07-07 11:46                                     ` Tony Lindgren
  2016-01-19 20:58                                       ` Pali Rohár
  0 siblings, 1 reply; 43+ messages in thread
From: Tony Lindgren @ 2015-07-07 11:46 UTC (permalink / raw)
  To: Pali Rohár
  Cc: Pavel Machek, Aaro Koskinen, Felipe Balbi, sre, sre, kernel list,
	linux-arm-kernel, linux-omap

* Pali Rohár <pali.rohar@gmail.com> [150707 00:48]:
> On Monday 06 July 2015 06:53:18 Tony Lindgren wrote:
> > * Pali Rohár <pali.rohar@gmail.com> [150706 06:27]:
> > > On Tuesday 28 October 2014 23:26:41 Tony Lindgren wrote:
> > > > * Pavel Machek <pavel@ucw.cz> [141028 15:22]:
> > > > > On Tue 2014-10-28 23:04:50, Pavel Machek wrote:
> > > > > > 
> > > > > > Networking now works against 3.17-based kernel. Thanks!
> > > > > 
> > > > > It works on 3.18-rc1 kernel, too. (I had to hand-modify patch to
> > > > > apply to 3.17, no changes needed for 3.18-rc1.)
> > > > > 
> > > > > Tested-by: Pavel Machek <pavel@ucw.cz>
> > > > 
> > > > Whatever we decice to do to fix this regression, it should probably
> > > > be backported to at least v3.16 stable for distro use, maybe earlier
> > > > too. I'd assume this is broken on multiple platforms currently.
> > > > 
> > > it looks like this patch was not included into any kernel version... I'm 
> > > still using it on top of 4.x kernels. Are you going to send this patch 
> > > into upstream? Or do you have another fix for this problem?
> > 
> > I think Felipe mentioned a better built-in gether fix that's been
> > reviewed on linux-usb list.
> 
> Do you have link to that email thread? Or was Felipe's fix already
> merged into mainline kernel?

Sorry I don't have a link, maybe Felipe can point you to the right
patch.

Regards,

Tony

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2015-07-07 11:46                                     ` Tony Lindgren
@ 2016-01-19 20:58                                       ` Pali Rohár
  2016-02-11 14:43                                         ` Pali Rohár
  0 siblings, 1 reply; 43+ messages in thread
From: Pali Rohár @ 2016-01-19 20:58 UTC (permalink / raw)
  To: Felipe Balbi
  Cc: Tony Lindgren, Pavel Machek, Aaro Koskinen, sre, sre,
	kernel list, linux-arm-kernel, linux-omap

[-- Attachment #1: Type: Text/Plain, Size: 1608 bytes --]

On Tuesday 07 July 2015 13:46:59 Tony Lindgren wrote:
> * Pali Rohár <pali.rohar@gmail.com> [150707 00:48]:
> > On Monday 06 July 2015 06:53:18 Tony Lindgren wrote:
> > > * Pali Rohár <pali.rohar@gmail.com> [150706 06:27]:
> > > > On Tuesday 28 October 2014 23:26:41 Tony Lindgren wrote:
> > > > > * Pavel Machek <pavel@ucw.cz> [141028 15:22]:
> > > > > > On Tue 2014-10-28 23:04:50, Pavel Machek wrote:
> > > > > > > Networking now works against 3.17-based kernel. Thanks!
> > > > > > 
> > > > > > It works on 3.18-rc1 kernel, too. (I had to hand-modify
> > > > > > patch to apply to 3.17, no changes needed for 3.18-rc1.)
> > > > > > 
> > > > > > Tested-by: Pavel Machek <pavel@ucw.cz>
> > > > > 
> > > > > Whatever we decice to do to fix this regression, it should
> > > > > probably be backported to at least v3.16 stable for distro
> > > > > use, maybe earlier too. I'd assume this is broken on
> > > > > multiple platforms currently.
> > > > 
> > > > it looks like this patch was not included into any kernel
> > > > version... I'm still using it on top of 4.x kernels. Are you
> > > > going to send this patch into upstream? Or do you have another
> > > > fix for this problem?
> > > 
> > > I think Felipe mentioned a better built-in gether fix that's been
> > > reviewed on linux-usb list.
> > 
> > Do you have link to that email thread? Or was Felipe's fix already
> > merged into mainline kernel?
> 
> Sorry I don't have a link, maybe Felipe can point you to the right
> patch.
> 
> Regards,
> 
> Tony

Felipe, ping

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2016-01-19 20:58                                       ` Pali Rohár
@ 2016-02-11 14:43                                         ` Pali Rohár
  2016-02-11 14:50                                           ` Pali Rohár
  0 siblings, 1 reply; 43+ messages in thread
From: Pali Rohár @ 2016-02-11 14:43 UTC (permalink / raw)
  To: Felipe Balbi
  Cc: Tony Lindgren, Pavel Machek, Aaro Koskinen, sre, sre,
	kernel list, linux-arm-kernel, linux-omap

On Tuesday 19 January 2016 21:58:19 Pali Rohár wrote:
> On Tuesday 07 July 2015 13:46:59 Tony Lindgren wrote:
> > * Pali Rohár <pali.rohar@gmail.com> [150707 00:48]:
> > > On Monday 06 July 2015 06:53:18 Tony Lindgren wrote:
> > > > * Pali Rohár <pali.rohar@gmail.com> [150706 06:27]:
> > > > > On Tuesday 28 October 2014 23:26:41 Tony Lindgren wrote:
> > > > > > * Pavel Machek <pavel@ucw.cz> [141028 15:22]:
> > > > > > > On Tue 2014-10-28 23:04:50, Pavel Machek wrote:
> > > > > > > > Networking now works against 3.17-based kernel. Thanks!
> > > > > > > 
> > > > > > > It works on 3.18-rc1 kernel, too. (I had to hand-modify
> > > > > > > patch to apply to 3.17, no changes needed for 3.18-rc1.)
> > > > > > > 
> > > > > > > Tested-by: Pavel Machek <pavel@ucw.cz>
> > > > > > 
> > > > > > Whatever we decice to do to fix this regression, it should
> > > > > > probably be backported to at least v3.16 stable for distro
> > > > > > use, maybe earlier too. I'd assume this is broken on
> > > > > > multiple platforms currently.
> > > > > 
> > > > > it looks like this patch was not included into any kernel
> > > > > version... I'm still using it on top of 4.x kernels. Are you
> > > > > going to send this patch into upstream? Or do you have another
> > > > > fix for this problem?
> > > > 
> > > > I think Felipe mentioned a better built-in gether fix that's been
> > > > reviewed on linux-usb list.
> > > 
> > > Do you have link to that email thread? Or was Felipe's fix already
> > > merged into mainline kernel?
> > 
> > Sorry I don't have a link, maybe Felipe can point you to the right
> > patch.
> > 
> > Regards,
> > 
> > Tony
> 
> Felipe, ping
> 

PING?

-- 
Pali Rohár
pali.rohar@gmail.com

^ permalink raw reply	[flat|nested] 43+ messages in thread

* Re: USB Ethernet gadget on Nokia n900
  2016-02-11 14:43                                         ` Pali Rohár
@ 2016-02-11 14:50                                           ` Pali Rohár
  0 siblings, 0 replies; 43+ messages in thread
From: Pali Rohár @ 2016-02-11 14:50 UTC (permalink / raw)
  To: Felipe Balbi
  Cc: Tony Lindgren, Pavel Machek, Aaro Koskinen, sre, sre,
	kernel list, linux-arm-kernel, linux-omap

On Thursday 11 February 2016 15:43:47 Pali Rohár wrote:
> On Tuesday 19 January 2016 21:58:19 Pali Rohár wrote:
> > On Tuesday 07 July 2015 13:46:59 Tony Lindgren wrote:
> > > * Pali Rohár <pali.rohar@gmail.com> [150707 00:48]:
> > > > On Monday 06 July 2015 06:53:18 Tony Lindgren wrote:
> > > > > * Pali Rohár <pali.rohar@gmail.com> [150706 06:27]:
> > > > > > On Tuesday 28 October 2014 23:26:41 Tony Lindgren wrote:
> > > > > > > * Pavel Machek <pavel@ucw.cz> [141028 15:22]:
> > > > > > > > On Tue 2014-10-28 23:04:50, Pavel Machek wrote:
> > > > > > > > > Networking now works against 3.17-based kernel. Thanks!
> > > > > > > > 
> > > > > > > > It works on 3.18-rc1 kernel, too. (I had to hand-modify
> > > > > > > > patch to apply to 3.17, no changes needed for 3.18-rc1.)
> > > > > > > > 
> > > > > > > > Tested-by: Pavel Machek <pavel@ucw.cz>
> > > > > > > 
> > > > > > > Whatever we decice to do to fix this regression, it should
> > > > > > > probably be backported to at least v3.16 stable for distro
> > > > > > > use, maybe earlier too. I'd assume this is broken on
> > > > > > > multiple platforms currently.
> > > > > > 
> > > > > > it looks like this patch was not included into any kernel
> > > > > > version... I'm still using it on top of 4.x kernels. Are you
> > > > > > going to send this patch into upstream? Or do you have another
> > > > > > fix for this problem?
> > > > > 
> > > > > I think Felipe mentioned a better built-in gether fix that's been
> > > > > reviewed on linux-usb list.
> > > > 
> > > > Do you have link to that email thread? Or was Felipe's fix already
> > > > merged into mainline kernel?
> > > 
> > > Sorry I don't have a link, maybe Felipe can point you to the right
> > > patch.
> > > 
> > > Regards,
> > > 
> > > Tony
> > 
> > Felipe, ping
> > 
> 
> PING?
> 

Ok, Felipe address is dead:
550 Invalid recipient <balbi@ti.com> (#5.1.1)

-- 
Pali Rohár
pali.rohar@gmail.com

^ permalink raw reply	[flat|nested] 43+ messages in thread

end of thread, other threads:[~2016-02-11 14:50 UTC | newest]

Thread overview: 43+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-19  9:01 USB Ethernet gadget on Nokia n900 Pavel Machek
2014-10-19 10:07 ` Pavel Machek
2014-10-19 14:58   ` Pali Rohár
2014-10-19 20:50     ` Pavel Machek
2014-10-19 21:00       ` Pali Rohár
2014-10-19 22:30         ` Pavel Machek
2014-10-20 13:08         ` Pavel Machek
2014-10-20 16:45           ` Tony Lindgren
2014-10-20 22:03             ` Pavel Machek
2014-10-20 22:29               ` Tony Lindgren
2014-10-21 21:52                 ` Pavel Machek
2014-10-19 15:24   ` Felipe Balbi
2014-10-19 19:19     ` Pavel Machek
2014-10-19 19:29       ` Pavel Machek
2014-10-20 21:35       ` Aaro Koskinen
2014-10-20 21:37         ` Aaro Koskinen
2014-10-20 22:42         ` Pavel Machek
2014-10-26 11:08         ` Pavel Machek
2014-10-26 11:12           ` Pali Rohár
2014-10-26 12:00             ` Pavel Machek
2014-10-26 21:17             ` Pavel Machek
2014-10-26 21:22               ` Pali Rohár
2014-10-26 21:55                 ` Pavel Machek
2014-10-26 22:23                   ` Pali Rohár
2014-10-27 19:52                     ` Tony Lindgren
2014-10-27 22:31                       ` Tony Lindgren
2014-10-28 22:04                         ` Pavel Machek
2014-10-28 22:11                           ` Tony Lindgren
2014-10-29  8:46                             ` Nokia n900 problems in 3.18-rc1 (was Re: USB Ethernet gadget on Nokia n900) Pavel Machek
2014-10-29 14:09                               ` Tony Lindgren
2014-10-29 14:18                                 ` Tomi Valkeinen
2014-10-29 21:34                                   ` Pavel Machek
2014-10-31 20:03                                 ` Pavel Machek
2014-10-31 20:30                                   ` Pali Rohár
2014-10-28 22:21                           ` USB Ethernet gadget on Nokia n900 Pavel Machek
2014-10-28 22:26                             ` Tony Lindgren
2015-07-06 13:24                               ` Pali Rohár
2015-07-06 13:53                                 ` Tony Lindgren
2015-07-07  7:46                                   ` Pali Rohár
2015-07-07 11:46                                     ` Tony Lindgren
2016-01-19 20:58                                       ` Pali Rohár
2016-02-11 14:43                                         ` Pali Rohár
2016-02-11 14:50                                           ` Pali Rohár

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).