* [PATCH 1/1 net-next] ipx: replace long unsigned int by unsigned long
@ 2014-10-27 18:05 Fabian Frederick
2014-10-27 18:22 ` Joe Perches
2014-10-27 19:46 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Fabian Frederick @ 2014-10-27 18:05 UTC (permalink / raw)
To: linux-kernel
Cc: Fabian Frederick, Arnaldo Carvalho de Melo, David S. Miller, netdev
Use standard unsigned long.
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
net/ipx/ipx_proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipx/ipx_proc.c b/net/ipx/ipx_proc.c
index e15c16a..c0cb442 100644
--- a/net/ipx/ipx_proc.c
+++ b/net/ipx/ipx_proc.c
@@ -90,7 +90,7 @@ static int ipx_seq_route_show(struct seq_file *seq, void *v)
seq_printf(seq, "%08lX ", (unsigned long int)ntohl(rt->ir_net));
if (rt->ir_routed)
seq_printf(seq, "%08lX %02X%02X%02X%02X%02X%02X\n",
- (long unsigned int)ntohl(rt->ir_intrfc->if_netnum),
+ (unsigned long)ntohl(rt->ir_intrfc->if_netnum),
rt->ir_router_node[0], rt->ir_router_node[1],
rt->ir_router_node[2], rt->ir_router_node[3],
rt->ir_router_node[4], rt->ir_router_node[5]);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1 net-next] ipx: replace long unsigned int by unsigned long
2014-10-27 18:05 [PATCH 1/1 net-next] ipx: replace long unsigned int by unsigned long Fabian Frederick
@ 2014-10-27 18:22 ` Joe Perches
2014-10-27 19:46 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Joe Perches @ 2014-10-27 18:22 UTC (permalink / raw)
To: Fabian Frederick
Cc: linux-kernel, Arnaldo Carvalho de Melo, David S. Miller, netdev
On Mon, 2014-10-27 at 19:05 +0100, Fabian Frederick wrote:
> Use standard unsigned long.
[]
> diff --git a/net/ipx/ipx_proc.c b/net/ipx/ipx_proc.c
[]
> @@ -90,7 +90,7 @@ static int ipx_seq_route_show(struct seq_file *seq, void *v)
> seq_printf(seq, "%08lX ", (unsigned long int)ntohl(rt->ir_net));
> if (rt->ir_routed)
> seq_printf(seq, "%08lX %02X%02X%02X%02X%02X%02X\n",
> - (long unsigned int)ntohl(rt->ir_intrfc->if_netnum),
> + (unsigned long)ntohl(rt->ir_intrfc->if_netnum),
Maybe better to use no cast at all
seq_printf(seq, "%08X %02X%02X%02X%02X%02X%02X\n",
ntohl(etc...),
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1 net-next] ipx: replace long unsigned int by unsigned long
2014-10-27 18:05 [PATCH 1/1 net-next] ipx: replace long unsigned int by unsigned long Fabian Frederick
2014-10-27 18:22 ` Joe Perches
@ 2014-10-27 19:46 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-10-27 19:46 UTC (permalink / raw)
To: fabf; +Cc: linux-kernel, acme, netdev
From: Fabian Frederick <fabf@skynet.be>
Date: Mon, 27 Oct 2014 19:05:33 +0100
> @@ -90,7 +90,7 @@ static int ipx_seq_route_show(struct seq_file *seq, void *v)
> seq_printf(seq, "%08lX ", (unsigned long int)ntohl(rt->ir_net));
> if (rt->ir_routed)
> seq_printf(seq, "%08lX %02X%02X%02X%02X%02X%02X\n",
> - (long unsigned int)ntohl(rt->ir_intrfc->if_netnum),
> + (unsigned long)ntohl(rt->ir_intrfc->if_netnum),
How about we kill the silly cast altogether and use plain %08X?
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-27 19:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-27 18:05 [PATCH 1/1 net-next] ipx: replace long unsigned int by unsigned long Fabian Frederick
2014-10-27 18:22 ` Joe Perches
2014-10-27 19:46 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).