[PATCH] regulator: max77693: Fix use of uninitialized regulator config

[PATCH] regulator: max77693: Fix use of uninitialized regulator config

[Krzysztof Kozlowski]

Driver allocated on stack struct regulator_config but didn't initialize
it fully. Few fields (driver_data, ena_gpio) were left untouched. This
lead to using random ena_gpio values as GPIOs for max77693 regulators.

On occasion these values could match real GPIO numbers leading to
interfering with other drivers and to unsuccessful enable/disable of
regulator.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Fixes: 80b022e29bfd ("regulator: max77693: Add max77693 regualtor driver.")
Cc: <stable@vger.kernel.org>
---
 drivers/regulator/max77693.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/max77693.c b/drivers/regulator/max77693.c
index 177dd9d2ce67..7b9755a6c3b5 100644
--- a/drivers/regulator/max77693.c
+++ b/drivers/regulator/max77693.c
@@ -227,7 +227,7 @@ static int max77693_pmic_probe(struct platform_device *pdev)
 	struct max77693_dev *iodev = dev_get_drvdata(pdev->dev.parent);
 	struct max77693_regulator_data *rdata = NULL;
 	int num_rdata, i;
-	struct regulator_config config;
+	struct regulator_config config = { };
 
 	num_rdata = max77693_pmic_init_rdata(&pdev->dev, &rdata);
 	if (!rdata || num_rdata <= 0) {
-- 
1.9.1

Re: [PATCH] regulator: max77693: Fix use of uninitialized regulator config

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

On Mon, Nov 03, 2014 at 03:07:05PM +0100, Krzysztof Kozlowski wrote:
> Driver allocated on stack struct regulator_config but didn't initialize
> it fully. Few fields (driver_data, ena_gpio) were left untouched. This
> lead to using random ena_gpio values as GPIOs for max77693 regulators.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]