[PATCH] USB: simple: add Google simple serial SubClass support

[PATCH] USB: simple: add Google simple serial SubClass support

[Anton Staaf]

Add support for Google devices that export simple serial
interfaces using the vendor specific SubClass/Protocol pair
0x50/0x01.

Signed-off-by: Anton Staaf <robotboy@chromium.org>
---
 drivers/usb/serial/usb-serial-simple.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c
index 8bfc47c..a3572b7 100644
--- a/drivers/usb/serial/usb-serial-simple.c
+++ b/drivers/usb/serial/usb-serial-simple.c
@@ -91,6 +91,14 @@ DEVICE(suunto, SUUNTO_IDS);
 	{ USB_DEVICE(0x908, 0x0004) }
 DEVICE(siemens_mpi, SIEMENS_IDS);
 
+/* Google Serial USB SubClass */
+#define GOOGLE_IDS()					       \
+	{ USB_VENDOR_AND_INTERFACE_INFO(0x18d1,		       \
+					USB_CLASS_VENDOR_SPEC, \
+					0x50,		       \
+					0x01) }
+DEVICE(google, GOOGLE_IDS);
+
 /* All of the above structures mushed into two lists */
 static struct usb_serial_driver * const serial_drivers[] = {
 	&carelink_device,
@@ -103,6 +111,7 @@ static struct usb_serial_driver * const serial_drivers[] = {
 	&hp4x_device,
 	&suunto_device,
 	&siemens_mpi_device,
+	&google_device,
 	NULL
 };
 
@@ -117,6 +126,7 @@ static const struct usb_device_id id_table[] = {
 	HP4X_IDS(),
 	SUUNTO_IDS(),
 	SIEMENS_IDS(),
+	GOOGLE_IDS(),
 	{ },
 };
 MODULE_DEVICE_TABLE(usb, id_table);
-- 
2.1.0.rc2.206.gedb03e5

Re: [PATCH] USB: simple: add Google simple serial SubClass support

[Benson Leung]

On Mon, Nov 3, 2014 at 8:43 AM, Anton Staaf <robotboy@chromium.org> wrote:
> Add support for Google devices that export simple serial
> interfaces using the vendor specific SubClass/Protocol pair
> 0x50/0x01.
>
> Signed-off-by: Anton Staaf <robotboy@chromium.org>

Reviewed-by: Benson Leung <bleung@chromium.org>




-- 
Benson Leung
Software Engineer, Chrom* OS
bleung@chromium.org

Re: [PATCH] USB: simple: add Google simple serial SubClass support

[Johan Hovold]

On Mon, Nov 03, 2014 at 10:59:59AM -0800, Benson Leung wrote:
> On Mon, Nov 3, 2014 at 8:43 AM, Anton Staaf <robotboy@chromium.org> wrote:
> > Add support for Google devices that export simple serial
> > interfaces using the vendor specific SubClass/Protocol pair
> > 0x50/0x01.
> >
> > Signed-off-by: Anton Staaf <robotboy@chromium.org>
> 
> Reviewed-by: Benson Leung <bleung@chromium.org>

Applied to next, thanks.

Johan

Re: [PATCH] USB: simple: add Google simple serial SubClass support

[Johan Hovold]

On Thu, Oct 30, 2014 at 09:54:54PM -0700, Anton Staaf wrote:
> On Thu, Oct 30, 2014 at 7:33 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Wed, Oct 29, 2014 at 02:21:56PM -0700, Anton Staaf wrote:
> > > Add support for Google devices that export simple serial
> > > interfaces using the vendor specific SubClass/Protocol pair
> > > 0x50/0x01.
> > >
> > > Signed-off-by: Anton Staaf <robotboy@chromium.org>
> > >
> > > ---
> > >  drivers/usb/serial/usb-serial-simple.c | 11 +++++++++++
> > >  1 file changed, 11 insertions(+)
> > >
> > > diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c
> > > index fb79775..85bb973 100644
> > > --- a/drivers/usb/serial/usb-serial-simple.c
> > > +++ b/drivers/usb/serial/usb-serial-simple.c
> > > @@ -8,6 +8,7 @@
> > >   * Copyright (C) 2010 Zilogic Systems <code@zilogic.com>
> > >   * Copyright (C) 2013 Wei Shuai <cpuwolf@gmail.com>
> > >   * Copyright (C) 2013 Linux Foundation
> > > + * Copyright (C) 2014 Google, Inc.
> > >   *
> > >   *   This program is free software; you can redistribute it and/or
> > >   *   modify it under the terms of the GNU General Public License version
> >
> > Based on advice from my lawyer, a change this size does not warrent a
> > copyright notice at the top of a file.  If your lawyers feel otherwise,
> > please let me know and I will be glad to discuss it with them.
> >
> > So, care to resend this without this change to the file?
> >
> > thanks,
> >
> > greg k-h
> 
> Sigh, sorry for the top posted HTML junk previously, turns out the
> gmail app for android doesn't "do the right thing"...
> 
> But yes, I'm happy to send along a version without copyright, I don't
> see any problem with that.  Looks like it will
> have to wait until Monday as I don't have things set up at home to
> send the patch as robotboy@chromium.org.  :)

Please also make sure to generate the patch against v3.18-rc (the one
you sent would not apply).

Thanks,
Johan

Re: [PATCH] USB: simple: add Google simple serial SubClass support

[Anton Staaf]

On Thu, Oct 30, 2014 at 7:33 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Wed, Oct 29, 2014 at 02:21:56PM -0700, Anton Staaf wrote:
> > Add support for Google devices that export simple serial
> > interfaces using the vendor specific SubClass/Protocol pair
> > 0x50/0x01.
> >
> > Signed-off-by: Anton Staaf <robotboy@chromium.org>
> >
> > ---
> >  drivers/usb/serial/usb-serial-simple.c | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c
> > index fb79775..85bb973 100644
> > --- a/drivers/usb/serial/usb-serial-simple.c
> > +++ b/drivers/usb/serial/usb-serial-simple.c
> > @@ -8,6 +8,7 @@
> >   * Copyright (C) 2010 Zilogic Systems <code@zilogic.com>
> >   * Copyright (C) 2013 Wei Shuai <cpuwolf@gmail.com>
> >   * Copyright (C) 2013 Linux Foundation
> > + * Copyright (C) 2014 Google, Inc.
> >   *
> >   *   This program is free software; you can redistribute it and/or
> >   *   modify it under the terms of the GNU General Public License version
>
> Based on advice from my lawyer, a change this size does not warrent a
> copyright notice at the top of a file.  If your lawyers feel otherwise,
> please let me know and I will be glad to discuss it with them.
>
> So, care to resend this without this change to the file?
>
> thanks,
>
> greg k-h

Sigh, sorry for the top posted HTML junk previously, turns out the
gmail app for android doesn't "do the right thing"...

But yes, I'm happy to send along a version without copyright, I don't
see any problem with that.  Looks like it will
have to wait until Monday as I don't have things set up at home to
send the patch as robotboy@chromium.org.  :)

Thanks,
    Anton

Re: [PATCH] USB: simple: add Google simple serial SubClass support

[Greg Kroah-Hartman]

On Wed, Oct 29, 2014 at 02:21:56PM -0700, Anton Staaf wrote:
> Add support for Google devices that export simple serial
> interfaces using the vendor specific SubClass/Protocol pair
> 0x50/0x01.
> 
> Signed-off-by: Anton Staaf <robotboy@chromium.org>
> 
> ---
>  drivers/usb/serial/usb-serial-simple.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c
> index fb79775..85bb973 100644
> --- a/drivers/usb/serial/usb-serial-simple.c
> +++ b/drivers/usb/serial/usb-serial-simple.c
> @@ -8,6 +8,7 @@
>   * Copyright (C) 2010 Zilogic Systems <code@zilogic.com>
>   * Copyright (C) 2013 Wei Shuai <cpuwolf@gmail.com>
>   * Copyright (C) 2013 Linux Foundation
> + * Copyright (C) 2014 Google, Inc.
>   *
>   *	This program is free software; you can redistribute it and/or
>   *	modify it under the terms of the GNU General Public License version

Based on advice from my lawyer, a change this size does not warrent a
copyright notice at the top of a file.  If your lawyers feel otherwise,
please let me know and I will be glad to discuss it with them.

So, care to resend this without this change to the file?

thanks,

greg k-h

[PATCH] USB: simple: add Google simple serial SubClass support

[Anton Staaf]

Add support for Google devices that export simple serial
interfaces using the vendor specific SubClass/Protocol pair
0x50/0x01.

Signed-off-by: Anton Staaf <robotboy@chromium.org>

---
 drivers/usb/serial/usb-serial-simple.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c
index fb79775..85bb973 100644
--- a/drivers/usb/serial/usb-serial-simple.c
+++ b/drivers/usb/serial/usb-serial-simple.c
@@ -8,6 +8,7 @@
  * Copyright (C) 2010 Zilogic Systems <code@zilogic.com>
  * Copyright (C) 2013 Wei Shuai <cpuwolf@gmail.com>
  * Copyright (C) 2013 Linux Foundation
+ * Copyright (C) 2014 Google, Inc.
  *
  *	This program is free software; you can redistribute it and/or
  *	modify it under the terms of the GNU General Public License version
@@ -80,6 +81,14 @@ DEVICE(suunto, SUUNTO_IDS);
 	{ USB_DEVICE(0x908, 0x0004) }
 DEVICE(siemens_mpi, SIEMENS_IDS);
 
+/* Google Serial USB SubClass */
+#define GOOGLE_IDS()					       \
+	{ USB_VENDOR_AND_INTERFACE_INFO(0x18d1,		       \
+					USB_CLASS_VENDOR_SPEC, \
+					0x50,		       \
+					0x01) }
+DEVICE(google, GOOGLE_IDS);
+
 /* All of the above structures mushed into two lists */
 static struct usb_serial_driver * const serial_drivers[] = {
 	&zio_device,
@@ -90,6 +99,7 @@ static struct usb_serial_driver * const serial_drivers[] = {
 	&hp4x_device,
 	&suunto_device,
 	&siemens_mpi_device,
+	&google_device,
 	NULL
 };
 
@@ -102,6 +112,7 @@ static const struct usb_device_id id_table[] = {
 	HP4X_IDS(),
 	SUUNTO_IDS(),
 	SIEMENS_IDS(),
+	GOOGLE_IDS(),
 	{ },
 };
 MODULE_DEVICE_TABLE(usb, id_table);
-- 
2.1.0.rc2.206.gedb03e5