From: Sakari Ailus <sakari.ailus@iki.fi>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-api@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Subject: Re: [PATCH 11/15] [media] Deprecate v4l2_mbus_pixelcode
Date: Wed, 5 Nov 2014 17:22:52 +0200 [thread overview]
Message-ID: <20141105152252.GV3136@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <20141105161538.7a1686d5@bbrezillon>
Hi Boris,
On Wed, Nov 05, 2014 at 04:15:38PM +0100, Boris Brezillon wrote:
> On Wed, 5 Nov 2014 17:08:15 +0200
> Sakari Ailus <sakari.ailus@iki.fi> wrote:
> > I would keep the original file name, even if the compatibility definitions
> > are there. I don't see any harm in having them around as well.
> >
>
> That's the part I was not sure about.
> The goal of this patch (and the following ones) is to deprecate
> v4l2_mbus_pixelcode enum and its values by adding a #warning when
> v4l2-mediabus.h file is included, thus encouraging people to use new
> definitions.
>
> Do you see another solution to generate such warnings at compilation
> time ?
Do you think we need a warning? In a general case we can't start renaming
interface headers once the preferred interface changes, albeit in this case
it would be a possibility.
The presence of the formats defined from now on only in the new definitions
should be good enough. There are many cases such as this in the V4L2 and
other APIs.
I wonder what others think.
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
next prev parent reply other threads:[~2014-11-05 15:23 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 9:54 [PATCH 00/15] [media] Make mediabus format subsystem neutral Boris Brezillon
2014-11-04 9:54 ` [PATCH 01/15] [media] Move mediabus format definition to a more standard place Boris Brezillon
2014-11-04 10:20 ` Hans Verkuil
2014-11-04 10:22 ` Hans Verkuil
2014-11-04 10:45 ` Boris Brezillon
2014-11-04 11:09 ` Hans Verkuil
2014-11-05 15:00 ` Sakari Ailus
2014-11-05 15:32 ` Boris Brezillon
2014-11-04 9:54 ` [PATCH 02/15] [media] v4l: Update subdev-formats doc with new MEDIA_BUS_FMT values Boris Brezillon
2014-11-05 14:57 ` Sakari Ailus
2014-11-05 15:01 ` Boris Brezillon
2014-11-04 9:54 ` [PATCH 03/15] [media] Make use of the new media_bus_format definitions Boris Brezillon
2014-11-05 15:19 ` Sakari Ailus
2014-11-04 9:54 ` [PATCH 04/15] [media] i2c: Make use of media_bus_format enum Boris Brezillon
2014-11-04 9:55 ` [PATCH 05/15] [media] pci: " Boris Brezillon
2014-11-04 9:55 ` [PATCH 06/15] [media] platform: " Boris Brezillon
2014-11-04 9:55 ` [PATCH 07/15] [media] usb: " Boris Brezillon
2014-11-04 9:55 ` [PATCH 08/15] staging: media: " Boris Brezillon
2014-11-04 9:55 ` [PATCH 09/15] gpu: ipu-v3: " Boris Brezillon
2014-11-04 9:55 ` [PATCH 10/15] [media] v4l: Forbid usage of V4L2_MBUS_FMT definitions inside the kernel Boris Brezillon
2014-11-04 9:55 ` [PATCH 11/15] [media] Deprecate v4l2_mbus_pixelcode Boris Brezillon
2014-11-05 15:08 ` Sakari Ailus
2014-11-05 15:15 ` Boris Brezillon
2014-11-05 15:19 ` Hans Verkuil
2014-11-05 15:30 ` Boris Brezillon
2014-11-05 15:34 ` Hans Verkuil
2014-11-05 15:22 ` Sakari Ailus [this message]
2014-11-04 9:55 ` [PATCH 12/15] [media] i2c: Replace v4l2-mediabus.h inclusion with v4l2-mbus.h Boris Brezillon
2014-11-04 9:55 ` [PATCH 13/15] gpu: ipu-v3: " Boris Brezillon
2014-11-04 9:55 ` [PATCH 14/15] [media] platform: " Boris Brezillon
2014-11-04 9:55 ` [PATCH 15/15] staging: media: " Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141105152252.GV3136@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=boris.brezillon@free-electrons.com \
--cc=devel@driverdev.osuosl.org \
--cc=g.liakhovetski@gmx.de \
--cc=hans.verkuil@cisco.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).