From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Hans Verkuil <hansverk@cisco.com>
Cc: Sakari Ailus <sakari.ailus@iki.fi>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-api@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Subject: Re: [PATCH 11/15] [media] Deprecate v4l2_mbus_pixelcode
Date: Wed, 5 Nov 2014 16:30:49 +0100 [thread overview]
Message-ID: <20141105163049.65d02aff@bbrezillon> (raw)
In-Reply-To: <545A401C.8070908@cisco.com>
On Wed, 05 Nov 2014 16:19:56 +0100
Hans Verkuil <hansverk@cisco.com> wrote:
>
>
> On 11/05/14 16:15, Boris Brezillon wrote:
> > On Wed, 5 Nov 2014 17:08:15 +0200
> > Sakari Ailus <sakari.ailus@iki.fi> wrote:
> >
> >> Hi Boris,
> >>
> >> On Tue, Nov 04, 2014 at 10:55:06AM +0100, Boris Brezillon wrote:
> >>> The v4l2_mbus_pixelcode enum (or its values) should be replaced by the
> >>> media_bus_format enum.
> >>> Keep this enum in v4l2-mediabus.h and create a new header containing
> >>> the v4l2_mbus_framefmt struct definition (which is not deprecated) so
> >>> that we can add a #warning statement in v4l2-mediabus.h and hopefully
> >>> encourage users to move to the new definitions.
> >>>
> >>> Replace inclusion of v4l2-mediabus.h with v4l2-mbus.h in all common headers
> >>> and update the documentation Makefile to parse v4l2-mbus.h instead of
> >>> v4l2-mediabus.h.
> >>>
> >>> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> >>> ---
> >>> Documentation/DocBook/media/Makefile | 2 +-
> >>> include/media/v4l2-mediabus.h | 2 +-
> >>> include/uapi/linux/Kbuild | 1 +
> >>> include/uapi/linux/v4l2-mbus.h | 35 +++++++++++++++++++++++++++++++++++
> >>> include/uapi/linux/v4l2-mediabus.h | 26 ++++----------------------
> >>
> >> I would keep the original file name, even if the compatibility definitions
> >> are there. I don't see any harm in having them around as well.
> >>
> >
> > That's the part I was not sure about.
> > The goal of this patch (and the following ones) is to deprecate
> > v4l2_mbus_pixelcode enum and its values by adding a #warning when
> > v4l2-mediabus.h file is included, thus encouraging people to use new
> > definitions.
>
> Since v4l2-mediabus.h contains struct v4l2_mbus_framefmt this header remains
> a legal header, so you can't use #warning here in any case.
>
Actually this patch moves the struct v4l2_mbus_framefmt definition into
another header before adding the warning statement.
Anyway, this is really a detail, and if everybody agrees that we should
just leave the old definition in place, I'm fine with that.
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-11-05 15:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 9:54 [PATCH 00/15] [media] Make mediabus format subsystem neutral Boris Brezillon
2014-11-04 9:54 ` [PATCH 01/15] [media] Move mediabus format definition to a more standard place Boris Brezillon
2014-11-04 10:20 ` Hans Verkuil
2014-11-04 10:22 ` Hans Verkuil
2014-11-04 10:45 ` Boris Brezillon
2014-11-04 11:09 ` Hans Verkuil
2014-11-05 15:00 ` Sakari Ailus
2014-11-05 15:32 ` Boris Brezillon
2014-11-04 9:54 ` [PATCH 02/15] [media] v4l: Update subdev-formats doc with new MEDIA_BUS_FMT values Boris Brezillon
2014-11-05 14:57 ` Sakari Ailus
2014-11-05 15:01 ` Boris Brezillon
2014-11-04 9:54 ` [PATCH 03/15] [media] Make use of the new media_bus_format definitions Boris Brezillon
2014-11-05 15:19 ` Sakari Ailus
2014-11-04 9:54 ` [PATCH 04/15] [media] i2c: Make use of media_bus_format enum Boris Brezillon
2014-11-04 9:55 ` [PATCH 05/15] [media] pci: " Boris Brezillon
2014-11-04 9:55 ` [PATCH 06/15] [media] platform: " Boris Brezillon
2014-11-04 9:55 ` [PATCH 07/15] [media] usb: " Boris Brezillon
2014-11-04 9:55 ` [PATCH 08/15] staging: media: " Boris Brezillon
2014-11-04 9:55 ` [PATCH 09/15] gpu: ipu-v3: " Boris Brezillon
2014-11-04 9:55 ` [PATCH 10/15] [media] v4l: Forbid usage of V4L2_MBUS_FMT definitions inside the kernel Boris Brezillon
2014-11-04 9:55 ` [PATCH 11/15] [media] Deprecate v4l2_mbus_pixelcode Boris Brezillon
2014-11-05 15:08 ` Sakari Ailus
2014-11-05 15:15 ` Boris Brezillon
2014-11-05 15:19 ` Hans Verkuil
2014-11-05 15:30 ` Boris Brezillon [this message]
2014-11-05 15:34 ` Hans Verkuil
2014-11-05 15:22 ` Sakari Ailus
2014-11-04 9:55 ` [PATCH 12/15] [media] i2c: Replace v4l2-mediabus.h inclusion with v4l2-mbus.h Boris Brezillon
2014-11-04 9:55 ` [PATCH 13/15] gpu: ipu-v3: " Boris Brezillon
2014-11-04 9:55 ` [PATCH 14/15] [media] platform: " Boris Brezillon
2014-11-04 9:55 ` [PATCH 15/15] staging: media: " Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141105163049.65d02aff@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=devel@driverdev.osuosl.org \
--cc=g.liakhovetski@gmx.de \
--cc=hans.verkuil@cisco.com \
--cc=hansverk@cisco.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).