From: David Miller <davem@davemloft.net>
To: hayeswang@realtek.com
Cc: netdev@vger.kernel.org, nic_swsd@realtek.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] r8152: adjust rtl_start_rx
Date: Fri, 07 Nov 2014 11:35:22 -0500 (EST) [thread overview]
Message-ID: <20141107.113522.837502028522211960.davem@davemloft.net> (raw)
In-Reply-To: <1394712342-15778-90-Taiwan-albertk@realtek.com>
From: Hayes Wang <hayeswang@realtek.com>
Date: Fri, 7 Nov 2014 17:55:11 +0800
> Submit all the rx buffers, even though a error occurs. Otherwise
> the buffers which are not submitted would be lost until next
> rtl_start_rx() is called. Besides, the fail buffer could be
> re-submitted later.
>
> Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Does this even work?
If you leave a hole in the ring, the device is going to stop there
anyways.
So better to replenish the next time you call into this function
rather than leaving gaps in your receive ring.
next prev parent reply other threads:[~2014-11-07 16:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 9:55 [PATCH net-next 0/2] r8152: adjust rx functions Hayes Wang
2014-11-07 9:55 ` [PATCH net-next 1/2] r8152: adjust r8152_submit_rx Hayes Wang
2014-11-07 9:55 ` [PATCH net-next 2/2] r8152: adjust rtl_start_rx Hayes Wang
2014-11-07 16:35 ` David Miller [this message]
2014-11-10 3:29 ` Hayes Wang
2014-11-12 2:50 ` David Miller
2014-11-12 5:07 ` Hayes Wang
2014-11-12 5:13 ` David Miller
2014-11-12 5:23 ` Hayes Wang
2014-11-12 5:43 ` David Miller
2014-11-12 6:29 ` Hayes Wang
2014-11-12 19:49 ` David Miller
2014-11-13 2:31 ` Hayes Wang
2014-11-13 3:31 ` David Miller
2014-11-13 21:22 ` David Miller
2014-11-14 5:14 ` Hayes Wang
2014-11-12 1:45 ` Hayes Wang
2014-11-12 2:19 ` David Miller
2014-11-12 2:30 ` Hayes Wang
2014-11-19 5:20 ` [PATCH net-next v2 0/2] r8152: adjust rx functions Hayes Wang
2014-11-19 5:20 ` [PATCH net-next v2 1/2] r8152: adjust r8152_submit_rx Hayes Wang
2014-11-19 14:02 ` Sergei Shtylyov
2014-11-19 5:20 ` [PATCH net-next v2 2/2] r8152: adjust rtl_start_rx Hayes Wang
2014-11-20 2:29 ` [PATCH net-next v3 0/2] r8152: adjust rx functions Hayes Wang
2014-11-20 2:29 ` [PATCH net-next v3 1/2] r8152: adjust r8152_submit_rx Hayes Wang
2014-11-20 2:29 ` [PATCH net-next v3 2/2] r8152: adjust rtl_start_rx Hayes Wang
2014-11-21 19:53 ` [PATCH net-next v3 0/2] r8152: adjust rx functions David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141107.113522.837502028522211960.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).