From: David Miller <davem@davemloft.net>
To: hayeswang@realtek.com
Cc: netdev@vger.kernel.org, nic_swsd@realtek.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] r8152: adjust rtl_start_rx
Date: Thu, 13 Nov 2014 16:22:40 -0500 (EST) [thread overview]
Message-ID: <20141113.162240.1823683928052355016.davem@davemloft.net> (raw)
In-Reply-To: <20141112.223146.2221136950144767962.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Wed, 12 Nov 2014 22:31:46 -0500 (EST)
> From: Hayes Wang <hayeswang@realtek.com>
> Date: Thu, 13 Nov 2014 02:31:14 +0000
>
>> My last method which I mentioned yesterday is similar to
>> this one. The difference is that I would re-use the rx
>> buffers, so I have to add them to the list for re-submitting,
>> not alwayes allocate new one.
>>
>> Although one rx buffer could contain many packets, I don't
>> think the whole size of the rx buffer is alwayes used.
>> Therefore, I re-use the rx buffers to avoid allocating
>> the 16K bytes rx buffer alwayes. This also makes sure that
>> I always have the buffers to submit without allocating new
>> one.
>>
>> If you could accept this, I would modify this patch by
>> this way.
>
> I'll reread your original patch and think some more about this.
What if even the first r8152_submit_rx() fails? What ever will cause
any of these retries to trigger at all?
Second, why does your patch increment 'i' with 'i++;' in the error
break path? You should mark the first failed entry as unallocated
with actual_length == 0 and place it on the rx_done queue.
next prev parent reply other threads:[~2014-11-13 21:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 9:55 [PATCH net-next 0/2] r8152: adjust rx functions Hayes Wang
2014-11-07 9:55 ` [PATCH net-next 1/2] r8152: adjust r8152_submit_rx Hayes Wang
2014-11-07 9:55 ` [PATCH net-next 2/2] r8152: adjust rtl_start_rx Hayes Wang
2014-11-07 16:35 ` David Miller
2014-11-10 3:29 ` Hayes Wang
2014-11-12 2:50 ` David Miller
2014-11-12 5:07 ` Hayes Wang
2014-11-12 5:13 ` David Miller
2014-11-12 5:23 ` Hayes Wang
2014-11-12 5:43 ` David Miller
2014-11-12 6:29 ` Hayes Wang
2014-11-12 19:49 ` David Miller
2014-11-13 2:31 ` Hayes Wang
2014-11-13 3:31 ` David Miller
2014-11-13 21:22 ` David Miller [this message]
2014-11-14 5:14 ` Hayes Wang
2014-11-12 1:45 ` Hayes Wang
2014-11-12 2:19 ` David Miller
2014-11-12 2:30 ` Hayes Wang
2014-11-19 5:20 ` [PATCH net-next v2 0/2] r8152: adjust rx functions Hayes Wang
2014-11-19 5:20 ` [PATCH net-next v2 1/2] r8152: adjust r8152_submit_rx Hayes Wang
2014-11-19 14:02 ` Sergei Shtylyov
2014-11-19 5:20 ` [PATCH net-next v2 2/2] r8152: adjust rtl_start_rx Hayes Wang
2014-11-20 2:29 ` [PATCH net-next v3 0/2] r8152: adjust rx functions Hayes Wang
2014-11-20 2:29 ` [PATCH net-next v3 1/2] r8152: adjust r8152_submit_rx Hayes Wang
2014-11-20 2:29 ` [PATCH net-next v3 2/2] r8152: adjust rtl_start_rx Hayes Wang
2014-11-21 19:53 ` [PATCH net-next v3 0/2] r8152: adjust rx functions David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113.162240.1823683928052355016.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).