* [PATCH] ARM: dts: DRA7: Add aliases for all serial ports
@ 2014-10-21 16:18 Nishanth Menon
2014-10-21 19:57 ` Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Nishanth Menon @ 2014-10-21 16:18 UTC (permalink / raw)
To: Tony Lindgren
Cc: linux-kernel, linux-arm-kernel, devicetree, linux-omap,
Franklin Cooper Jr.,
Nishanth Menon
Add serial port aliases for consoles > 6.
Signed-off-by: Nishanth Menon <nm@ti.com>
---
arch/arm/boot/dts/dra7.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index 9cc9843..208dd83 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -34,6 +34,10 @@
serial3 = &uart4;
serial4 = &uart5;
serial5 = &uart6;
+ serial6 = &uart7;
+ serial7 = &uart8;
+ serial8 = &uart9;
+ serial9 = &uart10;
};
timer {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: DRA7: Add aliases for all serial ports
2014-10-21 16:18 [PATCH] ARM: dts: DRA7: Add aliases for all serial ports Nishanth Menon
@ 2014-10-21 19:57 ` Arnd Bergmann
2014-10-21 20:07 ` Nishanth Menon
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2014-10-21 19:57 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Nishanth Menon, Tony Lindgren, devicetree, linux-kernel,
linux-omap, Franklin Cooper Jr.
On Tuesday 21 October 2014 11:18:15 Nishanth Menon wrote:
> Add serial port aliases for consoles > 6.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> arch/arm/boot/dts/dra7.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index 9cc9843..208dd83 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -34,6 +34,10 @@
> serial3 = &uart4;
> serial4 = &uart5;
> serial5 = &uart6;
> + serial6 = &uart7;
> + serial7 = &uart8;
> + serial8 = &uart9;
> + serial9 = &uart10;
>
I think this was wrong to start with: The aliases should be in the per-board
.dts file and only list the ones that are actually connected to the outside.
Otherwise the numbering won't match what's written on the board.
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: DRA7: Add aliases for all serial ports
2014-10-21 19:57 ` Arnd Bergmann
@ 2014-10-21 20:07 ` Nishanth Menon
2014-11-10 23:49 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Nishanth Menon @ 2014-10-21 20:07 UTC (permalink / raw)
To: Arnd Bergmann, linux-arm-kernel
Cc: Tony Lindgren, devicetree, linux-kernel, linux-omap, Franklin Cooper Jr.
On 10/21/2014 02:57 PM, Arnd Bergmann wrote:
> On Tuesday 21 October 2014 11:18:15 Nishanth Menon wrote:
>> Add serial port aliases for consoles > 6.
>>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>> ---
>> arch/arm/boot/dts/dra7.dtsi | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
>> index 9cc9843..208dd83 100644
>> --- a/arch/arm/boot/dts/dra7.dtsi
>> +++ b/arch/arm/boot/dts/dra7.dtsi
>> @@ -34,6 +34,10 @@
>> serial3 = &uart4;
>> serial4 = &uart5;
>> serial5 = &uart6;
>> + serial6 = &uart7;
>> + serial7 = &uart8;
>> + serial8 = &uart9;
>> + serial9 = &uart10;
>>
>
> I think this was wrong to start with: The aliases should be in the per-board
> .dts file and only list the ones that are actually connected to the outside.
>
> Otherwise the numbering won't match what's written on the board.
At least in the case of DRA7 boards, they are not written specifically
since they come out over onboard FTDI usb2serial.
This will at least ensure that /dev/ttyO9 will always point to uart10
no matter the board, instead of having ttyO0 always pointing to
console serial port no matter the board (and having to guess which
figure out it actually was aliased to).
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: DRA7: Add aliases for all serial ports
2014-10-21 20:07 ` Nishanth Menon
@ 2014-11-10 23:49 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2014-11-10 23:49 UTC (permalink / raw)
To: Nishanth Menon
Cc: Arnd Bergmann, linux-arm-kernel, devicetree, linux-kernel,
linux-omap, Franklin Cooper Jr.
* Nishanth Menon <nm@ti.com> [141021 13:08]:
> On 10/21/2014 02:57 PM, Arnd Bergmann wrote:
> > On Tuesday 21 October 2014 11:18:15 Nishanth Menon wrote:
> >> Add serial port aliases for consoles > 6.
> >>
> >> Signed-off-by: Nishanth Menon <nm@ti.com>
> >> ---
> >> arch/arm/boot/dts/dra7.dtsi | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> >> index 9cc9843..208dd83 100644
> >> --- a/arch/arm/boot/dts/dra7.dtsi
> >> +++ b/arch/arm/boot/dts/dra7.dtsi
> >> @@ -34,6 +34,10 @@
> >> serial3 = &uart4;
> >> serial4 = &uart5;
> >> serial5 = &uart6;
> >> + serial6 = &uart7;
> >> + serial7 = &uart8;
> >> + serial8 = &uart9;
> >> + serial9 = &uart10;
> >>
> >
> > I think this was wrong to start with: The aliases should be in the per-board
> > .dts file and only list the ones that are actually connected to the outside.
> >
> > Otherwise the numbering won't match what's written on the board.
>
> At least in the case of DRA7 boards, they are not written specifically
> since they come out over onboard FTDI usb2serial.
>
> This will at least ensure that /dev/ttyO9 will always point to uart10
> no matter the board, instead of having ttyO0 always pointing to
> console serial port no matter the board (and having to guess which
> figure out it actually was aliased to).
It seems that having the UART numbering make sense is a good reason
to apply this one. So applying into omap-for-v3.19/dt.
Regards,
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-10 23:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-21 16:18 [PATCH] ARM: dts: DRA7: Add aliases for all serial ports Nishanth Menon
2014-10-21 19:57 ` Arnd Bergmann
2014-10-21 20:07 ` Nishanth Menon
2014-11-10 23:49 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).