* [PATCH] HIS: nokia-modem: fix error handling of irq_of_parse_and_map
@ 2014-11-14 22:06 Dmitry Torokhov
2014-11-14 22:44 ` Sebastian Reichel
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2014-11-14 22:06 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: Pavel Machek, Michael Opdenacker, linux-kernel
Return value of irq_of_parse_and_map() is unsigned int, with 0
indicating failure, so testing for negative result never works.
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
---
Not tested, found by casual code inspection.
drivers/hsi/clients/nokia-modem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hsi/clients/nokia-modem.c b/drivers/hsi/clients/nokia-modem.c
index e43c3c9..32cc9af 100644
--- a/drivers/hsi/clients/nokia-modem.c
+++ b/drivers/hsi/clients/nokia-modem.c
@@ -164,9 +164,9 @@ static int nokia_modem_probe(struct device *dev)
dev_set_drvdata(dev, modem);
irq = irq_of_parse_and_map(np, 0);
- if (irq < 0) {
+ if (!irq) {
dev_err(dev, "Invalid rst_ind interrupt (%d)\n", irq);
- return irq;
+ return -EINVAL;
}
modem->nokia_modem_rst_ind_irq = irq;
pflags = irq_get_trigger_type(irq);
--
2.1.0.rc2.206.gedb03e5
--
Dmitry
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] HIS: nokia-modem: fix error handling of irq_of_parse_and_map
2014-11-14 22:06 [PATCH] HIS: nokia-modem: fix error handling of irq_of_parse_and_map Dmitry Torokhov
@ 2014-11-14 22:44 ` Sebastian Reichel
2014-11-16 8:37 ` Pavel Machek
0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Reichel @ 2014-11-14 22:44 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Pavel Machek, Michael Opdenacker, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 402 bytes --]
On Fri, Nov 14, 2014 at 02:06:37PM -0800, Dmitry Torokhov wrote:
> Return value of irq_of_parse_and_map() is unsigned int, with 0
> indicating failure, so testing for negative result never works.
>
> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
https://git.kernel.org/cgit/linux/kernel/git/sre/linux-hsi.git/commit/?h=for-next&id=d95dc9e388104488d0f5a5969c435e601840da2e
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] HIS: nokia-modem: fix error handling of irq_of_parse_and_map
2014-11-14 22:44 ` Sebastian Reichel
@ 2014-11-16 8:37 ` Pavel Machek
0 siblings, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2014-11-16 8:37 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: Dmitry Torokhov, Michael Opdenacker, linux-kernel
On Fri 2014-11-14 23:44:07, Sebastian Reichel wrote:
> On Fri, Nov 14, 2014 at 02:06:37PM -0800, Dmitry Torokhov wrote:
> > Return value of irq_of_parse_and_map() is unsigned int, with 0
> > indicating failure, so testing for negative result never works.
> >
> > Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
>
> https://git.kernel.org/cgit/linux/kernel/git/sre/linux-hsi.git/commit/?h=for-next&id=d95dc9e388104488d0f5a5969c435e601840da2e
>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-16 8:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-14 22:06 [PATCH] HIS: nokia-modem: fix error handling of irq_of_parse_and_map Dmitry Torokhov
2014-11-14 22:44 ` Sebastian Reichel
2014-11-16 8:37 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).