linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Thermal: fix platform_no_drv_owner.cocci warnings
       [not found] <201411161721.jEzvtBAi%fengguang.wu@intel.com>
@ 2014-11-17  6:24 ` Fengguang Wu
  2014-11-17  7:57   ` Zhang Rui
  0 siblings, 1 reply; 5+ messages in thread
From: Fengguang Wu @ 2014-11-17  6:24 UTC (permalink / raw)
  To: linux-pm; +Cc: Lan Tianyu, Zhang Rui, LKML

drivers/thermal/int340x_thermal/int3403_thermal.c:468:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 int3403_thermal.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/thermal/int340x_thermal/int3403_thermal.c
+++ b/drivers/thermal/int340x_thermal/int3403_thermal.c
@@ -465,7 +465,6 @@ static struct platform_driver int3403_dr
 	.remove = int3403_remove,
 	.driver = {
 		.name = "int3403 thermal",
-		.owner  = THIS_MODULE,
 		.acpi_match_table = int3403_device_ids,
 	},
 };

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Thermal: fix platform_no_drv_owner.cocci warnings
  2014-11-17  6:24 ` [PATCH] Thermal: fix platform_no_drv_owner.cocci warnings Fengguang Wu
@ 2014-11-17  7:57   ` Zhang Rui
  0 siblings, 0 replies; 5+ messages in thread
From: Zhang Rui @ 2014-11-17  7:57 UTC (permalink / raw)
  To: Fengguang Wu; +Cc: linux-pm, Lan Tianyu, LKML

On 一, 2014-11-17 at 14:24 +0800, Fengguang Wu wrote:
> drivers/thermal/int340x_thermal/int3403_thermal.c:468:3-8: No need to set .owner here. The core will do it.
> 
>  Remove .owner field if calls are used which set it automatically
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Acked-by: Zhang Rui <rui.zhang@intel.com>

thanks,
rui
> ---
> 
>  int3403_thermal.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- a/drivers/thermal/int340x_thermal/int3403_thermal.c
> +++ b/drivers/thermal/int340x_thermal/int3403_thermal.c
> @@ -465,7 +465,6 @@ static struct platform_driver int3403_dr
>  	.remove = int3403_remove,
>  	.driver = {
>  		.name = "int3403 thermal",
> -		.owner  = THIS_MODULE,
>  		.acpi_match_table = int3403_device_ids,
>  	},
>  };



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] thermal: fix platform_no_drv_owner.cocci warnings
  2017-06-05 21:09 ` Markus Mayer
@ 2017-06-06  7:50   ` kbuild test robot
  0 siblings, 0 replies; 5+ messages in thread
From: kbuild test robot @ 2017-06-06  7:50 UTC (permalink / raw)
  To: Markus Mayer
  Cc: kbuild-all, Zhang Rui, Eduardo Valentin, Rob Herring,
	Mark Rutland, Doug Berger, Brian Norris, Gregory Fong,
	Florian Fainelli, Rafał Miłecki, Broadcom Kernel List,
	Power Management List, Device Tree List, ARM Kernel List,
	Linux Kernel Mailing List, Markus Mayer

drivers/thermal/broadcom/brcmstb_thermal.c:353:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Brian Norris <computersforpeace@gmail.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 brcmstb_thermal.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/thermal/broadcom/brcmstb_thermal.c
+++ b/drivers/thermal/broadcom/brcmstb_thermal.c
@@ -350,7 +350,6 @@ static struct platform_driver brcmstb_th
 	.remove = brcmstb_thermal_exit,
 	.driver = {
 		.name = DRV_NAME,
-		.owner = THIS_MODULE,
 		.of_match_table = brcmstb_thermal_id_table,
 	},
 };

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Thermal: fix platform_no_drv_owner.cocci warnings
  2014-12-21 14:21 ` kbuild test robot
@ 2014-12-22  1:54   ` Aaron Lu
  0 siblings, 0 replies; 5+ messages in thread
From: Aaron Lu @ 2014-12-22  1:54 UTC (permalink / raw)
  To: kbuild test robot
  Cc: kbuild-all, Zhang Rui, Eduardo Valentin, linux-pm, linux-kernel

On 12/21/2014 10:21 PM, kbuild test robot wrote:
> drivers/thermal/int340x_thermal/int3402_thermal.c:234:6-11: No need to set .owner here. The core will do it.
> 
>  Remove .owner field if calls are used which set it automatically
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> 
> CC: Aaron Lu <aaron.lu@intel.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Looks good to me, thanks!

-Aaron

> ---
> 
>  int3402_thermal.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- a/drivers/thermal/int340x_thermal/int3402_thermal.c
> +++ b/drivers/thermal/int340x_thermal/int3402_thermal.c
> @@ -231,7 +231,6 @@ static struct platform_driver int3402_th
>  	.remove = int3402_thermal_remove,
>  	.driver = {
>  		   .name = "int3402 thermal",
> -		   .owner = THIS_MODULE,
>  		   .acpi_match_table = int3402_thermal_match,
>  		   },
>  };
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] Thermal: fix platform_no_drv_owner.cocci warnings
       [not found] <201412212210.5BfVGAAA%fengguang.wu@intel.com>
@ 2014-12-21 14:21 ` kbuild test robot
  2014-12-22  1:54   ` Aaron Lu
  0 siblings, 1 reply; 5+ messages in thread
From: kbuild test robot @ 2014-12-21 14:21 UTC (permalink / raw)
  To: Aaron Lu; +Cc: kbuild-all, Zhang Rui, Eduardo Valentin, linux-pm, linux-kernel

drivers/thermal/int340x_thermal/int3402_thermal.c:234:6-11: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Aaron Lu <aaron.lu@intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 int3402_thermal.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/thermal/int340x_thermal/int3402_thermal.c
+++ b/drivers/thermal/int340x_thermal/int3402_thermal.c
@@ -231,7 +231,6 @@ static struct platform_driver int3402_th
 	.remove = int3402_thermal_remove,
 	.driver = {
 		   .name = "int3402 thermal",
-		   .owner = THIS_MODULE,
 		   .acpi_match_table = int3402_thermal_match,
 		   },
 };

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-06-06  7:52 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <201411161721.jEzvtBAi%fengguang.wu@intel.com>
2014-11-17  6:24 ` [PATCH] Thermal: fix platform_no_drv_owner.cocci warnings Fengguang Wu
2014-11-17  7:57   ` Zhang Rui
     [not found] <201412212210.5BfVGAAA%fengguang.wu@intel.com>
2014-12-21 14:21 ` kbuild test robot
2014-12-22  1:54   ` Aaron Lu
2017-06-06  7:50 [PATCH 2/2] thermal: add brcmstb AVS TMON driver kbuild test robot
2017-06-05 21:09 ` Markus Mayer
2017-06-06  7:50   ` [PATCH] thermal: fix platform_no_drv_owner.cocci warnings kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).