From: "Pali Rohár" <pali.rohar@gmail.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Tony Lindgren <tony@atomide.com>, Pavel Machek <pavel@ucw.cz>,
sre@debian.org, sre@ring0.de,
kernel list <linux-kernel@vger.kernel.org>,
"linux-arm-kernel" <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, khilman@kernel.org,
aaro.koskinen@iki.fi, freemangordon@abv.bg,
bcousson@baylibre.com, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, devicetree@vger.kernel.org,
linux-media@vger.kernel.org,
Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
freemangordon@abv.bg
Subject: Re: [RFC] adp1653: Add device tree bindings for LED controller
Date: Mon, 17 Nov 2014 16:15:19 +0100 [thread overview]
Message-ID: <201411171615.34822@pali> (raw)
In-Reply-To: <20141117150407.GP8907@valkosipuli.retiisi.org.uk>
[-- Attachment #1: Type: Text/Plain, Size: 3032 bytes --]
On Monday 17 November 2014 16:04:07 Sakari Ailus wrote:
> Hi Pali,
>
> On Mon, Nov 17, 2014 at 04:01:31PM +0100, Pali Rohár wrote:
> > On Monday 17 November 2014 15:55:46 Tony Lindgren wrote:
> > > * Pavel Machek <pavel@ucw.cz> [141117 02:17]:
> > > > On Mon 2014-11-17 11:09:45, Pali Rohár wrote:
> > > > > On Monday 17 November 2014 11:05:19 Pavel Machek wrote:
> > > > > > Hi!
> > > > > >
> > > > > > On Mon 2014-11-17 09:43:19, Pali Rohár wrote:
> > > > > > > On Sunday 16 November 2014 08:59:28 Pavel Machek
wrote:
> > > > > > > > For device tree people: Yes, I know I'll have to
> > > > > > > > create file in documentation, but does the
> > > > > > > > binding below look acceptable?
> > > > > > > >
> > > > > > > > I'll clean up driver code a bit more, remove the
> > > > > > > > printks. Anything else obviously wrong?
> > > > > > >
> > > > > > > I think that this patch is probably not good and
> > > > > > > specially not for n900. adp1653 should be
> > > > > > > registered throw omap3 isp camera subsystem which
> > > > > > > does not have DT support yet.
> > > > > >
> > > > > > Can you explain?
> > > > > >
> > > > > > adp1653 is independend device on i2c bus, and we
> > > > > > have kernel driver for it (unlike rest of n900
> > > > > > camera system). Just now it is unusable due to lack
> > > > > > of DT binding. It has two functions, LED light and
> > > > > > a camera flash; yes, the second one should be
> > > > > > integrated to the rest of camera system, but that
> > > > > > is not yet merged. That should not prevent us from
> > > > > > merging DT support for the flash, so that this part
> > > > > > can be tested/maintained.
> > > > >
> > > > > Ok. When ISP camera subsystem has DT support somebody
> > > > > will modify n900 DT to add camera flash from adp1653
> > > > > to ISP... I believe it will not be hard.
> > > >
> > > > Exactly. And yes, I'd like to get complete camera
> > > > support for n900 merged. But first step is "make sure
> > > > existing support does not break".
> > >
> > > There's nothing stopping us from initializing the camera
> > > code from pdata-quirks.c for now to keep it working.
> > > Certainly the binding should be added to the driver, but
> > > that removes a dependency to the legacy booting mode if
> > > things are otherwise working.
> > >
> > > Regards,
> > >
> > > Tony
> >
> > Tony, legacy board code for n900 is not in mainline tree.
> > And that omap3 camera subsystem for n900 is broken since
> > 3.5 kernel... (both Front and Back camera on n900 show only
> > green picture).
>
> Can you capture raw bayer images correctly? I assume green
> means YUV buffers that are all zero.
>
> Do you know more specifically which patch breaks it?
CCing freemangordon (Ivaylo Dimitrov). He tried to debug it
months ago but without success. Should know more info about this
problem.
I think that commit which broke it was not bisected...
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2014-11-17 15:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-16 7:59 [RFC] adp1653: Add device tree bindings for LED controller Pavel Machek
2014-11-16 8:11 ` Lars-Peter Clausen
2014-11-16 8:43 ` Pavel Machek
2014-11-16 10:09 ` Andreas Färber
2014-11-16 10:15 ` Pavel Machek
2014-11-17 8:43 ` Pali Rohár
2014-11-17 10:05 ` Pavel Machek
2014-11-17 10:09 ` Pali Rohár
2014-11-17 10:15 ` Pavel Machek
2014-11-17 14:55 ` Tony Lindgren
2014-11-17 15:01 ` Pali Rohár
2014-11-17 15:04 ` Sakari Ailus
2014-11-17 15:15 ` Pali Rohár [this message]
2014-11-22 18:45 ` Ivaylo Dimitrov
2014-11-17 15:06 ` Tony Lindgren
2014-11-17 15:21 ` Pali Rohár
2014-11-18 18:35 ` Pavel Machek
2014-11-19 18:01 ` Sakari Ailus
2014-11-17 14:58 ` Sakari Ailus
2014-11-18 8:09 ` Jacek Anaszewski
2014-11-18 8:46 ` Pavel Machek
2014-11-18 10:04 ` Jacek Anaszewski
2014-11-18 11:32 ` Pavel Machek
2014-11-18 12:52 ` Jacek Anaszewski
2014-11-18 13:21 ` Pavel Machek
2014-11-18 16:02 ` Jacek Anaszewski
2014-11-18 16:51 ` Pavel Machek
2014-11-19 9:45 ` Jacek Anaszewski
2014-11-19 17:53 ` Sakari Ailus
2014-11-20 9:21 ` Jacek Anaszewski
2014-11-20 12:13 ` Pavel Machek
2014-11-20 12:12 ` Pavel Machek
2014-11-20 12:48 ` Jacek Anaszewski
2014-11-20 12:38 ` Jacek Anaszewski
2014-11-18 8:50 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201411171615.34822@pali \
--to=pali.rohar@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=freemangordon@abv.bg \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=sre@debian.org \
--cc=sre@ring0.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).