From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Sakari Ailus <sakari.ailus@iki.fi>,
pali.rohar@gmail.com, sre@debian.org, sre@ring0.de,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org,
aaro.koskinen@iki.fi, freemangordon@abv.bg,
bcousson@baylibre.com, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, devicetree@vger.kernel.org,
linux-media@vger.kernel.org,
Linux LED Subsystem <linux-leds@vger.kernel.org>
Subject: Re: [RFC] adp1653: Add device tree bindings for LED controller
Date: Thu, 20 Nov 2014 13:12:02 +0100 [thread overview]
Message-ID: <20141120121202.GA27527@amd> (raw)
In-Reply-To: <546C66A5.6060201@samsung.com>
Hi!
> I would also swap the segments of a property name to follow the convention
> as in case of "regulator-max-microamp".
>
> Updated version:
>
> ==========================================================
>
> Optional properties for child nodes:
> - max-microamp : maximum intensity in microamperes of the LED
> (torch LED for flash devices)
> - flash-max-microamp : maximum intensity in microamperes of the
> flash LED; it is mandatory if the led should
> support the flash mode
> - flash-timeout-microsec : timeout in microseconds after which the flash
> led is turned off
Works for me. Do you want to submit a patch or should I do it?
> - indicator-pattern : identifier of the blinking pattern for the
> indicator led
>
This would need a bit more documentation, no?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-11-20 12:12 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-16 7:59 [RFC] adp1653: Add device tree bindings for LED controller Pavel Machek
2014-11-16 8:11 ` Lars-Peter Clausen
2014-11-16 8:43 ` Pavel Machek
2014-11-16 10:09 ` Andreas Färber
2014-11-16 10:15 ` Pavel Machek
2014-11-17 8:43 ` Pali Rohár
2014-11-17 10:05 ` Pavel Machek
2014-11-17 10:09 ` Pali Rohár
2014-11-17 10:15 ` Pavel Machek
2014-11-17 14:55 ` Tony Lindgren
2014-11-17 15:01 ` Pali Rohár
2014-11-17 15:04 ` Sakari Ailus
2014-11-17 15:15 ` Pali Rohár
2014-11-22 18:45 ` Ivaylo Dimitrov
2014-11-17 15:06 ` Tony Lindgren
2014-11-17 15:21 ` Pali Rohár
2014-11-18 18:35 ` Pavel Machek
2014-11-19 18:01 ` Sakari Ailus
2014-11-17 14:58 ` Sakari Ailus
2014-11-18 8:09 ` Jacek Anaszewski
2014-11-18 8:46 ` Pavel Machek
2014-11-18 10:04 ` Jacek Anaszewski
2014-11-18 11:32 ` Pavel Machek
2014-11-18 12:52 ` Jacek Anaszewski
2014-11-18 13:21 ` Pavel Machek
2014-11-18 16:02 ` Jacek Anaszewski
2014-11-18 16:51 ` Pavel Machek
2014-11-19 9:45 ` Jacek Anaszewski
2014-11-19 17:53 ` Sakari Ailus
2014-11-20 9:21 ` Jacek Anaszewski
2014-11-20 12:13 ` Pavel Machek
2014-11-20 12:12 ` Pavel Machek [this message]
2014-11-20 12:48 ` Jacek Anaszewski
2014-11-20 12:38 ` Jacek Anaszewski
2014-11-18 8:50 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141120121202.GA27527@amd \
--to=pavel@ucw.cz \
--cc=aaro.koskinen@iki.fi \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=freemangordon@abv.bg \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=j.anaszewski@samsung.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pali.rohar@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=sre@debian.org \
--cc=sre@ring0.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).