From: Shawn Guo <shawn.guo@linaro.org>
To: Sanchayan Maity <maitysanchayan@gmail.com>
Cc: Stefan Agner <stefan@agner.ch>,
rtc-linux@googlegroups.com, linux@arm.linux.org.uk,
kernel@pengutronix.de, b35083@freescale.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [[PATCHv2] 3/3] drivers/rtc/rtc-snvs: Add clock support
Date: Wed, 19 Nov 2014 09:17:31 +0800 [thread overview]
Message-ID: <20141119011721.GA24042@dragon> (raw)
In-Reply-To: <54644295.2050003@gmail.com>
On Thu, Nov 13, 2014 at 11:03:09AM +0530, Sanchayan Maity wrote:
> On Wednesday 12 November 2014 04:17 PM, Shawn Guo wrote:
> > On Wed, Nov 12, 2014 at 02:26:51PM +0530, Sanchayan Maity wrote:
> >> On Wednesday 12 November 2014 02:57 AM, Stefan Agner wrote:
> >>> On 2014-11-07 14:04, Sanchayan Maity wrote:
> >>>> This patch adds clock enable and disable support for
> >>>> the SNVS peripheral, which is required for using the
> >>>> RTC within the SNVS block.
> >>>
> >>> What happens if the device tree node is there while this patch is not
> >>> applied? I guess the driver would load, but since the clocks of the
> >>> peripheral are not enabled the first register access would lead to bus
> >>> error or similar. If this is the case, this would break bisectability.
> >>> You should move the device tree patch to the end.
> >>>
> >>
> >> If the DT node was present with this patch not applied, the driver would
> >> still crash with a bus error, since the clocks for SNVS are not explicitly
> >> enabled anywhere else. I had not thought about any problems which might
> >> occur later with git bisect. Will move this to the end with v3.
> >
> > Since changes on rtc-snvs.c will need to go through RTC subsystem tree,
> > that means I cannot apply DTS changes until the driver patch gets
> > mainlined and appears on my tree.
> >
> > Shawn
>
> Shawn
>
> So the approach in this patch is OK and acceptable?
Yes, I'm fine with it.
Shawn
>
> Since the DT changes cannot be applied by you, till this goes through the
> RTC subsystem tree, gets mainlined and appears on your tree, I will send out
> this patch by itself then and send the DT changes later once this gets
> mainlined?
>
> I did not CC Alessandro Zummo, the maintainer of RTC subsystem by mistake.
> Once you ACK/OK this i will send out this patch in isolation then or just
> CC Alessandro Zummo.
next prev parent reply other threads:[~2014-11-19 1:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 13:04 [[PATCHv2] 0/3] Add SNVS clock gating and clock support to rtc-snvs driver Sanchayan Maity
2014-11-07 13:04 ` [[PATCHv2] 1/3] ARM: imx: clk-vf610: Add clock for SNVS Sanchayan Maity
2014-11-11 14:49 ` Shawn Guo
2014-11-11 20:58 ` Stefan Agner
2014-11-11 21:13 ` Stefan Agner
2014-11-07 13:04 ` [[PATCHv2] 2/3] ARM: dts: vfxxx: Add SNVS node Sanchayan Maity
2014-11-11 21:20 ` Stefan Agner
2014-11-12 8:46 ` Sanchayan Maity
2014-11-07 13:04 ` [[PATCHv2] 3/3] drivers/rtc/rtc-snvs: Add clock support Sanchayan Maity
2014-11-11 21:27 ` Stefan Agner
2014-11-12 8:56 ` Sanchayan Maity
2014-11-12 10:47 ` Shawn Guo
2014-11-13 5:33 ` Sanchayan Maity
2014-11-19 1:17 ` Shawn Guo [this message]
2014-11-19 4:49 ` Sanchayan Maity
2014-11-28 4:27 ` Sanchayan Maity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141119011721.GA24042@dragon \
--to=shawn.guo@linaro.org \
--cc=b35083@freescale.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=maitysanchayan@gmail.com \
--cc=rtc-linux@googlegroups.com \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).