From: Stefan Agner <stefan@agner.ch>
To: Sanchayan Maity <maitysanchayan@gmail.com>
Cc: rtc-linux@googlegroups.com, shawn.guo@linaro.org,
linux@arm.linux.org.uk, kernel@pengutronix.de,
b35083@freescale.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [[PATCHv2] 1/3] ARM: imx: clk-vf610: Add clock for SNVS
Date: Tue, 11 Nov 2014 22:13:44 +0100 [thread overview]
Message-ID: <9a79e6b3c1c62037cef31baa432fd874@agner.ch> (raw)
In-Reply-To: <bbe86ff8ff7461451be5c53242842e966bfd3966.1415364391.git.maitysanchayan@gmail.com>
On 2014-11-07 14:04, Sanchayan Maity wrote:
> This patch adds support for clock gating of
> the SNVS peripheral.
>
> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> ---
> arch/arm/mach-imx/clk-vf610.c | 1 +
> include/dt-bindings/clock/vf610-clock.h | 3 ++-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-imx/clk-vf610.c b/arch/arm/mach-imx/clk-vf610.c
> index 5937dde..bbf4785 100644
> --- a/arch/arm/mach-imx/clk-vf610.c
> +++ b/arch/arm/mach-imx/clk-vf610.c
> @@ -379,6 +379,7 @@ static void __init vf610_clocks_init(struct
> device_node *ccm_node)
> clk[VF610_CLK_DMAMUX1] = imx_clk_gate2("dmamux1", "platform_bus",
> CCM_CCGR0, CCM_CCGRx_CGn(5));
> clk[VF610_CLK_DMAMUX2] = imx_clk_gate2("dmamux2", "platform_bus",
> CCM_CCGR6, CCM_CCGRx_CGn(1));
> clk[VF610_CLK_DMAMUX3] = imx_clk_gate2("dmamux3", "platform_bus",
> CCM_CCGR6, CCM_CCGRx_CGn(2));
> + clk[VF610_CLK_SNVS] = imx_clk_gate2("snvs-rtc", "ipg_bus",
> CCM_CCGR6, CCM_CCGRx_CGn(7));
Just noticed that imx_clk_gate2 always sets both gates. This means, the
RTC will be gated when going into low power modes. We might need to use
a different gating when we want to use the RTC as wakeup source. But
this would be part of the suspend/resume patchset...
>
> imx_check_clocks(clk, ARRAY_SIZE(clk));
>
> diff --git a/include/dt-bindings/clock/vf610-clock.h
> b/include/dt-bindings/clock/vf610-clock.h
> index 801c0ac..979d24a 100644
> --- a/include/dt-bindings/clock/vf610-clock.h
> +++ b/include/dt-bindings/clock/vf610-clock.h
> @@ -192,6 +192,7 @@
> #define VF610_PLL5_BYPASS 179
> #define VF610_PLL6_BYPASS 180
> #define VF610_PLL7_BYPASS 181
> -#define VF610_CLK_END 182
> +#define VF610_CLK_SNVS 182
> +#define VF610_CLK_END 183
>
> #endif /* __DT_BINDINGS_CLOCK_VF610_H */
Acked-By: Stefan Agner <stefan@agner.ch>
--
Stefan
next prev parent reply other threads:[~2014-11-11 21:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 13:04 [[PATCHv2] 0/3] Add SNVS clock gating and clock support to rtc-snvs driver Sanchayan Maity
2014-11-07 13:04 ` [[PATCHv2] 1/3] ARM: imx: clk-vf610: Add clock for SNVS Sanchayan Maity
2014-11-11 14:49 ` Shawn Guo
2014-11-11 20:58 ` Stefan Agner
2014-11-11 21:13 ` Stefan Agner [this message]
2014-11-07 13:04 ` [[PATCHv2] 2/3] ARM: dts: vfxxx: Add SNVS node Sanchayan Maity
2014-11-11 21:20 ` Stefan Agner
2014-11-12 8:46 ` Sanchayan Maity
2014-11-07 13:04 ` [[PATCHv2] 3/3] drivers/rtc/rtc-snvs: Add clock support Sanchayan Maity
2014-11-11 21:27 ` Stefan Agner
2014-11-12 8:56 ` Sanchayan Maity
2014-11-12 10:47 ` Shawn Guo
2014-11-13 5:33 ` Sanchayan Maity
2014-11-19 1:17 ` Shawn Guo
2014-11-19 4:49 ` Sanchayan Maity
2014-11-28 4:27 ` Sanchayan Maity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a79e6b3c1c62037cef31baa432fd874@agner.ch \
--to=stefan@agner.ch \
--cc=b35083@freescale.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=maitysanchayan@gmail.com \
--cc=rtc-linux@googlegroups.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).