From: Johan Hovold <johan@kernel.org>
To: Laurentiu Palcu <laurentiu.palcu@intel.com>
Cc: Mark Brown <broonie@kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>, Johan Havold <johan@kernel.org>,
Octavian Purdila <octavian.purdila@intel.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/2] spi: add support for DLN-2 USB-SPI adapter
Date: Wed, 19 Nov 2014 14:51:21 +0100 [thread overview]
Message-ID: <20141119135121.GF7857@localhost> (raw)
In-Reply-To: <1416402467-26999-1-git-send-email-laurentiu.palcu@intel.com>
On Wed, Nov 19, 2014 at 03:07:47PM +0200, Laurentiu Palcu wrote:
> +/*
> + * Perform one read operation.
> + */
> +static int dln2_spi_read_one(struct dln2_spi *dln2, u8 *data,
> + u16 data_len, u8 attr)
> +{
> + int ret;
> + struct {
> + u8 port;
> + __le16 size;
> + u8 attr;
> + } __packed tx;
> + struct {
> + __le16 size;
> + u8 buf[DLN2_SPI_MAX_XFER_SIZE];
> + } __packed *rx = dln2->buf;
You said you verified that the dln2 protocol headers did not mess up the
alignment, yet they do. Here you have a two byte header.
> + unsigned rx_len = sizeof(*rx);
> +
> + BUILD_BUG_ON(sizeof(*rx) > DLN2_SPI_BUF_SIZE);
> +
> + if (data_len > DLN2_SPI_MAX_XFER_SIZE)
> + return -EINVAL;
> +
> + tx.port = dln2->port;
> + tx.size = cpu_to_le16(data_len);
> + tx.attr = attr;
> +
> + ret = dln2_transfer(dln2->pdev, DLN2_SPI_READ, &tx, sizeof(tx),
> + rx, &rx_len);
> + if (ret < 0)
> + return ret;
> + if (rx_len < sizeof(rx->size) + data_len)
> + return -EPROTO;
> + if (le16_to_cpu(rx->size) != data_len)
> + return -EPROTO;
> +
> + dln2_spi_copy_from_buf(data, rx->buf, data_len, dln2->bpw);
So you need to use the unaligned macros in dln2_spi_copy_from_buf for
rx->buf (at least for bpw 32).
Make sure to document why.
> +
> + return 0;
> +}
> +
> +/*
> + * Perform one write & read operation.
> + */
> +static int dln2_spi_read_write_one(struct dln2_spi *dln2, const u8 *tx_data,
> + u8 *rx_data, u16 data_len, u8 attr)
> +{
> + int ret;
> + struct {
> + u8 port;
> + __le16 size;
> + u8 attr;
> + u8 buf[DLN2_SPI_MAX_XFER_SIZE];
> + } __packed *tx;
tx is ok.
> + struct {
> + __le16 size;
> + u8 buf[DLN2_SPI_MAX_XFER_SIZE];
> + } __packed *rx;
But here you have the same two-byte header.
Johan
next prev parent reply other threads:[~2014-11-19 13:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 12:09 [PATCH v3 0/2] Add SPI support for Diolan DLN2 Laurentiu Palcu
2014-11-18 12:09 ` [PATCH v3 1/2] spi: add support for DLN-2 USB-SPI adapter Laurentiu Palcu
2014-11-18 17:06 ` Johan Hovold
2014-11-19 9:53 ` Laurentiu Palcu
2014-11-19 10:09 ` Johan Hovold
2014-11-19 10:47 ` [PATCH v4 " Laurentiu Palcu
2014-11-19 12:21 ` Johan Hovold
2014-11-19 13:07 ` [PATCH v5 " Laurentiu Palcu
2014-11-19 13:51 ` Johan Hovold [this message]
2014-11-19 14:12 ` Laurentiu Palcu
2014-11-26 10:09 ` [PATCH v6 " Laurentiu Palcu
2014-11-26 18:25 ` Mark Brown
2014-11-27 10:30 ` Laurentiu Palcu
2014-11-28 13:09 ` [PATCH v7 " Laurentiu Palcu
2014-11-28 14:10 ` Mark Brown
2014-11-28 14:57 ` Laurentiu Palcu
2014-11-28 15:14 ` Mark Brown
2014-11-28 15:31 ` Laurentiu Palcu
2014-11-28 16:01 ` Mark Brown
2014-11-28 18:13 ` Laurentiu Palcu
2014-11-28 18:35 ` Mark Brown
2014-11-28 19:27 ` Laurentiu Palcu
2014-11-28 19:46 ` Mark Brown
2014-11-28 19:21 ` Octavian Purdila
2014-12-05 18:34 ` Mark Brown
2014-11-18 12:09 ` [PATCH v3 2/2] mfd: dln2: add support for USB-SPI module Laurentiu Palcu
2014-11-19 16:29 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141119135121.GF7857@localhost \
--to=johan@kernel.org \
--cc=broonie@kernel.org \
--cc=laurentiu.palcu@intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=octavian.purdila@intel.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).