From: Mark Brown <broonie@kernel.org>
To: Laurentiu Palcu <laurentiu.palcu@intel.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>, Johan Havold <johan@kernel.org>,
Octavian Purdila <octavian.purdila@intel.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/2] spi: add support for DLN-2 USB-SPI adapter
Date: Wed, 26 Nov 2014 18:25:21 +0000 [thread overview]
Message-ID: <20141126182521.GP7712@sirena.org.uk> (raw)
In-Reply-To: <1416996549-29328-1-git-send-email-laurentiu.palcu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1383 bytes --]
On Wed, Nov 26, 2014 at 12:09:09PM +0200, Laurentiu Palcu wrote:
> +static int dln2_spi_transfer_one_message(struct spi_master *master,
> + struct spi_message *msg)
> +{
> + struct dln2_spi *dln2 = spi_master_get_devdata(master);
> + struct spi_device *spi = msg->spi;
> + struct spi_transfer *xfer;
> + int status;
> +
> + list_for_each_entry(xfer, &msg->transfers, transfer_list) {
> + u8 attr = 0;
> +
> + status = dln2_spi_transfer_setup(dln2, xfer->speed_hz,
> + xfer->bits_per_word,
> + spi->mode);
> + if (status < 0) {
> + dev_err(&dln2->pdev->dev, "Cannot setup transfer\n");
> + break;
> + }
> +
> + if (!xfer->cs_change &&
> + !list_is_last(&xfer->transfer_list, &msg->transfers))
> + attr = xfer->cs_change ? 0 : DLN2_SPI_ATTR_LEAVE_SS_LOW;
> +
> + status = dln2_spi_rdwr(dln2, xfer->tx_buf, xfer->rx_buf,
> + xfer->len, attr);
We recently added a spi_transfer_is_last() operation which should allow
you to move this to using transfer_one() which is a bit nicer.
> + /* enable SPI module, we're good to go */
> + ret = dln2_spi_enable(dln2, true);
> + if (ret < 0) {
> + dev_err(&pdev->dev, "Failed to enable SPI module\n");
> + goto exit_free_master;
> + }
It would be nice to have runtime PM operations which keep the device
disabled when idle, presumably that'd save a bit of power and it's
generally better practice.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-11-26 18:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 12:09 [PATCH v3 0/2] Add SPI support for Diolan DLN2 Laurentiu Palcu
2014-11-18 12:09 ` [PATCH v3 1/2] spi: add support for DLN-2 USB-SPI adapter Laurentiu Palcu
2014-11-18 17:06 ` Johan Hovold
2014-11-19 9:53 ` Laurentiu Palcu
2014-11-19 10:09 ` Johan Hovold
2014-11-19 10:47 ` [PATCH v4 " Laurentiu Palcu
2014-11-19 12:21 ` Johan Hovold
2014-11-19 13:07 ` [PATCH v5 " Laurentiu Palcu
2014-11-19 13:51 ` Johan Hovold
2014-11-19 14:12 ` Laurentiu Palcu
2014-11-26 10:09 ` [PATCH v6 " Laurentiu Palcu
2014-11-26 18:25 ` Mark Brown [this message]
2014-11-27 10:30 ` Laurentiu Palcu
2014-11-28 13:09 ` [PATCH v7 " Laurentiu Palcu
2014-11-28 14:10 ` Mark Brown
2014-11-28 14:57 ` Laurentiu Palcu
2014-11-28 15:14 ` Mark Brown
2014-11-28 15:31 ` Laurentiu Palcu
2014-11-28 16:01 ` Mark Brown
2014-11-28 18:13 ` Laurentiu Palcu
2014-11-28 18:35 ` Mark Brown
2014-11-28 19:27 ` Laurentiu Palcu
2014-11-28 19:46 ` Mark Brown
2014-11-28 19:21 ` Octavian Purdila
2014-12-05 18:34 ` Mark Brown
2014-11-18 12:09 ` [PATCH v3 2/2] mfd: dln2: add support for USB-SPI module Laurentiu Palcu
2014-11-19 16:29 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141126182521.GP7712@sirena.org.uk \
--to=broonie@kernel.org \
--cc=johan@kernel.org \
--cc=laurentiu.palcu@intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=octavian.purdila@intel.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).