From: Johan Hedberg <johan.hedberg@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Steven Walter <stevenrwalter@gmail.com>,
"Gustavo F. Padovan" <gustavo@padovan.org>,
BlueZ development <linux-bluetooth@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Bluetooth: automatically flushable packets aren't allowed on LE links
Date: Thu, 20 Nov 2014 16:57:26 +0200 [thread overview]
Message-ID: <20141120145726.GA11947@t440s.P-661HNU-F1> (raw)
In-Reply-To: <80321467-10AB-489E-A47E-44B0ECEE4BE1@holtmann.org>
Hi Marcel,
On Thu, Nov 20, 2014, Marcel Holtmann wrote:
> > static u16 get_acl_flags(struct hci_conn *hcon, struct l2cap_chan *chan)
> > {
>
> If we do it with a helper functions, then it should only provide the
> l2cap_chan since we can get the hci_conn from there.
One of the places it'd get called from (l2cap_send_cmd) doesn't have a
l2cap_chan context at all which is why I split this into one mandatory
(hci_conn) and another optoinal (l2cap_chan) parameter.
Anyway, if you're happy with having this inline with a code comment
explaining the (rather complex) if-statement then I'm fine with that
too.
Johan
next prev parent reply other threads:[~2014-11-20 14:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 14:46 [PATCH] l2cap_core: automatically flushable packets aren't supported by LE-only devices Steven Walter
2014-11-18 22:01 ` Marcel Holtmann
2014-11-19 14:41 ` [PATCH v2] l2cap_core: automatically flushable packets aren't allowed on LE links Steven Walter
2014-11-19 14:48 ` Marcel Holtmann
2014-11-19 17:59 ` [PATCH v3] Bluetooth: " Steven Walter
2014-11-20 11:38 ` Johan Hedberg
2014-11-20 13:50 ` Marcel Holtmann
2014-11-20 14:57 ` Johan Hedberg [this message]
[not found] ` <CAK8d-aL+3eB4WZeqO1sv9p3440EVXQiqF6QiTU5YNAKAbZ7f-w@mail.gmail.com>
2014-11-25 14:53 ` Steven Walter
2014-11-26 5:16 ` Marcel Holtmann
2014-11-27 10:14 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141120145726.GA11947@t440s.P-661HNU-F1 \
--to=johan.hedberg@gmail.com \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=stevenrwalter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).