* [PATCH] thermal: sti: Ignore suspend/resume functions when !PM
@ 2014-11-19 15:50 Lee Jones
2014-11-19 16:04 ` Fabio Estevam
0 siblings, 1 reply; 7+ messages in thread
From: Lee Jones @ 2014-11-19 15:50 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel; +Cc: lee.jones, kernel, edubezval, linux-pm
Prevents build warning:
st_thermal.c:278:12:
warning: ‘st_thermal_suspend’ defined but not used [-Wunused-function]
st_thermal.c:286:12:
warning: ‘st_thermal_resume’ defined but not used [-Wunused-function]
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
v1 => v2:
- CONFIG_PM => CONFIG_PM_SLEEP suggested by David Paris.
drivers/thermal/st/st_thermal.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/thermal/st/st_thermal.c b/drivers/thermal/st/st_thermal.c
index 90163b3..d1ec580 100644
--- a/drivers/thermal/st/st_thermal.c
+++ b/drivers/thermal/st/st_thermal.c
@@ -275,6 +275,7 @@ int st_thermal_unregister(struct platform_device *pdev)
}
EXPORT_SYMBOL_GPL(st_thermal_unregister);
+#ifdef CONFIG_PM_SLEEP
static int st_thermal_suspend(struct device *dev)
{
struct platform_device *pdev = to_platform_device(dev);
@@ -305,6 +306,8 @@ static int st_thermal_resume(struct device *dev)
return 0;
}
+#endif
+
SIMPLE_DEV_PM_OPS(st_thermal_pm_ops, st_thermal_suspend, st_thermal_resume);
EXPORT_SYMBOL_GPL(st_thermal_pm_ops);
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] thermal: sti: Ignore suspend/resume functions when !PM
2014-11-19 15:50 [PATCH] thermal: sti: Ignore suspend/resume functions when !PM Lee Jones
@ 2014-11-19 16:04 ` Fabio Estevam
2014-11-19 16:40 ` Lee Jones
0 siblings, 1 reply; 7+ messages in thread
From: Fabio Estevam @ 2014-11-19 16:04 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-arm-kernel, linux-kernel, edubezval, kernel, linux-pm
On Wed, Nov 19, 2014 at 1:50 PM, Lee Jones <lee.jones@linaro.org> wrote:
> Prevents build warning:
>
> st_thermal.c:278:12:
> warning: ‘st_thermal_suspend’ defined but not used [-Wunused-function]
> st_thermal.c:286:12:
> warning: ‘st_thermal_resume’ defined but not used [-Wunused-function]
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>
> v1 => v2:
> - CONFIG_PM => CONFIG_PM_SLEEP suggested by David Paris.
You should also update the Subject to 'when !PM_SLEEP'
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] thermal: sti: Ignore suspend/resume functions when !PM
2014-11-19 16:04 ` Fabio Estevam
@ 2014-11-19 16:40 ` Lee Jones
2014-11-21 18:31 ` Eduardo Valentin
0 siblings, 1 reply; 7+ messages in thread
From: Lee Jones @ 2014-11-19 16:40 UTC (permalink / raw)
To: Fabio Estevam; +Cc: linux-arm-kernel, linux-kernel, edubezval, kernel, linux-pm
On Wed, 19 Nov 2014, Fabio Estevam wrote:
> On Wed, Nov 19, 2014 at 1:50 PM, Lee Jones <lee.jones@linaro.org> wrote:
> > Prevents build warning:
> >
> > st_thermal.c:278:12:
> > warning: ‘st_thermal_suspend’ defined but not used [-Wunused-function]
> > st_thermal.c:286:12:
> > warning: ‘st_thermal_resume’ defined but not used [-Wunused-function]
> >
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> >
> > v1 => v2:
> > - CONFIG_PM => CONFIG_PM_SLEEP suggested by David Paris.
>
> You should also update the Subject to 'when !PM_SLEEP'
I guess we should, yes.
Zhang, Eduardo,
Are you happy to do that, or would you like me to re-spin again?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] thermal: sti: Ignore suspend/resume functions when !PM
2014-11-19 16:40 ` Lee Jones
@ 2014-11-21 18:31 ` Eduardo Valentin
0 siblings, 0 replies; 7+ messages in thread
From: Eduardo Valentin @ 2014-11-21 18:31 UTC (permalink / raw)
To: Lee Jones; +Cc: Fabio Estevam, linux-arm-kernel, linux-kernel, kernel, linux-pm
[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]
Hello Lee,
On Wed, Nov 19, 2014 at 04:40:40PM +0000, Lee Jones wrote:
> On Wed, 19 Nov 2014, Fabio Estevam wrote:
>
> > On Wed, Nov 19, 2014 at 1:50 PM, Lee Jones <lee.jones@linaro.org> wrote:
> > > Prevents build warning:
> > >
> > > st_thermal.c:278:12:
> > > warning: ‘st_thermal_suspend’ defined but not used [-Wunused-function]
> > > st_thermal.c:286:12:
> > > warning: ‘st_thermal_resume’ defined but not used [-Wunused-function]
> > >
> > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > > ---
> > >
> > > v1 => v2:
> > > - CONFIG_PM => CONFIG_PM_SLEEP suggested by David Paris.
> >
> > You should also update the Subject to 'when !PM_SLEEP'
>
> I guess we should, yes.
>
> Zhang, Eduardo,
>
> Are you happy to do that, or would you like me to re-spin again?
>
I can edit the patch for you this time.
Next time, when sending new versions, a couple of advices:
(1) add the Ack's/Reviewed's/Tested's -by you get along the way.
(2) please, version you patches, it easies maintainter's life while
reviewing / applying your patches.
Thanks for sending the fix.
Eduardo Valentin
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] thermal: sti: Ignore suspend/resume functions when !PM
2014-11-19 14:57 ` Fabio Estevam
@ 2014-11-19 15:49 ` Lee Jones
0 siblings, 0 replies; 7+ messages in thread
From: Lee Jones @ 2014-11-19 15:49 UTC (permalink / raw)
To: Fabio Estevam; +Cc: linux-arm-kernel, linux-kernel, edubezval, kernel, linux-pm
On Wed, 19 Nov 2014, Fabio Estevam wrote:
> On Wed, Nov 19, 2014 at 11:48 AM, Lee Jones <lee.jones@linaro.org> wrote:
> > Prevents build warning:
> >
> > st_thermal.c:278:12:
> > warning: ‘st_thermal_suspend’ defined but not used [-Wunused-function]
> > st_thermal.c:286:12:
> > warning: ‘st_thermal_resume’ defined but not used [-Wunused-function]
> >
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > drivers/thermal/st/st_thermal.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/thermal/st/st_thermal.c b/drivers/thermal/st/st_thermal.c
> > index 90163b3..9841488 100644
> > --- a/drivers/thermal/st/st_thermal.c
> > +++ b/drivers/thermal/st/st_thermal.c
> > @@ -275,6 +275,7 @@ int st_thermal_unregister(struct platform_device *pdev)
> > }
> > EXPORT_SYMBOL_GPL(st_thermal_unregister);
> >
> > +#ifdef CONFIG_PM
>
> Actually this should be #ifdef CONFIG_PM_SLEEP instead
You're right, someone already pointed this out, thanks.
I will re-submit in ~1min.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] thermal: sti: Ignore suspend/resume functions when !PM
2014-11-19 13:48 Lee Jones
@ 2014-11-19 14:57 ` Fabio Estevam
2014-11-19 15:49 ` Lee Jones
0 siblings, 1 reply; 7+ messages in thread
From: Fabio Estevam @ 2014-11-19 14:57 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-arm-kernel, linux-kernel, edubezval, kernel, linux-pm
On Wed, Nov 19, 2014 at 11:48 AM, Lee Jones <lee.jones@linaro.org> wrote:
> Prevents build warning:
>
> st_thermal.c:278:12:
> warning: ‘st_thermal_suspend’ defined but not used [-Wunused-function]
> st_thermal.c:286:12:
> warning: ‘st_thermal_resume’ defined but not used [-Wunused-function]
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/thermal/st/st_thermal.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/thermal/st/st_thermal.c b/drivers/thermal/st/st_thermal.c
> index 90163b3..9841488 100644
> --- a/drivers/thermal/st/st_thermal.c
> +++ b/drivers/thermal/st/st_thermal.c
> @@ -275,6 +275,7 @@ int st_thermal_unregister(struct platform_device *pdev)
> }
> EXPORT_SYMBOL_GPL(st_thermal_unregister);
>
> +#ifdef CONFIG_PM
Actually this should be #ifdef CONFIG_PM_SLEEP instead
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] thermal: sti: Ignore suspend/resume functions when !PM
@ 2014-11-19 13:48 Lee Jones
2014-11-19 14:57 ` Fabio Estevam
0 siblings, 1 reply; 7+ messages in thread
From: Lee Jones @ 2014-11-19 13:48 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel; +Cc: lee.jones, kernel, edubezval, linux-pm
Prevents build warning:
st_thermal.c:278:12:
warning: ‘st_thermal_suspend’ defined but not used [-Wunused-function]
st_thermal.c:286:12:
warning: ‘st_thermal_resume’ defined but not used [-Wunused-function]
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/thermal/st/st_thermal.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/thermal/st/st_thermal.c b/drivers/thermal/st/st_thermal.c
index 90163b3..9841488 100644
--- a/drivers/thermal/st/st_thermal.c
+++ b/drivers/thermal/st/st_thermal.c
@@ -275,6 +275,7 @@ int st_thermal_unregister(struct platform_device *pdev)
}
EXPORT_SYMBOL_GPL(st_thermal_unregister);
+#ifdef CONFIG_PM
static int st_thermal_suspend(struct device *dev)
{
struct platform_device *pdev = to_platform_device(dev);
@@ -305,6 +306,8 @@ static int st_thermal_resume(struct device *dev)
return 0;
}
+#endif
+
SIMPLE_DEV_PM_OPS(st_thermal_pm_ops, st_thermal_suspend, st_thermal_resume);
EXPORT_SYMBOL_GPL(st_thermal_pm_ops);
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-11-21 18:31 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-19 15:50 [PATCH] thermal: sti: Ignore suspend/resume functions when !PM Lee Jones
2014-11-19 16:04 ` Fabio Estevam
2014-11-19 16:40 ` Lee Jones
2014-11-21 18:31 ` Eduardo Valentin
-- strict thread matches above, loose matches on Subject: below --
2014-11-19 13:48 Lee Jones
2014-11-19 14:57 ` Fabio Estevam
2014-11-19 15:49 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).