linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH]  Staging:skein: Fix trailing  whitespace error
@ 2014-11-22  6:04 Anjana Sasindran
  2014-11-22  6:23 ` Sudip Mukherjee
  2014-11-22 18:58 ` Greg KH
  0 siblings, 2 replies; 8+ messages in thread
From: Anjana Sasindran @ 2014-11-22  6:04 UTC (permalink / raw)
  To: gregkh; +Cc: linux-kernel, devel, Anjana Sasindran

  This patch fixes the checkpatch.pl error:

  ERROR: trailing whitespace

Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com>
---
 drivers/staging/skein/skein_generic.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
index 7096d5a..8660509 100644
--- a/drivers/staging/skein/skein_generic.c
+++ b/drivers/staging/skein/skein_generic.c
@@ -190,6 +190,7 @@ static int __init skein_generic_init(void)
 		goto unreg512;
 
 	return 0;
+
 unreg512:
 	crypto_unregister_shash(&alg512);
 unreg256:
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH]  Staging:skein: Fix trailing  whitespace error
  2014-11-22  6:04 [PATCH] Staging:skein: Fix trailing whitespace error Anjana Sasindran
@ 2014-11-22  6:23 ` Sudip Mukherjee
       [not found]   ` <CABU2W3qqaFxrUtM1mkjEVjs1QyWJNP0fWA0dnpLs5nj12XzjYg@mail.gmail.com>
  2014-11-22 18:58 ` Greg KH
  1 sibling, 1 reply; 8+ messages in thread
From: Sudip Mukherjee @ 2014-11-22  6:23 UTC (permalink / raw)
  To: Anjana Sasindran; +Cc: gregkh, linux-kernel, devel

On Sat, Nov 22, 2014 at 11:34:29AM +0530, Anjana Sasindran wrote:
>   This patch fixes the checkpatch.pl error:
this patch is not applying to next-20141121.
> 
>   ERROR: trailing whitespace
but your patch is adding a blank line in the code ?

thanks
sudip

> 
> Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com>
> ---
>  drivers/staging/skein/skein_generic.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
> index 7096d5a..8660509 100644
> --- a/drivers/staging/skein/skein_generic.c
> +++ b/drivers/staging/skein/skein_generic.c
> @@ -190,6 +190,7 @@ static int __init skein_generic_init(void)
>  		goto unreg512;
>  
>  	return 0;
> +
>  unreg512:
>  	crypto_unregister_shash(&alg512);
>  unreg256:
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] Staging:skein: Fix trailing whitespace error
       [not found]   ` <CABU2W3qqaFxrUtM1mkjEVjs1QyWJNP0fWA0dnpLs5nj12XzjYg@mail.gmail.com>
@ 2014-11-22  8:20     ` Sudip Mukherjee
  0 siblings, 0 replies; 8+ messages in thread
From: Sudip Mukherjee @ 2014-11-22  8:20 UTC (permalink / raw)
  To: anjana s; +Cc: gregkh, linux-kernel, devel

On Sat, Nov 22, 2014 at 01:20:13PM +0530, anjana s wrote:
> Just now I resend the same patch by making necessary changes.
> Kindly please go through it
you replied only to me. You should always use reply to all unless there is some specific reason not to send the reply to all.

thanks
sudip

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH]  Staging:skein: Fix trailing  whitespace error
  2014-11-22  6:04 [PATCH] Staging:skein: Fix trailing whitespace error Anjana Sasindran
  2014-11-22  6:23 ` Sudip Mukherjee
@ 2014-11-22 18:58 ` Greg KH
  1 sibling, 0 replies; 8+ messages in thread
From: Greg KH @ 2014-11-22 18:58 UTC (permalink / raw)
  To: Anjana Sasindran; +Cc: devel, linux-kernel

On Sat, Nov 22, 2014 at 11:34:29AM +0530, Anjana Sasindran wrote:
>   This patch fixes the checkpatch.pl error:
> 
>   ERROR: trailing whitespace
> 
> Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com>
> ---
>  drivers/staging/skein/skein_generic.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
> index 7096d5a..8660509 100644
> --- a/drivers/staging/skein/skein_generic.c
> +++ b/drivers/staging/skein/skein_generic.c
> @@ -190,6 +190,7 @@ static int __init skein_generic_init(void)
>  		goto unreg512;
>  
>  	return 0;
> +
>  unreg512:
>  	crypto_unregister_shash(&alg512);
>  unreg256:

Still doesn't apply :(

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH]  Staging:skein: Fix trailing  whitespace error
  2014-11-21  0:07 Anjana Sasindran
@ 2014-11-22 18:57 ` Greg KH
  0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2014-11-22 18:57 UTC (permalink / raw)
  To: Anjana Sasindran; +Cc: devel, linux-kernel

On Fri, Nov 21, 2014 at 05:37:04AM +0530, Anjana Sasindran wrote:
>   This patch fixes the checkpatch.pl error:
> 
>   ERROR: trailing whitespace
> 
> Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com>
> ---
>  drivers/staging/skein/skein_generic.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
> index 7096d5a..8660509 100644
> --- a/drivers/staging/skein/skein_generic.c
> +++ b/drivers/staging/skein/skein_generic.c
> @@ -190,6 +190,7 @@ static int __init skein_generic_init(void)
>  		goto unreg512;
>  
>  	return 0;
> +
>  unreg512:
>  	crypto_unregister_shash(&alg512);
>  unreg256:

Doesn't apply :(

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] Staging:skein: Fix trailing  whitespace error
  2014-11-20 23:41 Anjana Sasindran
@ 2014-11-21  4:06 ` Greg KH
  0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2014-11-21  4:06 UTC (permalink / raw)
  To: Anjana Sasindran; +Cc: devel, linux-kernel

On Fri, Nov 21, 2014 at 05:11:27AM +0530, Anjana Sasindran wrote:
> This patch fixes the checkpatch.pl error:
> 
> ERROR: trailing whitespace
> 
> Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com>
> ---
>  arch/arm/boot/dts/include/dt-bindings   | 1 -
>  arch/metag/boot/dts/include/dt-bindings | 1 -
>  arch/mips/boot/dts/include/dt-bindings  | 1 -

What are these files doing in this patch?

I can't take this...

greg k-h

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH]  Staging:skein: Fix trailing  whitespace error
@ 2014-11-21  0:07 Anjana Sasindran
  2014-11-22 18:57 ` Greg KH
  0 siblings, 1 reply; 8+ messages in thread
From: Anjana Sasindran @ 2014-11-21  0:07 UTC (permalink / raw)
  To: gregkh; +Cc: linux-kernel, devel, Anjana Sasindran

  This patch fixes the checkpatch.pl error:

  ERROR: trailing whitespace

Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com>
---
 drivers/staging/skein/skein_generic.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
index 7096d5a..8660509 100644
--- a/drivers/staging/skein/skein_generic.c
+++ b/drivers/staging/skein/skein_generic.c
@@ -190,6 +190,7 @@ static int __init skein_generic_init(void)
 		goto unreg512;
 
 	return 0;
+
 unreg512:
 	crypto_unregister_shash(&alg512);
 unreg256:
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH] Staging:skein: Fix trailing  whitespace error
@ 2014-11-20 23:41 Anjana Sasindran
  2014-11-21  4:06 ` Greg KH
  0 siblings, 1 reply; 8+ messages in thread
From: Anjana Sasindran @ 2014-11-20 23:41 UTC (permalink / raw)
  To: gregkh; +Cc: linux-kernel, devel, Anjana Sasindran

This patch fixes the checkpatch.pl error:

ERROR: trailing whitespace

Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com>
---
 arch/arm/boot/dts/include/dt-bindings   | 1 -
 arch/metag/boot/dts/include/dt-bindings | 1 -
 arch/mips/boot/dts/include/dt-bindings  | 1 -
 drivers/staging/skein/skein_generic.c   | 2 --
 4 files changed, 5 deletions(-)
 delete mode 120000 arch/arm/boot/dts/include/dt-bindings
 delete mode 120000 arch/metag/boot/dts/include/dt-bindings
 delete mode 120000 arch/mips/boot/dts/include/dt-bindings

diff --git a/arch/arm/boot/dts/include/dt-bindings b/arch/arm/boot/dts/include/dt-bindings
deleted file mode 120000
index 08c00e4..0000000
--- a/arch/arm/boot/dts/include/dt-bindings
+++ /dev/null
@@ -1 +0,0 @@
-../../../../../include/dt-bindings
\ No newline at end of file
diff --git a/arch/metag/boot/dts/include/dt-bindings b/arch/metag/boot/dts/include/dt-bindings
deleted file mode 120000
index 08c00e4..0000000
--- a/arch/metag/boot/dts/include/dt-bindings
+++ /dev/null
@@ -1 +0,0 @@
-../../../../../include/dt-bindings
\ No newline at end of file
diff --git a/arch/mips/boot/dts/include/dt-bindings b/arch/mips/boot/dts/include/dt-bindings
deleted file mode 120000
index 08c00e4..0000000
--- a/arch/mips/boot/dts/include/dt-bindings
+++ /dev/null
@@ -1 +0,0 @@
-../../../../../include/dt-bindings
\ No newline at end of file
diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
index 60d16b6..7096d5a 100644
--- a/drivers/staging/skein/skein_generic.c
+++ b/drivers/staging/skein/skein_generic.c
@@ -190,8 +190,6 @@ static int __init skein_generic_init(void)
 		goto unreg512;
 
 	return 0;
-
-		
 unreg512:
 	crypto_unregister_shash(&alg512);
 unreg256:
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2014-11-22 18:59 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-22  6:04 [PATCH] Staging:skein: Fix trailing whitespace error Anjana Sasindran
2014-11-22  6:23 ` Sudip Mukherjee
     [not found]   ` <CABU2W3qqaFxrUtM1mkjEVjs1QyWJNP0fWA0dnpLs5nj12XzjYg@mail.gmail.com>
2014-11-22  8:20     ` Sudip Mukherjee
2014-11-22 18:58 ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2014-11-21  0:07 Anjana Sasindran
2014-11-22 18:57 ` Greg KH
2014-11-20 23:41 Anjana Sasindran
2014-11-21  4:06 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).