From: Eduardo Valentin <edubezval@gmail.com>
To: Lukasz Majewski <l.majewski@samsung.com>
Cc: Zhang Rui <rui.zhang@intel.com>,
Linux PM list <linux-pm@vger.kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Lukasz Majewski <l.majewski@majess.pl>,
Mikko Perttunen <mperttunen@nvidia.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Abhilash Kesavan <kesavan.abhilash@gmail.com>,
Abhilash Kesavan <a.kesavan@samsung.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org,
Caesar Wang <caesar.wang@rock-chips.com>
Subject: Re: [PATCH v2 3/4] thermal: of: Extend of-thermal to export table of trip points
Date: Tue, 25 Nov 2014 16:38:47 -0400 [thread overview]
Message-ID: <20141125203845.GB14292@developer> (raw)
In-Reply-To: <1416500488-7232-4-git-send-email-l.majewski@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 4630 bytes --]
On Thu, Nov 20, 2014 at 05:21:27PM +0100, Lukasz Majewski wrote:
> This patch extends the of-thermal.c to export copy of trip points for
> a given thermal zone.
>
> Thermal drivers should use of_thermal_get_trip_points() method to get
> pointer to table of thermal trip points.
>
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> ---
> Changes for v2:
> - New patch - as suggested by Eduardo Valentin
> ---
> drivers/thermal/of-thermal.c | 33 +++++++++++++++++++++++++++++++++
> drivers/thermal/thermal_core.h | 7 +++++++
> include/linux/thermal.h | 14 ++++++++++++++
> 3 files changed, 54 insertions(+)
>
> diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
> index 336af7f..33921c5 100644
> --- a/drivers/thermal/of-thermal.c
> +++ b/drivers/thermal/of-thermal.c
> @@ -89,6 +89,7 @@ struct __thermal_zone {
> /* trip data */
> int ntrips;
> struct __thermal_trip *trips;
> + struct thermal_trip *gtrips;
>
> /* cooling binding data */
> int num_tbps;
> @@ -152,6 +153,27 @@ bool of_thermal_is_trip_en(struct thermal_zone_device *tz, int trip)
> return true;
> }
>
> +/**
> + * of_thermal_get_trip_points - function to get access to a globally exported
> + * trip points
> + *
> + * @tz: pointer to a thermal zone
> + *
> + * This function provides a pointer to the copy of trip points table
> + *
> + * Return: pointer to trip points table, NULL otherwise
> + */
> +const struct thermal_trip * const
> +of_thermal_get_trip_points(struct thermal_zone_device *tz)
Another thing, can you please check why scripts/kernel-doc does not like
this prototype? It throws an warn:
Warning(drivers/thermal/of-thermal.c:168): cannot understand function
prototype: 'const struct thermal_trip * const
of_thermal_get_trip_points(struct thermal_zone_device *tz) '
> +{
> + struct __thermal_zone *data = tz->devdata;
> +
> + if (!data)
> + return NULL;
> +
> + return data->gtrips;
> +}
> +
> static int of_thermal_get_trend(struct thermal_zone_device *tz, int trip,
> enum thermal_trend *trend)
> {
> @@ -767,6 +789,16 @@ thermal_of_build_thermal_zone(struct device_node *np)
> goto free_tbps;
> }
>
> + tz->gtrips = kcalloc(tz->ntrips, sizeof(*tz->gtrips), GFP_KERNEL);
> + if (!tz->gtrips) {
> + ret = -ENOMEM;
> + goto free_tbps;
> + }
> +
> + for (i = 0; i < tz->ntrips; i++)
> + memcpy(&(tz->gtrips[i]), &(tz->trips[i].temperature),
> + sizeof(*tz->gtrips));
> +
> finish:
> of_node_put(child);
> tz->mode = THERMAL_DEVICE_DISABLED;
> @@ -793,6 +825,7 @@ static inline void of_thermal_free_zone(struct __thermal_zone *tz)
> {
> int i;
>
> + kfree(tz->gtrips);
> for (i = 0; i < tz->num_tbps; i++)
> of_node_put(tz->tbps[i].cooling_device);
> kfree(tz->tbps);
> diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h
> index 466208c..a9580ca 100644
> --- a/drivers/thermal/thermal_core.h
> +++ b/drivers/thermal/thermal_core.h
> @@ -91,6 +91,8 @@ int of_parse_thermal_zones(void);
> void of_thermal_destroy_zones(void);
> int of_thermal_get_ntrips(struct thermal_zone_device *);
> bool of_thermal_is_trip_en(struct thermal_zone_device *, int);
> +const struct thermal_trip * const
> +of_thermal_get_trip_points(struct thermal_zone_device *);
> #else
> static inline int of_parse_thermal_zones(void) { return 0; }
> static inline void of_thermal_destroy_zones(void) { }
> @@ -102,6 +104,11 @@ static inline bool of_thermal_is_trip_en(struct thermal_zone_device *, int)
> {
> return 0;
> }
> +static inline const struct thermal_trip * const
> +of_thermal_get_trip_points(struct thermal_zone_device *)
> +{
> + return NULL;
> +}
> #endif
>
> #endif /* __THERMAL_CORE_H__ */
> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> index 5bc28a7..88d7249 100644
> --- a/include/linux/thermal.h
> +++ b/include/linux/thermal.h
> @@ -303,6 +303,20 @@ struct thermal_zone_of_device_ops {
> int (*get_trend)(void *, long *);
> };
>
> +/**
> + * struct thermal_trip - Structure representing themal trip points exported from
> + * of-thermal
> + *
> + * @temperature: trip point temperature
> + * @hysteresis: trip point hysteresis
> + * @type: trip point type
> + */
> +struct thermal_trip {
> + unsigned long int temperature;
> + unsigned long int hysteresis;
> + enum thermal_trip_type type;
> +};
> +
> /* Function declarations */
> #ifdef CONFIG_THERMAL_OF
> struct thermal_zone_device *
> --
> 2.0.0.rc2
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-11-25 20:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1412872737-624-1-git-send-email-l.majewski@samsung.com>
2014-11-20 16:21 ` [PATCH v2 0/4] thermal: of: of-thermal.c API extensions Lukasz Majewski
2014-11-20 16:21 ` [PATCH v2 1/4] thermal: of: Extend of-thermal.c to provide number of trip points Lukasz Majewski
2014-11-25 6:04 ` Eduardo Valentin
2014-11-26 8:28 ` Lukasz Majewski
2014-11-20 16:21 ` [PATCH v2 2/4] thermal: of: Extend of-thermal.c to provide check if trip point is enabled Lukasz Majewski
2014-11-25 8:25 ` Eduardo Valentin
2014-11-26 8:31 ` Lukasz Majewski
2014-11-20 16:21 ` [PATCH v2 3/4] thermal: of: Extend of-thermal to export table of trip points Lukasz Majewski
2014-11-25 20:36 ` Eduardo Valentin
2014-11-26 8:35 ` Lukasz Majewski
2014-11-26 15:18 ` Eduardo Valentin
2014-11-26 20:43 ` navneet kumar
2014-11-26 21:12 ` Guenter Roeck
2014-11-26 23:12 ` navneet kumar
2014-11-26 23:09 ` Eduardo Valentin
2014-11-27 9:42 ` Lukasz Majewski
2014-11-25 20:38 ` Eduardo Valentin [this message]
2014-11-26 8:39 ` Lukasz Majewski
2014-11-20 16:21 ` [PATCH v2 4/4] thermal: of: Extend current of-thermal.c code to allow setting emulated temp Lukasz Majewski
2014-11-25 20:44 ` Eduardo Valentin
2014-11-26 8:47 ` Lukasz Majewski
2014-12-08 17:04 ` [PATCH v3 0/5] thermal: of: of-thermal.c API extensions Lukasz Majewski
2014-12-08 17:04 ` [PATCH v3 1/5] thermal: of: Extend of-thermal.c to provide number of trip points Lukasz Majewski
2014-12-08 19:52 ` Eduardo Valentin
2014-12-08 23:02 ` Lukasz Majewski
2014-12-08 17:04 ` [PATCH v3 2/5] thermal: of: Extend of-thermal.c to provide check if trip point is valid Lukasz Majewski
2014-12-08 17:04 ` [PATCH v3 3/5] thermal: of: Rename struct __thermal_trip to struct thermal_trip Lukasz Majewski
2014-12-08 17:04 ` [PATCH v3 4/5] thermal: of: Extend of-thermal to export table of trip points Lukasz Majewski
2014-12-08 17:04 ` [PATCH v3 5/5] thermal: of: Extend current of-thermal.c code to allow setting emulated temp Lukasz Majewski
2014-12-09 1:21 ` [PATCH v3 0/5] thermal: of: of-thermal.c API extensions Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125203845.GB14292@developer \
--to=edubezval@gmail.com \
--cc=a.kesavan@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=caesar.wang@rock-chips.com \
--cc=kesavan.abhilash@gmail.com \
--cc=l.majewski@majess.pl \
--cc=l.majewski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mperttunen@nvidia.com \
--cc=rui.zhang@intel.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).