Re: [Xen-devel] [PATCH] xen-pciback: Add MODULE_ALIAS for pciback.

Re: [Xen-devel] [PATCH] xen-pciback: Add MODULE_ALIAS for pciback.

[Konrad Rzeszutek Wilk]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 1557 bytes --]


On Nov 26, 2014 11:39 AM, "Luis R. Rodriguez" <mcgrof@do-not-panic.com> wrote:
>
> On Wed, Aug 20, 2014 at 1:26 PM, Ian Campbell <ian.campbell@citrix.com> wrote: 
> > On Wed, 2014-08-20 at 13:20 -0400, Konrad Rzeszutek Wilk wrote: 
> >> On Wed, Aug 20, 2014 at 06:18:52PM +0100, Ian Campbell wrote: 
> >> > On Wed, 2014-08-20 at 12:40 -0400, Konrad Rzeszutek Wilk wrote: 
> >> > > The rest of the Xen device drivers use an module alias 
> >> > > to load devices when they shop up in XenBus. 
> >> > 
> >> > "show". 
> >> > > 
> >> > >  MODULE_LICENSE("Dual BSD/GPL"); 
> >> > >  MODULE_ALIAS("xen-backend:pci"); 
> >> > > +MODULE_ALIAS("xen:pci"); 
> >> > 
> >> > Isn't that xen-backend:pci already the right thing for a backend device? 
> >> > xen: is for frontends, I thought. 
> >> 
> >> Oh, you are right. Cool! Thanks! 
> > 
> > The patch turned out to be even more trivial than expected ;-) 
>
> Is this what we expected to be pending work for the item "device 
> hotplug (MODULE_ALIAS)" on the upstream TODO list? 
>
> http://wiki.xenproject.org/wiki/XenParavirtOps#Upstream_delta_details 
>
> This was simply to just auto load that driver when needed right? 
>

Right which it does now.

> Also as for actual PCI device hotplug support: 
>
> http://wiki.xen.org/wiki/Xen_PCI_Passthrough#Hotplug 
>
> I don't think we need a delta for that do we? 

Nope. This one is all done.
>
> Luis 
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [Xen-devel] [PATCH] xen-pciback: Add MODULE_ALIAS for pciback.

[Luis R. Rodriguez]

On Wed, Aug 20, 2014 at 1:26 PM, Ian Campbell <ian.campbell@citrix.com> wrote:
> On Wed, 2014-08-20 at 13:20 -0400, Konrad Rzeszutek Wilk wrote:
>> On Wed, Aug 20, 2014 at 06:18:52PM +0100, Ian Campbell wrote:
>> > On Wed, 2014-08-20 at 12:40 -0400, Konrad Rzeszutek Wilk wrote:
>> > > The rest of the Xen device drivers use an module alias
>> > > to load devices when they shop up in XenBus.
>> >
>> > "show".
>> > >
>> > >  MODULE_LICENSE("Dual BSD/GPL");
>> > >  MODULE_ALIAS("xen-backend:pci");
>> > > +MODULE_ALIAS("xen:pci");
>> >
>> > Isn't that xen-backend:pci already the right thing for a backend device?
>> > xen: is for frontends, I thought.
>>
>> Oh, you are right. Cool! Thanks!
>
> The patch turned out to be even more trivial than expected ;-)

Is this what we expected to be pending work for the item "device
hotplug (MODULE_ALIAS)" on the upstream TODO list?

http://wiki.xenproject.org/wiki/XenParavirtOps#Upstream_delta_details

This was simply to just auto load that driver when needed right?

Also as for actual PCI device hotplug support:

http://wiki.xen.org/wiki/Xen_PCI_Passthrough#Hotplug

I don't think we need a delta for that do we?

 Luis

Re: [Xen-devel] [PATCH] xen-pciback: Add MODULE_ALIAS for pciback.

[Ian Campbell]

On Wed, 2014-08-20 at 13:20 -0400, Konrad Rzeszutek Wilk wrote:
> On Wed, Aug 20, 2014 at 06:18:52PM +0100, Ian Campbell wrote:
> > On Wed, 2014-08-20 at 12:40 -0400, Konrad Rzeszutek Wilk wrote:
> > > The rest of the Xen device drivers use an module alias
> > > to load devices when they shop up in XenBus.
> > 
> > "show".
> > >  
> > >  MODULE_LICENSE("Dual BSD/GPL");
> > >  MODULE_ALIAS("xen-backend:pci");
> > > +MODULE_ALIAS("xen:pci");
> > 
> > Isn't that xen-backend:pci already the right thing for a backend device?
> > xen: is for frontends, I thought.
> 
> Oh, you are right. Cool! Thanks!

The patch turned out to be even more trivial than expected ;-)

Ian.

Re: [Xen-devel] [PATCH] xen-pciback: Add MODULE_ALIAS for pciback.

[Konrad Rzeszutek Wilk]

On Wed, Aug 20, 2014 at 06:18:52PM +0100, Ian Campbell wrote:
> On Wed, 2014-08-20 at 12:40 -0400, Konrad Rzeszutek Wilk wrote:
> > The rest of the Xen device drivers use an module alias
> > to load devices when they shop up in XenBus.
> 
> "show".
> >  
> >  MODULE_LICENSE("Dual BSD/GPL");
> >  MODULE_ALIAS("xen-backend:pci");
> > +MODULE_ALIAS("xen:pci");
> 
> Isn't that xen-backend:pci already the right thing for a backend device?
> xen: is for frontends, I thought.

Oh, you are right. Cool! Thanks!
> 
> Ian.
> 

Re: [Xen-devel] [PATCH] xen-pciback: Add MODULE_ALIAS for pciback.

[Ian Campbell]

On Wed, 2014-08-20 at 12:40 -0400, Konrad Rzeszutek Wilk wrote:
> The rest of the Xen device drivers use an module alias
> to load devices when they shop up in XenBus.

"show".
>  
>  MODULE_LICENSE("Dual BSD/GPL");
>  MODULE_ALIAS("xen-backend:pci");
> +MODULE_ALIAS("xen:pci");

Isn't that xen-backend:pci already the right thing for a backend device?
xen: is for frontends, I thought.

Ian.