* [PATCH RESEND] Documentation: devicetree: Fix Xilinx VDMA specification @ 2014-11-12 13:51 Andreas Färber 2014-11-12 15:57 ` Sören Brinkmann 0 siblings, 1 reply; 5+ messages in thread From: Andreas Färber @ 2014-11-12 13:51 UTC (permalink / raw) To: Vinod Koul Cc: dmaengine, Michal Simek, Sören Brinkmann, linux-arm-kernel, Andreas Färber, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, open list:OPEN FIRMWARE AND..., open list The specification requires xlnx,data-width, but example and driver use xlnx,datawidth. Change the specification to match the implementation. Reviewed-by: Michal Simek <michal.simek@xilinx.com> Fixes: eebeac03db93 ("dma: Add Xilinx Video DMA DT Binding Documentation") Signed-off-by: Andreas Färber <afaerber@suse.de> --- This appears to have fallen through the cracks... resending to dmaengine. Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt index 1405ed071bb4..e4c4d47f8137 100644 --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt @@ -25,7 +25,7 @@ Required child node properties: - compatible: It should be either "xlnx,axi-vdma-mm2s-channel" or "xlnx,axi-vdma-s2mm-channel". - interrupts: Should contain per channel VDMA interrupts. -- xlnx,data-width: Should contain the stream data width, take values +- xlnx,datawidth: Should contain the stream data width, take values {32,64...1024}. Optional child node properties: -- 2.1.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] Documentation: devicetree: Fix Xilinx VDMA specification 2014-11-12 13:51 [PATCH RESEND] Documentation: devicetree: Fix Xilinx VDMA specification Andreas Färber @ 2014-11-12 15:57 ` Sören Brinkmann 2014-11-12 18:03 ` Andreas Färber 0 siblings, 1 reply; 5+ messages in thread From: Sören Brinkmann @ 2014-11-12 15:57 UTC (permalink / raw) To: Andreas Färber Cc: Vinod Koul, dmaengine, Michal Simek, linux-arm-kernel, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, open list:OPEN FIRMWARE AND..., open list On Wed, 2014-11-12 at 02:51PM +0100, Andreas Färber wrote: > The specification requires xlnx,data-width, but example and driver use > xlnx,datawidth. Change the specification to match the implementation. Isn't this the wrong way around? The bindings are considered API, so shouldn't the driver be fixed to match the spec? Are there already dts files out there using either of these options? Soren ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] Documentation: devicetree: Fix Xilinx VDMA specification 2014-11-12 15:57 ` Sören Brinkmann @ 2014-11-12 18:03 ` Andreas Färber 2014-11-12 18:26 ` Sören Brinkmann 0 siblings, 1 reply; 5+ messages in thread From: Andreas Färber @ 2014-11-12 18:03 UTC (permalink / raw) To: Sören Brinkmann Cc: Vinod Koul, dmaengine, Michal Simek, linux-arm-kernel, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, OPEN FIRMWARE AND..., LKML, Srikanth Thokala, Lars-Peter Clausen [-- Attachment #1: Type: text/plain, Size: 1362 bytes --] Am 12.11.2014 um 16:57 schrieb Sören Brinkmann: > On Wed, 2014-11-12 at 02:51PM +0100, Andreas Färber wrote: >> The specification requires xlnx,data-width, but example and driver use >> xlnx,datawidth. Change the specification to match the implementation. > > Isn't this the wrong way around? The bindings are considered API, so > shouldn't the driver be fixed to match the spec? In theory, patch review should've never let the two differ... ;) It's not my driver, so I fixed the perceived inconsistency the least invasive way; Michal and Srikanth seemed to concur at the time. https://patchwork.kernel.org/patch/4620261/ > Are there already dts files out there using either of these options? In upstream, no. microblaze and virtex440 use a xlnx,include-datawidth-matching-0 property as precedence for the spelling, whereas there is an fsl,data-width and an unused msix-data-width. Downstream, yes: Beyond my own patch derived from the Parallella tree, there's some in the ADI tree. None in the Xilinx tree on quick check. I haven't encountered any using the documented xlnx,data-width - but this patch was authored pre 3.17, haven't ran a full Web search again. Regards, Andreas -- SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] Documentation: devicetree: Fix Xilinx VDMA specification 2014-11-12 18:03 ` Andreas Färber @ 2014-11-12 18:26 ` Sören Brinkmann 2014-12-05 16:47 ` Vinod Koul 0 siblings, 1 reply; 5+ messages in thread From: Sören Brinkmann @ 2014-11-12 18:26 UTC (permalink / raw) To: Andreas Färber Cc: Vinod Koul, dmaengine, Michal Simek, linux-arm-kernel, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, OPEN FIRMWARE AND..., LKML, Srikanth Thokala, Lars-Peter Clausen On Wed, 2014-11-12 at 07:03PM +0100, Andreas Färber wrote: > Am 12.11.2014 um 16:57 schrieb Sören Brinkmann: > > On Wed, 2014-11-12 at 02:51PM +0100, Andreas Färber wrote: > >> The specification requires xlnx,data-width, but example and driver use > >> xlnx,datawidth. Change the specification to match the implementation. > > > > Isn't this the wrong way around? The bindings are considered API, so > > shouldn't the driver be fixed to match the spec? > > In theory, patch review should've never let the two differ... ;) > > It's not my driver, so I fixed the perceived inconsistency the least > invasive way; Michal and Srikanth seemed to concur at the time. > > https://patchwork.kernel.org/patch/4620261/ > > > Are there already dts files out there using either of these options? > > In upstream, no. microblaze and virtex440 use a > xlnx,include-datawidth-matching-0 property as precedence for the > spelling, whereas there is an fsl,data-width and an unused msix-data-width. > > Downstream, yes: Beyond my own patch derived from the Parallella tree, > there's some in the ADI tree. None in the Xilinx tree on quick check. > > I haven't encountered any using the documented xlnx,data-width - but > this patch was authored pre 3.17, haven't ran a full Web search again. grepping through linux-next shows some usage of xlnx,datawidth, but only the single hit in Documentation for xlnx,data-width. Other than VDMA the other hit seems to be just some DT documentation which I can't find a driver for... Anyhow, this patch is probably the best way of fixing this. Reviewed-by: Soren Brinkmann <soren.brinkmann@xilinx.com> Thanks, Sören ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] Documentation: devicetree: Fix Xilinx VDMA specification 2014-11-12 18:26 ` Sören Brinkmann @ 2014-12-05 16:47 ` Vinod Koul 0 siblings, 0 replies; 5+ messages in thread From: Vinod Koul @ 2014-12-05 16:47 UTC (permalink / raw) To: Sören Brinkmann Cc: Andreas Färber, dmaengine, Michal Simek, linux-arm-kernel, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, OPEN FIRMWARE AND..., LKML, Srikanth Thokala, Lars-Peter Clausen On Wed, Nov 12, 2014 at 10:26:03AM -0800, Sören Brinkmann wrote: > On Wed, 2014-11-12 at 07:03PM +0100, Andreas Färber wrote: > > Am 12.11.2014 um 16:57 schrieb Sören Brinkmann: > > > On Wed, 2014-11-12 at 02:51PM +0100, Andreas Färber wrote: > > >> The specification requires xlnx,data-width, but example and driver use > > >> xlnx,datawidth. Change the specification to match the implementation. > > > > > > Isn't this the wrong way around? The bindings are considered API, so > > > shouldn't the driver be fixed to match the spec? > > > > In theory, patch review should've never let the two differ... ;) > > > > It's not my driver, so I fixed the perceived inconsistency the least > > invasive way; Michal and Srikanth seemed to concur at the time. > > > > https://patchwork.kernel.org/patch/4620261/ > > > > > Are there already dts files out there using either of these options? > > > > In upstream, no. microblaze and virtex440 use a > > xlnx,include-datawidth-matching-0 property as precedence for the > > spelling, whereas there is an fsl,data-width and an unused msix-data-width. > > > > Downstream, yes: Beyond my own patch derived from the Parallella tree, > > there's some in the ADI tree. None in the Xilinx tree on quick check. > > > > I haven't encountered any using the documented xlnx,data-width - but > > this patch was authored pre 3.17, haven't ran a full Web search again. > > grepping through linux-next shows some usage of xlnx,datawidth, but > only the single hit in Documentation for xlnx,data-width. > Other than VDMA the other hit seems to be just some DT > documentation which I can't find a driver for... > Anyhow, this patch is probably the best way of fixing this. the driver had issues so want applied, I havent seen repot though. Will apply this now -- ~Vinod > > Reviewed-by: Soren Brinkmann <soren.brinkmann@xilinx.com> > > Thanks, > Sören -- ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-12-05 16:47 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2014-11-12 13:51 [PATCH RESEND] Documentation: devicetree: Fix Xilinx VDMA specification Andreas Färber 2014-11-12 15:57 ` Sören Brinkmann 2014-11-12 18:03 ` Andreas Färber 2014-11-12 18:26 ` Sören Brinkmann 2014-12-05 16:47 ` Vinod Koul
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).