linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: am57xx-beagle-x15: Add GPIO controlled fan node
@ 2014-12-05 17:32 Nishanth Menon
  2014-12-05 17:36 ` Felipe Balbi
  2014-12-05 17:48 ` [PATCH V2] " Nishanth Menon
  0 siblings, 2 replies; 6+ messages in thread
From: Nishanth Menon @ 2014-12-05 17:32 UTC (permalink / raw)
  To: Tony Lindgren, Benoît Cousson
  Cc: linux-kernel, linux-arm-kernel, devicetree, linux-omap, balbi,
	Menon, Nishanth

From: "Menon, Nishanth" <nm@ti.com>

TPS gpio now controls a 5v 500mA TL5209 regulator which may be supply
a fan (such as AFB02505HHB) over J1 connector for various purposes.
Provide device tree node to enable the same.

Signed-off-by: Nishanth Menon <nm@ti.com>
---
Depends on the following:
https://patchwork.kernel.org/patch/5439201/
https://patchwork.kernel.org/patch/5439191/

enable and disable can be controlled by
echo '1' > /sys/class/hwmon/hwmon0/fan1_target
and
echo '0' > /sys/class/hwmon/hwmon0/fan1_target

requires CONFIG_GPIO_PALMAS and CONFIG_SENSORS_GPIO_FAN to be operational
Applies on 
https://git.kernel.org/cgit/linux/kernel/git/tmlind/linux-omap.git/log/?h=omap-for-v3.19/dt-v2

 arch/arm/boot/dts/am57xx-beagle-x15.dts |   15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/am57xx-beagle-x15.dts b/arch/arm/boot/dts/am57xx-beagle-x15.dts
index 49edbda..7fe82ef 100644
--- a/arch/arm/boot/dts/am57xx-beagle-x15.dts
+++ b/arch/arm/boot/dts/am57xx-beagle-x15.dts
@@ -80,6 +80,15 @@
 			default-state = "off";
 		};
 	};
+
+	gpio_fan {
+		/* Based on 5v 500mA AFB02505HHB */
+		compatible = "gpio-fan";
+		pinctrl-names = "default";
+		gpios =  <&tps659038_gpio 1 GPIO_ACTIVE_HIGH>;
+		gpio-fan,speed-map = <0    0
+				      13000 1>;
+	};
 };
 
 &dra7_pmx_core {
@@ -314,6 +323,12 @@
 			wakeup-source;
 			ti,palmas-long-press-seconds = <12>;
 		};
+
+		tps659038_gpio: tps659038_gpio {
+			compatible = "ti,palmas-gpio";
+			gpio-controller;
+			#gpio-cells = <2>;
+		};
 	};
 
 	tmp102: tmp102@48 {
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: dts: am57xx-beagle-x15: Add GPIO controlled fan node
  2014-12-05 17:32 [PATCH] ARM: dts: am57xx-beagle-x15: Add GPIO controlled fan node Nishanth Menon
@ 2014-12-05 17:36 ` Felipe Balbi
  2014-12-05 17:48 ` [PATCH V2] " Nishanth Menon
  1 sibling, 0 replies; 6+ messages in thread
From: Felipe Balbi @ 2014-12-05 17:36 UTC (permalink / raw)
  To: Nishanth Menon
  Cc: Tony Lindgren, Benoît Cousson, linux-kernel,
	linux-arm-kernel, devicetree, linux-omap, balbi

[-- Attachment #1: Type: text/plain, Size: 1885 bytes --]

On Fri, Dec 05, 2014 at 11:32:18AM -0600, Nishanth Menon wrote:
> From: "Menon, Nishanth" <nm@ti.com>

do you want to sanitize your name ?

> TPS gpio now controls a 5v 500mA TL5209 regulator which may be supply
> a fan (such as AFB02505HHB) over J1 connector for various purposes.
> Provide device tree node to enable the same.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> Depends on the following:
> https://patchwork.kernel.org/patch/5439201/
> https://patchwork.kernel.org/patch/5439191/
> 
> enable and disable can be controlled by
> echo '1' > /sys/class/hwmon/hwmon0/fan1_target
> and
> echo '0' > /sys/class/hwmon/hwmon0/fan1_target
> 
> requires CONFIG_GPIO_PALMAS and CONFIG_SENSORS_GPIO_FAN to be operational
> Applies on 
> https://git.kernel.org/cgit/linux/kernel/git/tmlind/linux-omap.git/log/?h=omap-for-v3.19/dt-v2
> 
>  arch/arm/boot/dts/am57xx-beagle-x15.dts |   15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am57xx-beagle-x15.dts b/arch/arm/boot/dts/am57xx-beagle-x15.dts
> index 49edbda..7fe82ef 100644
> --- a/arch/arm/boot/dts/am57xx-beagle-x15.dts
> +++ b/arch/arm/boot/dts/am57xx-beagle-x15.dts
> @@ -80,6 +80,15 @@
>  			default-state = "off";
>  		};
>  	};
> +
> +	gpio_fan {
> +		/* Based on 5v 500mA AFB02505HHB */
> +		compatible = "gpio-fan";
> +		pinctrl-names = "default";

not needed.

> +		gpios =  <&tps659038_gpio 1 GPIO_ACTIVE_HIGH>;
> +		gpio-fan,speed-map = <0    0
> +				      13000 1>;
> +	};
>  };
>  
>  &dra7_pmx_core {
> @@ -314,6 +323,12 @@
>  			wakeup-source;
>  			ti,palmas-long-press-seconds = <12>;
>  		};
> +
> +		tps659038_gpio: tps659038_gpio {
> +			compatible = "ti,palmas-gpio";
> +			gpio-controller;
> +			#gpio-cells = <2>;
> +		};
>  	};
>  
>  	tmp102: tmp102@48 {
> -- 
> 1.7.9.5
> 

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH V2] ARM: dts: am57xx-beagle-x15: Add GPIO controlled fan node
  2014-12-05 17:32 [PATCH] ARM: dts: am57xx-beagle-x15: Add GPIO controlled fan node Nishanth Menon
  2014-12-05 17:36 ` Felipe Balbi
@ 2014-12-05 17:48 ` Nishanth Menon
  2015-01-07 23:44   ` Tony Lindgren
  1 sibling, 1 reply; 6+ messages in thread
From: Nishanth Menon @ 2014-12-05 17:48 UTC (permalink / raw)
  To: Tony Lindgren, Benoît Cousson
  Cc: linux-kernel, linux-arm-kernel, devicetree, linux-omap, balbi,
	Nishanth Menon

TPS gpio now controls a 5v 500mA TL5209 regulator which may be supply
a fan (such as AFB02505HHB) over J1 connector for various purposes.
Provide device tree node to enable the same.

Signed-off-by: Nishanth Menon <nm@ti.com>
---

V2: review comment updates
	review comments update
		- Sanitized outlook-ified name back to normal ;) 
		- removed unnecessary pinctrl-names property.
V1: https://patchwork.kernel.org/patch/5444911/


Depends on the following:
https://patchwork.kernel.org/patch/5439201/
https://patchwork.kernel.org/patch/5439191/

enable and disable can be controlled by (post the RPM, it finds
closest match - even a 1 will do)

echo '13000' > /sys/class/hwmon/hwmon0/fan1_target
and
echo '0' > /sys/class/hwmon/hwmon0/fan1_target

Test log: http://slexy.org/view/s2T0ajh46z

requires CONFIG_GPIO_PALMAS and CONFIG_SENSORS_GPIO_FAN to be operational
Applies on 
https://git.kernel.org/cgit/linux/kernel/git/tmlind/linux-omap.git/log/?h=omap-for-v3.19/dt-v2

 arch/arm/boot/dts/am57xx-beagle-x15.dts |   14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm/boot/dts/am57xx-beagle-x15.dts b/arch/arm/boot/dts/am57xx-beagle-x15.dts
index 49edbda..4e55e94 100644
--- a/arch/arm/boot/dts/am57xx-beagle-x15.dts
+++ b/arch/arm/boot/dts/am57xx-beagle-x15.dts
@@ -80,6 +80,14 @@
 			default-state = "off";
 		};
 	};
+
+	gpio_fan {
+		/* Based on 5v 500mA AFB02505HHB */
+		compatible = "gpio-fan";
+		gpios =  <&tps659038_gpio 1 GPIO_ACTIVE_HIGH>;
+		gpio-fan,speed-map = <0    0
+				      13000 1>;
+	};
 };
 
 &dra7_pmx_core {
@@ -314,6 +322,12 @@
 			wakeup-source;
 			ti,palmas-long-press-seconds = <12>;
 		};
+
+		tps659038_gpio: tps659038_gpio {
+			compatible = "ti,palmas-gpio";
+			gpio-controller;
+			#gpio-cells = <2>;
+		};
 	};
 
 	tmp102: tmp102@48 {
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH V2] ARM: dts: am57xx-beagle-x15: Add GPIO controlled fan node
  2014-12-05 17:48 ` [PATCH V2] " Nishanth Menon
@ 2015-01-07 23:44   ` Tony Lindgren
  2015-01-07 23:58     ` Nishanth Menon
  0 siblings, 1 reply; 6+ messages in thread
From: Tony Lindgren @ 2015-01-07 23:44 UTC (permalink / raw)
  To: Nishanth Menon
  Cc: Benoît Cousson, linux-kernel, linux-arm-kernel, devicetree,
	linux-omap, balbi

* Nishanth Menon <nm@ti.com> [141205 09:51]:
> TPS gpio now controls a 5v 500mA TL5209 regulator which may be supply
> a fan (such as AFB02505HHB) over J1 connector for various purposes.
> Provide device tree node to enable the same.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>

Applying into omap-for-v3.20/dt thanks.

Tony

> ---
> 
> V2: review comment updates
> 	review comments update
> 		- Sanitized outlook-ified name back to normal ;) 
> 		- removed unnecessary pinctrl-names property.
> V1: https://patchwork.kernel.org/patch/5444911/
> 
> 
> Depends on the following:
> https://patchwork.kernel.org/patch/5439201/
> https://patchwork.kernel.org/patch/5439191/
> 
> enable and disable can be controlled by (post the RPM, it finds
> closest match - even a 1 will do)
> 
> echo '13000' > /sys/class/hwmon/hwmon0/fan1_target
> and
> echo '0' > /sys/class/hwmon/hwmon0/fan1_target
> 
> Test log: http://slexy.org/view/s2T0ajh46z
> 
> requires CONFIG_GPIO_PALMAS and CONFIG_SENSORS_GPIO_FAN to be operational
> Applies on 
> https://git.kernel.org/cgit/linux/kernel/git/tmlind/linux-omap.git/log/?h=omap-for-v3.19/dt-v2
> 
>  arch/arm/boot/dts/am57xx-beagle-x15.dts |   14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am57xx-beagle-x15.dts b/arch/arm/boot/dts/am57xx-beagle-x15.dts
> index 49edbda..4e55e94 100644
> --- a/arch/arm/boot/dts/am57xx-beagle-x15.dts
> +++ b/arch/arm/boot/dts/am57xx-beagle-x15.dts
> @@ -80,6 +80,14 @@
>  			default-state = "off";
>  		};
>  	};
> +
> +	gpio_fan {
> +		/* Based on 5v 500mA AFB02505HHB */
> +		compatible = "gpio-fan";
> +		gpios =  <&tps659038_gpio 1 GPIO_ACTIVE_HIGH>;
> +		gpio-fan,speed-map = <0    0
> +				      13000 1>;
> +	};
>  };
>  
>  &dra7_pmx_core {
> @@ -314,6 +322,12 @@
>  			wakeup-source;
>  			ti,palmas-long-press-seconds = <12>;
>  		};
> +
> +		tps659038_gpio: tps659038_gpio {
> +			compatible = "ti,palmas-gpio";
> +			gpio-controller;
> +			#gpio-cells = <2>;
> +		};
>  	};
>  
>  	tmp102: tmp102@48 {
> -- 
> 1.7.9.5
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH V2] ARM: dts: am57xx-beagle-x15: Add GPIO controlled fan node
  2015-01-07 23:44   ` Tony Lindgren
@ 2015-01-07 23:58     ` Nishanth Menon
  2015-01-08  0:19       ` Tony Lindgren
  0 siblings, 1 reply; 6+ messages in thread
From: Nishanth Menon @ 2015-01-07 23:58 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Benoît Cousson, linux-kernel, linux-arm-kernel, devicetree,
	linux-omap, balbi

On 15:44-20150107, Tony Lindgren wrote:
> * Nishanth Menon <nm@ti.com> [141205 09:51]:
> > TPS gpio now controls a 5v 500mA TL5209 regulator which may be supply
> > a fan (such as AFB02505HHB) over J1 connector for various purposes.
> > Provide device tree node to enable the same.
> > 
> > Signed-off-by: Nishanth Menon <nm@ti.com>
> 
> Applying into omap-for-v3.20/dt thanks.
> 
> Tony
Could you pick up the very latest rev:
https://patchwork.kernel.org/patch/5569521/ ?


> 
> > ---
> > 
> > V2: review comment updates
> > 	review comments update
> > 		- Sanitized outlook-ified name back to normal ;) 
> > 		- removed unnecessary pinctrl-names property.
> > V1: https://patchwork.kernel.org/patch/5444911/
> > 
> > 
> > Depends on the following:
> > https://patchwork.kernel.org/patch/5439201/
> > https://patchwork.kernel.org/patch/5439191/
> > 
> > enable and disable can be controlled by (post the RPM, it finds
> > closest match - even a 1 will do)
> > 
> > echo '13000' > /sys/class/hwmon/hwmon0/fan1_target
> > and
> > echo '0' > /sys/class/hwmon/hwmon0/fan1_target
> > 
> > Test log: http://slexy.org/view/s2T0ajh46z
> > 
> > requires CONFIG_GPIO_PALMAS and CONFIG_SENSORS_GPIO_FAN to be operational
> > Applies on 
> > https://git.kernel.org/cgit/linux/kernel/git/tmlind/linux-omap.git/log/?h=omap-for-v3.19/dt-v2
> > 
> >  arch/arm/boot/dts/am57xx-beagle-x15.dts |   14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/am57xx-beagle-x15.dts b/arch/arm/boot/dts/am57xx-beagle-x15.dts
> > index 49edbda..4e55e94 100644
> > --- a/arch/arm/boot/dts/am57xx-beagle-x15.dts
> > +++ b/arch/arm/boot/dts/am57xx-beagle-x15.dts
> > @@ -80,6 +80,14 @@
> >  			default-state = "off";
> >  		};
> >  	};
> > +
> > +	gpio_fan {
> > +		/* Based on 5v 500mA AFB02505HHB */
> > +		compatible = "gpio-fan";
> > +		gpios =  <&tps659038_gpio 1 GPIO_ACTIVE_HIGH>;
> > +		gpio-fan,speed-map = <0    0
> > +				      13000 1>;
> > +	};
> >  };
> >  
> >  &dra7_pmx_core {
> > @@ -314,6 +322,12 @@
> >  			wakeup-source;
> >  			ti,palmas-long-press-seconds = <12>;
> >  		};
> > +
> > +		tps659038_gpio: tps659038_gpio {
> > +			compatible = "ti,palmas-gpio";
> > +			gpio-controller;
> > +			#gpio-cells = <2>;
> > +		};
> >  	};
> >  
> >  	tmp102: tmp102@48 {
> > -- 
> > 1.7.9.5
> > 

-- 
Regards,
Nishanth Menon

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH V2] ARM: dts: am57xx-beagle-x15: Add GPIO controlled fan node
  2015-01-07 23:58     ` Nishanth Menon
@ 2015-01-08  0:19       ` Tony Lindgren
  0 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2015-01-08  0:19 UTC (permalink / raw)
  To: Nishanth Menon
  Cc: Benoît Cousson, linux-kernel, linux-arm-kernel, devicetree,
	linux-omap, balbi

* Nishanth Menon <nm@ti.com> [150107 16:01]:
> On 15:44-20150107, Tony Lindgren wrote:
> > * Nishanth Menon <nm@ti.com> [141205 09:51]:
> > > TPS gpio now controls a 5v 500mA TL5209 regulator which may be supply
> > > a fan (such as AFB02505HHB) over J1 connector for various purposes.
> > > Provide device tree node to enable the same.
> > > 
> > > Signed-off-by: Nishanth Menon <nm@ti.com>
> > 
> > Applying into omap-for-v3.20/dt thanks.
> > 
> > Tony
> Could you pick up the very latest rev:
> https://patchwork.kernel.org/patch/5569521/ ?

Yeah sorry just noticed I had tagged two versions,
will use the v4 instead.

Regards,

Tony

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-01-08  0:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-05 17:32 [PATCH] ARM: dts: am57xx-beagle-x15: Add GPIO controlled fan node Nishanth Menon
2014-12-05 17:36 ` Felipe Balbi
2014-12-05 17:48 ` [PATCH V2] " Nishanth Menon
2015-01-07 23:44   ` Tony Lindgren
2015-01-07 23:58     ` Nishanth Menon
2015-01-08  0:19       ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).